Merge pull request #66169 from liggitt/patch-retry-1.10

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/patch.go

@@ -173,18 +173,20 @@ func patchResource(
 
 	namespace := request.NamespaceValue(ctx)
 
+	var lastConflictErr error
+
+	// applyPatch is called every time GuaranteedUpdate asks for the updated object,
+	// and is given the currently persisted object as input.
+	applyPatch := func(_ request.Context, _, currentObject runtime.Object) (runtime.Object, error) {
+		// make these local vars so every patch attempt is handled as if it were the first attempt
 		var (
 			originalObjJS           []byte
 			originalPatchedObjJS    []byte
 			originalObjMap          map[string]interface{}
 			getOriginalPatchMap     func() (map[string]interface{}, error)
-		lastConflictErr         error
 			originalResourceVersion string
 		)
 
-	// applyPatch is called every time GuaranteedUpdate asks for the updated object,
-	// and is given the currently persisted object as input.
-	applyPatch := func(_ request.Context, _, currentObject runtime.Object) (runtime.Object, error) {
 		// Make sure we actually have a persisted currentObject
 		trace.Step("About to apply patch")
 		if hasUID, err := hasUID(currentObject); err != nil {

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/rest_test.go

@@ -533,8 +533,7 @@ func TestPatchResourceWithConflict(t *testing.T) {
 		startingPod: &example.Pod{},
 		changedPod:  &example.Pod{},
 		updatePod:   &example.Pod{},
-
-		expectedError: `Operation cannot be fulfilled on pods.example.apiserver.k8s.io "foo": existing 2, new 1`,
+		expectedPod: &example.Pod{},
 	}
 
 	tc.startingPod.Name = name
@@ -558,6 +557,13 @@ func TestPatchResourceWithConflict(t *testing.T) {
 	tc.updatePod.APIVersion = examplev1.SchemeGroupVersion.String()
 	tc.updatePod.Spec.NodeName = "anywhere"
 
+	tc.expectedPod.Name = name
+	tc.expectedPod.Namespace = namespace
+	tc.expectedPod.UID = uid
+	tc.expectedPod.ResourceVersion = "2"
+	tc.expectedPod.APIVersion = examplev1.SchemeGroupVersion.String()
+	tc.expectedPod.Spec.NodeName = "there"
+
 	tc.Run(t)
 }