e2e: Allow max-node-to-gather to be changed when running against larger clusters

While debugging issues I found myself having to change the constant in the code for a cluster > 20 nodes, and then on a very small cluster I found myself passing 0 to avoid the mostly useless output (it's useful in specific scenarios but generates a *lot* of output that doesn't help debugging the rest of the time).

e2e: Allow max-node-to-gather to be changed when running against larger clusters
653ed22f · Clayton Coleman · 9b9f5f94 · 653ed22f · 653ed22f
Unverified Commit 653ed22f authored Nov 27, 2018 by Clayton Coleman
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

test_context.go test/e2e/framework/test_context.go +2 -0

util.go test/e2e/framework/util.go +1 -1

No files found.
--- a/test/e2e/framework/test_context.go
+++ b/test/e2e/framework/test_context.go
@@ -115,6 +115,7 @@ type TestContextType struct {
 	GatherLogsSizes                   bool
 	GatherMetricsAfterTest            string
 	GatherSuiteMetricsAfterTest       bool
+	MaxNodesToGather                  int
 	AllowGatheringProfiles            bool
 	// If set to 'true' framework will gather ClusterAutoscaler metrics when gathering them for other components.
 	IncludeClusterAutoscalerMetrics bool
@@ -206,6 +207,7 @@ func RegisterCommonFlags() {

 	flag.StringVar(&TestContext.GatherKubeSystemResourceUsageData, "gather-resource-usage", "false", "If set to 'true' or 'all' framework will be monitoring resource usage of system all add-ons in (some) e2e tests, if set to 'master' framework will be monitoring master node only, if set to 'none' of 'false' monitoring will be turned off.")
 	flag.BoolVar(&TestContext.GatherLogsSizes, "gather-logs-sizes", false, "If set to true framework will be monitoring logs sizes on all machines running e2e tests.")
+	flag.IntVar(&TestContext.MaxNodesToGather, "max-nodes-to-gather-from", 20, "The maximum number of nodes to gather extended info from on test failure.")
 	flag.StringVar(&TestContext.GatherMetricsAfterTest, "gather-metrics-at-teardown", "false", "If set to 'true' framework will gather metrics from all components after each test. If set to 'master' only master component metrics would be gathered.")
 	flag.BoolVar(&TestContext.GatherSuiteMetricsAfterTest, "gather-suite-metrics-at-teardown", false, "If set to true framwork will gather metrics from all components after the whole test suite completes.")
 	flag.BoolVar(&TestContext.AllowGatheringProfiles, "allow-gathering-profiles", true, "If set to true framework will allow to gather CPU/memory allocation pprof profiles from the master.")

--- a/test/e2e/framework/util.go
+++ b/test/e2e/framework/util.go
@@ -2491,7 +2491,7 @@ func DumpAllNamespaceInfo(c clientset.Interface, namespace string) {
 	// 1. it takes tens of minutes or hours to grab all of them
 	// 2. there are so many of them that working with them are mostly impossible
 	// So we dump them only if the cluster is relatively small.
-	maxNodesForDump := 20
+	maxNodesForDump := TestContext.MaxNodesToGather
 	if nodes, err := c.CoreV1().Nodes().List(metav1.ListOptions{}); err == nil {
 		if len(nodes.Items) <= maxNodesForDump {
 			dumpAllPodInfo(c)