Merge pull request #69080 from tanshanshan/little926

hack/.golint_failures

@@ -528,12 +528,9 @@ staging/src/k8s.io/apiserver/pkg/admission
 staging/src/k8s.io/apiserver/pkg/admission/configuration
 staging/src/k8s.io/apiserver/pkg/admission/initializer
 staging/src/k8s.io/apiserver/pkg/admission/plugin/initialization
-staging/src/k8s.io/apiserver/pkg/admission/plugin/namespace/lifecycle
 staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/config/apis/webhookadmission
 staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/config/apis/webhookadmission/v1alpha1
-staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating
 staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/testcerts
-staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/validating
 staging/src/k8s.io/apiserver/pkg/apis/apiserver
 staging/src/k8s.io/apiserver/pkg/apis/apiserver/v1alpha1
 staging/src/k8s.io/apiserver/pkg/apis/audit

staging/src/k8s.io/apiserver/pkg/admission/plugin/initialization/initialization.go

@@ -56,6 +56,7 @@ type initializerOptions struct {
 	Initializers []string
 }
 
+// InitializationConfig specifies initialization config
 type InitializationConfig interface {
 	Run(stopCh <-chan struct{})
 	Initializers() (*v1alpha1.InitializerConfiguration, error)

staging/src/k8s.io/apiserver/pkg/admission/plugin/namespace/lifecycle/admission.go

@@ -38,7 +38,7 @@ import (
 )
 
 const (
-	// Name of admission plug-in
+	// PluginName indicates the name of admission plug-in
 	PluginName = "NamespaceLifecycle"
 	// how long a namespace stays in the force live lookup cache before expiration.
 	forceLiveLookupTTL = 30 * time.Second
@@ -72,6 +72,7 @@ type Lifecycle struct {
 var _ = initializer.WantsExternalKubeInformerFactory(&Lifecycle{})
 var _ = initializer.WantsExternalKubeClientSet(&Lifecycle{})
 
+// Admit makes an admission decision based on the request attributes
 func (l *Lifecycle) Admit(a admission.Attributes) error {
 	// prevent deletion of immortal namespaces
 	if a.GetOperation() == admission.Delete && a.GetKind().GroupKind() == v1.SchemeGroupVersion.WithKind("Namespace").GroupKind() && l.immortalNamespaces.Has(a.GetName()) {

staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating/plugin.go

@@ -28,7 +28,7 @@ import (
 )
 
 const (
-	// Name of admission plug-in
+	// PluginName indicates the name of admission plug-in
 	PluginName = "MutatingAdmissionWebhook"
 )
 

staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/validating/plugin.go

@@ -25,7 +25,7 @@ import (
 )
 
 const (
-	// Name of admission plug-in
+	// PluginName indicates the name of admission plug-in
 	PluginName = "ValidatingAdmissionWebhook"
 )