Skip to content

K
k3s
Commit 682f3a39 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #45171 from ncdc/groupName-override

Automatic merge from submit-queue Use groupName comment for listers/informers If present, use the "// +groupName" doc comment as the desired group name when generating listers and informers. @kubernetes/sig-api-machinery-pr-reviews @smarterclayton @deads2k @liggitt @sttts
parents 51d6429a a5761d80
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 0 deletions
cmd/libs/go2idl/informer-gen/generators/packages.go
View file @ 682f3a39
......@@ -150,6 +150,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
targetGroupVersions = externalGroupVersions
}
// If there's a comment of the form "// +groupName=somegroup" or
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
// group when generating.
if override := types.ExtractCommentTags("+", p.DocComments)["groupName"]; override != nil {
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
}
var typesToGenerate []*types.Type
for _, t := range p.Types {
// filter out types which dont have genclient=true.
......
cmd/libs/go2idl/lister-gen/generators/lister.go
View file @ 682f3a39
......@@ -106,6 +106,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
internalGVPkg = strings.Join(parts[0:len(parts)-1], "/")
}
// If there's a comment of the form "// +groupName=somegroup" or
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
// group when generating.
if override := types.ExtractCommentTags("+", p.DocComments)["groupName"]; override != nil {
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
}
var typesToGenerate []*types.Type
for _, t := range p.Types {
// filter out types which dont have genclient=true.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment