Skip to content

K
k3s
Commit 70deeb0a authored by Jing Xu's avatar Jing Xu
Browse files
Options

node not exist during node status update should not block others

When node is deleted, attach-detach controller cache may contain stale information of this node, and update node status fails in reconciler loop. But one node update failure should not block updating other nodes. Also the warning message easily flush the log file. This PR is just a quick fix of this issue. More complete fix including make sure controller cache up to date will be addressed in another PR.
parent 2166ce2f
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 1 deletion
pkg/controller/volume/attachdetach/statusupdater/node_status_updater.go
View file @ 70deeb0a
...@@ -63,7 +63,7 @@ func (nsu *nodeStatusUpdater) UpdateNodeStatuses() error { ...@@ -63,7 +63,7 @@ func (nsu *nodeStatusUpdater) UpdateNodeStatuses() error {
nodeObj, exists, err := nsu.nodeInformer.GetStore().GetByKey(nodeName) nodeObj, exists, err := nsu.nodeInformer.GetStore().GetByKey(nodeName)
if nodeObj == nil || !exists || err != nil { if nodeObj == nil || !exists || err != nil {
// If node does not exist, its status cannot be updated, log error and move on. // If node does not exist, its status cannot be updated, log error and move on.
glog.Warningf( glog.V(5).Infof(
"Could not update node status. Failed to find node %q in NodeInformer cache. %v", "Could not update node status. Failed to find node %q in NodeInformer cache. %v",
nodeName, nodeName,
err) err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment