Merge pull request #32142 from juanvallejo/jvallejo_bugfix/remove-compinit-call-zsh-completions

Automatic merge from submit-queue remove call to compinit in zsh completion output **Release note**: ```release-note release-note-none ``` Fixes: https://github.com/kubernetes/kubernetes/issues/32029 Fixes: https://github.com/kubernetes/kubernetes/issues/27538#issuecomment-238574035 The zsh completion output makes a call to "compinit" which causes the zsh completion system to re-initialize every time `<root_cmd> completion zsh` is sourced, overwriting any settings already applied to other commands. This in-turn caused other commands' completions to break (such as git, gcloud, vim) causing an error "function definition file not found" to be returned any time a tab-completion was attempted. This patch removes the call to `compinit` in the zsh completion output, causing no behavioral changes to the existing `completion` command, but fixing any issues that were caused after sourcing its output.

Merge pull request #32142 from juanvallejo/jvallejo_bugfix/remove-compinit-call-zsh-completions
786cc3ef · Kubernetes Submit Queue · GitHub · 819f92c9 · 4bf98096 · 786cc3ef
Commit 786cc3ef authored Oct 13, 2016 by Kubernetes Submit Queue Committed by GitHub Oct 13, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 1 deletion

completion.go pkg/kubectl/cmd/completion.go +0 -1

No files found.
--- a/pkg/kubectl/cmd/completion.go
+++ b/pkg/kubectl/cmd/completion.go
@@ -237,7 +237,6 @@ __kubectl_quote() {
    fi
 }
-autoload -U +X compinit && compinit
 autoload -U +X bashcompinit && bashcompinit
 # use word boundary patterns for BSD or GNU sed