Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
7a958cf9
Unverified
Commit
7a958cf9
authored
Nov 28, 2018
by
k8s-ci-robot
Committed by
GitHub
Nov 28, 2018
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #68402 from saravanan30erd/cloudprovider-ovirt
Fix golint failures - pkg/cloudprovider/providers/ovirt
parents
8b11fda2
14a9fa47
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
57 additions
and
47 deletions
+57
-47
.golint_failures
hack/.golint_failures
+0
-1
ovirt.go
pkg/cloudprovider/providers/ovirt/ovirt.go
+53
-42
ovirt_test.go
pkg/cloudprovider/providers/ovirt/ovirt_test.go
+4
-4
No files found.
hack/.golint_failures
View file @
7a958cf9
...
...
@@ -89,7 +89,6 @@ pkg/auth/authorizer/abac
pkg/capabilities
pkg/cloudprovider/providers/fake
pkg/cloudprovider/providers/gce/cloud
pkg/cloudprovider/providers/ovirt
pkg/cloudprovider/providers/photon
pkg/cloudprovider/providers/vsphere
pkg/cloudprovider/providers/vsphere/vclib
...
...
pkg/cloudprovider/providers/ovirt/ovirt.go
View file @
7a958cf9
This diff is collapsed.
Click to expand it.
pkg/cloudprovider/providers/ovirt/ovirt_test.go
View file @
7a958cf9
...
...
@@ -62,14 +62,14 @@ uri = https://localhost:8443/ovirt-engine/api
func
TestOVirtCloudXmlParsing
(
t
*
testing
.
T
)
{
body1
:=
(
io
.
Reader
)(
nil
)
_
,
err1
:=
getInstancesFromX
ml
(
body1
)
_
,
err1
:=
getInstancesFromX
ML
(
body1
)
if
err1
==
nil
{
t
.
Fatalf
(
"An error is expected when body is missing"
)
}
body2
:=
strings
.
NewReader
(
""
)
_
,
err2
:=
getInstancesFromX
ml
(
body2
)
_
,
err2
:=
getInstancesFromX
ML
(
body2
)
if
err2
==
nil
{
t
.
Fatalf
(
"An error is expected when body is empty"
)
}
...
...
@@ -80,7 +80,7 @@ func TestOVirtCloudXmlParsing(t *testing.T) {
</vms>
`
)
instances3
,
err3
:=
getInstancesFromX
ml
(
body3
)
instances3
,
err3
:=
getInstancesFromX
ML
(
body3
)
if
err3
!=
nil
{
t
.
Fatalf
(
"Unexpected error listing instances: %s"
,
err3
)
}
...
...
@@ -111,7 +111,7 @@ func TestOVirtCloudXmlParsing(t *testing.T) {
</vms>
`
)
instances4
,
err4
:=
getInstancesFromX
ml
(
body4
)
instances4
,
err4
:=
getInstancesFromX
ML
(
body4
)
if
err4
!=
nil
{
t
.
Fatalf
(
"Unexpected error listing instances: %s"
,
err4
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment