fix a few go-vet errors

pkg/controller/persistentvolume/persistentvolume_provisioner_controller.go

@@ -202,7 +202,7 @@ func (controller *PersistentVolumeProvisionerController) reconcileClaim(claim *a
 	claim.Annotations[pvProvisioningRequiredAnnotationKey] = pvProvisioningCompletedAnnotationValue
 	_, err = controller.client.UpdatePersistentVolumeClaim(claim)
 	if err != nil {
-		glog.Error("error updating persistent volume claim: %v", err)
+		glog.Errorf("error updating persistent volume claim: %v", err)
 	}
 
 	return nil
@@ -246,7 +246,7 @@ func (controller *PersistentVolumeProvisionerController) reconcileVolume(pv *api
 	glog.V(5).Infof("PersistentVolume[%s] provisioning in progress", pv.Name)
 	err := provisionVolume(pv, controller)
 	if err != nil {
-		return fmt.Errorf("Error provisioning PersistentVolume[%s]: %v", err)
+		return fmt.Errorf("Error provisioning PersistentVolume[%s]: %v", pv.Name, err)
 	}
 
 	return nil
@@ -283,7 +283,7 @@ func provisionVolume(pv *api.PersistentVolume, controller *PersistentVolumeProvi
 		if pv, apiErr := controller.client.UpdatePersistentVolumeStatus(pv); apiErr != nil {
 			return fmt.Errorf("PersistentVolume[%s] failed provisioning and also failed status update: %v  -  %v", pv.Name, err, apiErr)
 		}
-		return fmt.Errorf("PersistentVolume[%s] failed provisioning : %v", pv.Name, err, err)
+		return fmt.Errorf("PersistentVolume[%s] failed provisioning: %v", pv.Name, err)
 	}
 
 	clone, err := conversion.NewCloner().DeepCopy(pv)

pkg/probe/tcp/tcp_test.go

@@ -79,7 +79,7 @@ func TestTcpHealthChecker(t *testing.T) {
 			t.Errorf("#%d: expected error=%v, get=%v", i, tt.expectedError, err)
 		}
 		if !containsAny(output, tt.expectedOutputs) {
-			t.Errorf("#%d: expected output=one of %#v, get=%s", tt.expectedOutputs, output)
+			t.Errorf("#%d: expected output=one of %#v, get=%s", i, tt.expectedOutputs, output)
 		}
 	}
 }

pkg/util/iptables/iptables_test.go

@@ -673,7 +673,7 @@ func TestReload(t *testing.T) {
 			// EnsureChain
 			func() ([]byte, error) { return []byte{}, nil },
 			// EnsureRule abc check
-			func() ([]byte, error) { return []byte{}, &exec.FakeExitError{1} },
+			func() ([]byte, error) { return []byte{}, &exec.FakeExitError{Status: 1} },
 			// EnsureRule abc
 			func() ([]byte, error) { return []byte{}, nil },
 
@@ -681,7 +681,7 @@ func TestReload(t *testing.T) {
 			// EnsureChain
 			func() ([]byte, error) { return []byte{}, nil },
 			// EnsureRule abc check
-			func() ([]byte, error) { return []byte{}, &exec.FakeExitError{1} },
+			func() ([]byte, error) { return []byte{}, &exec.FakeExitError{Status: 1} },
 			// EnsureRule abc
 			func() ([]byte, error) { return []byte{}, nil },
 		},

pkg/util/net/port_range.go

@@ -102,7 +102,7 @@ func ParsePortRange(value string) (*PortRange, error) {
 func ParsePortRangeOrDie(value string) *PortRange {
 	pr, err := ParsePortRange(value)
 	if err != nil {
-		panic(fmt.Sprintf("couldn't parse port range: %v"))
+		panic(fmt.Sprintf("couldn't parse port range %q: %v", value, err))
 	}
 	return pr
 }

pkg/util/validation/field/errors.go

@@ -120,8 +120,7 @@ func (t ErrorType) String() string {
 	case ErrorTypeInternal:
 		return "Internal error"
 	default:
-		panic(fmt.Sprintf("unrecognized validation error: %q", t))
-		return ""
+		panic(fmt.Sprintf("unrecognized validation error: %q", string(t)))
 	}
 }
 

pkg/volume/azure_file/azure_file_test.go

@@ -83,7 +83,7 @@ func contains(modes []api.PersistentVolumeAccessMode, mode api.PersistentVolumeA
 func TestPlugin(t *testing.T) {
 	tmpDir, err := ioutil.TempDir(os.TempDir(), "azurefileTest")
 	if err != nil {
-		t.Fatalf("can't make a temp dir: %v")
+		t.Fatalf("can't make a temp dir: %v", err)
 	}
 	defer os.RemoveAll(tmpDir)
 	plugMgr := volume.VolumePluginMgr{}

pkg/volume/cephfs/cephfs_test.go

@@ -81,7 +81,7 @@ func TestPlugin(t *testing.T) {
 		t.Errorf("Failed to make a new Builder: %v", err)
 	}
 	if builder == nil {
-		t.Errorf("Got a nil Builder: %v")
+		t.Errorf("Got a nil Builder")
 	}
 	volpath := path.Join(tmpDir, "pods/poduid/volumes/kubernetes.io~cephfs/vol1")
 	path := builder.GetPath()
@@ -103,7 +103,7 @@ func TestPlugin(t *testing.T) {
 		t.Errorf("Failed to make a new Cleaner: %v", err)
 	}
 	if cleaner == nil {
-		t.Errorf("Got a nil Cleaner: %v")
+		t.Errorf("Got a nil Cleaner")
 	}
 	if err := cleaner.TearDown(); err != nil {
 		t.Errorf("Expected success, got: %v", err)

pkg/volume/cinder/cinder_test.go

@@ -158,7 +158,7 @@ func TestPlugin(t *testing.T) {
 		t.Errorf("Failed to make a new Builder: %v", err)
 	}
 	if builder == nil {
-		t.Errorf("Got a nil Builder: %v")
+		t.Errorf("Got a nil Builder")
 	}
 	volPath := path.Join(tmpDir, "pods/poduid/volumes/kubernetes.io~cinder/vol1")
 	path := builder.GetPath()
@@ -189,7 +189,7 @@ func TestPlugin(t *testing.T) {
 		t.Errorf("Failed to make a new Cleaner: %v", err)
 	}
 	if cleaner == nil {
-		t.Errorf("Got a nil Cleaner: %v")
+		t.Errorf("Got a nil Cleaner")
 	}
 
 	if err := cleaner.TearDown(); err != nil {
@@ -274,7 +274,7 @@ func TestAttachDetachRace(t *testing.T) {
 		t.Errorf("Failed to make a new Builder: %v", err)
 	}
 	if builder == nil {
-		t.Errorf("Got a nil Builder: %v")
+		t.Errorf("Got a nil Builder")
 	}
 
 	if err := builder.SetUp(nil); err != nil {
@@ -288,7 +288,7 @@ func TestAttachDetachRace(t *testing.T) {
 		t.Errorf("Failed to make a new Builder: %v", err)
 	}
 	if builder == nil {
-		t.Errorf("Got a nil Builder: %v")
+		t.Errorf("Got a nil Builder")
 	}
 
 	cleaner, err := plug.(*cinderPlugin).newCleanerInternal("vol1", types.UID("poduid"), &fakePDManager{time.Second}, fakeMounter)
@@ -337,7 +337,7 @@ func TestAttachDetachRace(t *testing.T) {
 		t.Errorf("Failed to make a new Cleaner: %v", err)
 	}
 	if cleaner == nil {
-		t.Errorf("Got a nil Cleaner: %v")
+		t.Errorf("Got a nil Cleaner")
 	}
 
 	if err := cleaner.TearDown(); err != nil {

pkg/volume/fc/fc_test.go

@@ -144,7 +144,7 @@ func doTestPlugin(t *testing.T, spec *volume.Spec) {
 		t.Errorf("Failed to make a new Builder: %v", err)
 	}
 	if builder == nil {
-		t.Errorf("Got a nil Builder: %v")
+		t.Errorf("Got a nil Builder: %v", err)
 	}
 
 	path := builder.GetPath()
@@ -181,7 +181,7 @@ func doTestPlugin(t *testing.T, spec *volume.Spec) {
 		t.Errorf("Failed to make a new Cleaner: %v", err)
 	}
 	if cleaner == nil {
-		t.Errorf("Got a nil Cleaner: %v")
+		t.Errorf("Got a nil Cleaner: %v", err)
 	}
 
 	if err := cleaner.TearDown(); err != nil {

test/e2e/e2e.go

@@ -119,7 +119,7 @@ func setupProviderConfig() error {
 		managedZones := []string{zone} // Only single-zone for now
 		cloudConfig.Provider, err = gcecloud.CreateGCECloud(testContext.CloudConfig.ProjectID, region, zone, managedZones, "" /* networkUrl */, tokenSource, false /* useMetadataServer */)
 		if err != nil {
-			return fmt.Errorf("Error building GCE/GKE provider: ", err)
+			return fmt.Errorf("Error building GCE/GKE provider: %v", err)
 		}
 
 	case "aws":
@@ -137,7 +137,7 @@ func setupProviderConfig() error {
 		var err error
 		cloudConfig.Provider, err = cloudprovider.GetCloudProvider(testContext.Provider, strings.NewReader(awsConfig))
 		if err != nil {
-			return fmt.Errorf("Error building AWS provider: ", err)
+			return fmt.Errorf("Error building AWS provider: %v", err)
 		}
 
 	}