Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
807d7ba8
Commit
807d7ba8
authored
Sep 02, 2016
by
Euan Kemp
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
rkt: Remove recommended rkt version
This has been unhelpful logspam forever basically. We always want newer versions of rkt to be viable options, and often they have bugfixes as well.
parent
be290b59
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
13 deletions
+3
-13
rkt.go
pkg/kubelet/rkt/rkt.go
+2
-3
version.go
pkg/kubelet/rkt/version.go
+1
-10
No files found.
pkg/kubelet/rkt/rkt.go
View file @
807d7ba8
...
@@ -70,8 +70,7 @@ const (
...
@@ -70,8 +70,7 @@ const (
RktType
=
"rkt"
RktType
=
"rkt"
DefaultRktAPIServiceEndpoint
=
"localhost:15441"
DefaultRktAPIServiceEndpoint
=
"localhost:15441"
minimumRktBinVersion
=
"1.13.0"
minimumRktBinVersion
=
"1.13.0"
recommendedRktBinVersion
=
"1.13.0"
minimumRktApiVersion
=
"1.0.0-alpha"
minimumRktApiVersion
=
"1.0.0-alpha"
minimumSystemdVersion
=
"219"
minimumSystemdVersion
=
"219"
...
@@ -1679,7 +1678,7 @@ func (r *Runtime) APIVersion() (kubecontainer.Version, error) {
...
@@ -1679,7 +1678,7 @@ func (r *Runtime) APIVersion() (kubecontainer.Version, error) {
// Status returns error if rkt is unhealthy, nil otherwise.
// Status returns error if rkt is unhealthy, nil otherwise.
func
(
r
*
Runtime
)
Status
()
error
{
func
(
r
*
Runtime
)
Status
()
error
{
return
r
.
checkVersion
(
minimumRktBinVersion
,
recommendedRktBinVersion
,
minimumRktApiVersion
,
minimumSystemdVersion
)
return
r
.
checkVersion
(
minimumRktBinVersion
,
minimumRktApiVersion
,
minimumSystemdVersion
)
}
}
// SyncPod syncs the running pod to match the specified desired pod.
// SyncPod syncs the running pod to match the specified desired pod.
...
...
pkg/kubelet/rkt/version.go
View file @
807d7ba8
...
@@ -22,7 +22,6 @@ import (
...
@@ -22,7 +22,6 @@ import (
"github.com/coreos/go-semver/semver"
"github.com/coreos/go-semver/semver"
rktapi
"github.com/coreos/rkt/api/v1alpha"
rktapi
"github.com/coreos/rkt/api/v1alpha"
"github.com/golang/glog"
"golang.org/x/net/context"
"golang.org/x/net/context"
)
)
...
@@ -98,7 +97,7 @@ func (r *Runtime) getVersions() error {
...
@@ -98,7 +97,7 @@ func (r *Runtime) getVersions() error {
// checkVersion tests whether the rkt/systemd/rkt-api-service that meet the version requirement.
// checkVersion tests whether the rkt/systemd/rkt-api-service that meet the version requirement.
// If all version requirements are met, it returns nil.
// If all version requirements are met, it returns nil.
func
(
r
*
Runtime
)
checkVersion
(
minimumRktBinVersion
,
recommendedRktBinVersion
,
minimumRktApiVersion
,
minimumSystemdVersion
string
)
error
{
func
(
r
*
Runtime
)
checkVersion
(
minimumRktBinVersion
,
minimumRktApiVersion
,
minimumSystemdVersion
string
)
error
{
if
err
:=
r
.
getVersions
();
err
!=
nil
{
if
err
:=
r
.
getVersions
();
err
!=
nil
{
return
err
return
err
}
}
...
@@ -123,14 +122,6 @@ func (r *Runtime) checkVersion(minimumRktBinVersion, recommendedRktBinVersion, m
...
@@ -123,14 +122,6 @@ func (r *Runtime) checkVersion(minimumRktBinVersion, recommendedRktBinVersion, m
if
result
<
0
{
if
result
<
0
{
return
fmt
.
Errorf
(
"rkt: binary version is too old(%v), requires at least %v"
,
r
.
versions
.
binVersion
,
minimumRktBinVersion
)
return
fmt
.
Errorf
(
"rkt: binary version is too old(%v), requires at least %v"
,
r
.
versions
.
binVersion
,
minimumRktBinVersion
)
}
}
result
,
err
=
r
.
versions
.
binVersion
.
Compare
(
recommendedRktBinVersion
)
if
err
!=
nil
{
return
err
}
if
result
!=
0
{
// TODO(yifan): Record an event to expose the information.
glog
.
Warningf
(
"rkt: current binary version %q is not recommended (recommended version %q)"
,
r
.
versions
.
binVersion
,
recommendedRktBinVersion
)
}
// Check rkt API version.
// Check rkt API version.
result
,
err
=
r
.
versions
.
apiVersion
.
Compare
(
minimumRktApiVersion
)
result
,
err
=
r
.
versions
.
apiVersion
.
Compare
(
minimumRktApiVersion
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment