Merge pull request #60602 from bendrucker/docker-registry-email-optional

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove docker-email from required args for "create secret docker-registry" Completes https://github.com/kubernetes/kubernetes/pull/42191 While that removed `docker-email` as required from the generator, the CLI still asserts the presence of the argument resulting in "error: flag docker-email is required" when `--docker-email` is omitted from a `kubectl create secret docker-registry` call. Comments on the original issue (https://github.com/kubernetes/kubernetes/issues/41727) note that this change is still needed to accomplish the original intent.

Merge pull request #60602 from bendrucker/docker-registry-email-optional
808545a8 · Kubernetes Submit Queue · GitHub · 3b04de4b · aa139f16 · 808545a8
Unverified Commit 808545a8 authored Mar 21, 2018 by Kubernetes Submit Queue Committed by GitHub Mar 21, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

create_secret.go pkg/kubectl/cmd/create_secret.go +1 -1

No files found.
--- a/pkg/kubectl/cmd/create_secret.go
+++ b/pkg/kubectl/cmd/create_secret.go
@@ -182,7 +182,7 @@ func CreateSecretDockerRegistry(f cmdutil.Factory, cmdOut io.Writer, cmd *cobra.
 	if err != nil {
 		return err
 	}
-	requiredFlags := []string{"docker-username", "docker-password", "docker-email", "docker-server"}
+	requiredFlags := []string{"docker-username", "docker-password", "docker-server"}
 	for _, requiredFlag := range requiredFlags {
 		if value := cmdutil.GetFlagString(cmd, requiredFlag); len(value) == 0 {
 			return cmdutil.UsageErrorf(cmd, "flag %s is required", requiredFlag)