Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
86f24eaf
Commit
86f24eaf
authored
Aug 30, 2017
by
Solly Ross
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update HPA REST metrics client to metrics/v1beta1
This commit updates the REST metrics client to use metrics/v1beta1. The legacy client still uses metrics/v1alpha1.
parent
580b28e2
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
12 additions
and
10 deletions
+12
-10
BUILD
cmd/kube-controller-manager/app/BUILD
+1
-1
autoscaling.go
cmd/kube-controller-manager/app/autoscaling.go
+1
-1
BUILD
pkg/controller/podautoscaler/BUILD
+1
-0
horizontal_test.go
pkg/controller/podautoscaler/horizontal_test.go
+2
-2
BUILD
pkg/controller/podautoscaler/metrics/BUILD
+2
-1
rest_metrics_client.go
pkg/controller/podautoscaler/metrics/rest_metrics_client.go
+1
-1
rest_metrics_client_test.go
...troller/podautoscaler/metrics/rest_metrics_client_test.go
+2
-2
replica_calculator_test.go
pkg/controller/podautoscaler/replica_calculator_test.go
+2
-2
No files found.
cmd/kube-controller-manager/app/BUILD
View file @
86f24eaf
...
...
@@ -126,7 +126,7 @@ go_library(
"//vendor/k8s.io/client-go/tools/leaderelection/resourcelock:go_default_library",
"//vendor/k8s.io/client-go/tools/record:go_default_library",
"//vendor/k8s.io/client-go/util/cert:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
alph
a1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
bet
a1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/custom_metrics:go_default_library",
],
)
...
...
cmd/kube-controller-manager/app/autoscaling.go
View file @
86f24eaf
...
...
@@ -24,7 +24,7 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/kubernetes/pkg/controller/podautoscaler"
"k8s.io/kubernetes/pkg/controller/podautoscaler/metrics"
resourceclient
"k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
alph
a1"
resourceclient
"k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
bet
a1"
"k8s.io/metrics/pkg/client/custom_metrics"
)
...
...
pkg/controller/podautoscaler/BUILD
View file @
86f24eaf
...
...
@@ -80,6 +80,7 @@ go_test(
"//vendor/k8s.io/heapster/metrics/api/v1/types:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/custom_metrics/v1beta1:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/metrics/v1alpha1:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/metrics/v1beta1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/clientset_generated/clientset/fake:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/custom_metrics/fake:go_default_library",
],
...
...
pkg/controller/podautoscaler/horizontal_test.go
View file @
86f24eaf
...
...
@@ -45,7 +45,7 @@ import (
cmfake
"k8s.io/metrics/pkg/client/custom_metrics/fake"
cmapi
"k8s.io/metrics/pkg/apis/custom_metrics/v1beta1"
metricsapi
"k8s.io/metrics/pkg/apis/metrics/v1
alph
a1"
metricsapi
"k8s.io/metrics/pkg/apis/metrics/v1
bet
a1"
"github.com/stretchr/testify/assert"
...
...
@@ -549,7 +549,7 @@ func (tc *testCase) setupController(t *testing.T) (*HorizontalController, inform
testCMClient
=
tc
.
testCMClient
}
metricsClient
:=
metrics
.
NewRESTMetricsClient
(
testMetricsClient
.
MetricsV1
alph
a1
(),
testMetricsClient
.
MetricsV1
bet
a1
(),
testCMClient
,
)
...
...
pkg/controller/podautoscaler/metrics/BUILD
View file @
86f24eaf
...
...
@@ -26,7 +26,7 @@ go_library(
"//vendor/k8s.io/heapster/metrics/api/v1/types:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/custom_metrics/v1beta1:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/metrics/v1alpha1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
alph
a1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
bet
a1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/custom_metrics:go_default_library",
],
)
...
...
@@ -55,6 +55,7 @@ go_test(
"//vendor/k8s.io/heapster/metrics/api/v1/types:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/custom_metrics/v1beta1:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/metrics/v1alpha1:go_default_library",
"//vendor/k8s.io/metrics/pkg/apis/metrics/v1beta1:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/clientset_generated/clientset/fake:go_default_library",
"//vendor/k8s.io/metrics/pkg/client/custom_metrics/fake:go_default_library",
],
...
...
pkg/controller/podautoscaler/metrics/rest_metrics_client.go
View file @
86f24eaf
...
...
@@ -28,7 +28,7 @@ import (
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime/schema"
customapi
"k8s.io/metrics/pkg/apis/custom_metrics/v1beta1"
resourceclient
"k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
alph
a1"
resourceclient
"k8s.io/metrics/pkg/client/clientset_generated/clientset/typed/metrics/v1
bet
a1"
customclient
"k8s.io/metrics/pkg/client/custom_metrics"
)
...
...
pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go
View file @
86f24eaf
...
...
@@ -37,7 +37,7 @@ import (
cmfake
"k8s.io/metrics/pkg/client/custom_metrics/fake"
cmapi
"k8s.io/metrics/pkg/apis/custom_metrics/v1beta1"
metricsapi
"k8s.io/metrics/pkg/apis/metrics/v1
alph
a1"
metricsapi
"k8s.io/metrics/pkg/apis/metrics/v1
bet
a1"
"github.com/stretchr/testify/assert"
)
...
...
@@ -185,7 +185,7 @@ func (tc *restClientTestCase) verifyResults(t *testing.T, metrics PodMetricsInfo
func
(
tc
*
restClientTestCase
)
runTest
(
t
*
testing
.
T
)
{
testMetricsClient
,
testCMClient
:=
tc
.
prepareTestClient
(
t
)
metricsClient
:=
NewRESTMetricsClient
(
testMetricsClient
.
MetricsV1
alph
a1
(),
testCMClient
)
metricsClient
:=
NewRESTMetricsClient
(
testMetricsClient
.
MetricsV1
bet
a1
(),
testCMClient
)
isResource
:=
len
(
tc
.
resourceName
)
>
0
if
isResource
{
info
,
timestamp
,
err
:=
metricsClient
.
GetResourceMetric
(
kv1
.
ResourceName
(
tc
.
resourceName
),
tc
.
namespace
,
tc
.
selector
)
...
...
pkg/controller/podautoscaler/replica_calculator_test.go
View file @
86f24eaf
...
...
@@ -36,7 +36,7 @@ import (
cmfake
"k8s.io/metrics/pkg/client/custom_metrics/fake"
cmapi
"k8s.io/metrics/pkg/apis/custom_metrics/v1beta1"
metricsapi
"k8s.io/metrics/pkg/apis/metrics/v1
alph
a1"
metricsapi
"k8s.io/metrics/pkg/apis/metrics/v1
bet
a1"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
...
...
@@ -243,7 +243,7 @@ func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset,
func
(
tc
*
replicaCalcTestCase
)
runTest
(
t
*
testing
.
T
)
{
testClient
,
testMetricsClient
,
testCMClient
:=
tc
.
prepareTestClient
(
t
)
metricsClient
:=
metrics
.
NewRESTMetricsClient
(
testMetricsClient
.
MetricsV1
alph
a1
(),
testCMClient
)
metricsClient
:=
metrics
.
NewRESTMetricsClient
(
testMetricsClient
.
MetricsV1
bet
a1
(),
testCMClient
)
replicaCalc
:=
&
ReplicaCalculator
{
metricsClient
:
metricsClient
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment