Merge pull request #53919 from apelisse/fix-new-apply-crash

Automatic merge from submit-queue (batch tested with PRs 53694, 53919). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not crash when groupVersion doesn't have a group **What this PR does / why we need it**: fixes a crash when the group is empty, because it assumes that split will return a two element array. Which it doesn't. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/kubectl#78 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #53919 from apelisse/fix-new-apply-crash
88975e98 · Kubernetes Submit Queue · GitHub · 6118a4b9 · f6b66c70 · 88975e98
Commit 88975e98 authored Oct 16, 2017 by Kubernetes Submit Queue Committed by GitHub Oct 16, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 5 deletions

util.go pkg/kubectl/apply/parse/util.go +8 -5

No files found.
--- a/pkg/kubectl/apply/parse/util.go
+++ b/pkg/kubectl/apply/parse/util.go
@@ -18,11 +18,12 @@ package parse

 import (
 	"fmt"
+	"reflect"
+	"strings"
+
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/kubernetes/pkg/kubectl/apply"
 	"k8s.io/kubernetes/pkg/kubectl/cmd/util/openapi"
-	"reflect"
-	"strings"
 )

 // nilSafeLookup returns the value from the map if the map is non-nil
@@ -152,9 +153,11 @@ func getGroupVersionKind(config map[string]interface{}) (schema.GroupVersionKind
 		if !ok {
 			return gvk, fmt.Errorf("Expected string for apiVersion, found %T", gv)
 		}
-		groupversion := strings.Split(casted, "/")
-		gvk.Group = groupversion[0]
-		gvk.Version = groupversion[1]
+		s := strings.Split(casted, "/")
+		if len(s) != 1 {
+			gvk.Group = s[0]
+		}
+		gvk.Version = s[len(s)-1]
 	} else {
 		return gvk, fmt.Errorf("Missing apiVersion in Kind %v", config)
 	}