Clean up initializer-related comments, test data

cmd/kubeadm/app/phases/selfhosting/selfhosting_test.go

@@ -58,7 +58,7 @@ spec:
     - --requestheader-username-headers=X-Remote-User
     - --requestheader-extra-headers-prefix=X-Remote-Extra-
     - --requestheader-allowed-names=front-proxy-client
-    - --admission-control=Initializers,NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,ResourceQuota
+    - --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,ResourceQuota
     - --allow-privileged=true
     - --client-ca-file=/etc/kubernetes/pki/ca.crt
     - --tls-private-key-file=/etc/kubernetes/pki/apiserver.key
@@ -139,7 +139,7 @@ spec:
         - --requestheader-username-headers=X-Remote-User
         - --requestheader-extra-headers-prefix=X-Remote-Extra-
         - --requestheader-allowed-names=front-proxy-client
-        - --admission-control=Initializers,NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,ResourceQuota
+        - --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,ResourceQuota
         - --allow-privileged=true
         - --client-ca-file=/etc/kubernetes/pki/ca.crt
         - --tls-private-key-file=/etc/kubernetes/pki/apiserver.key

hack/.shellcheck_failures

@@ -200,7 +200,6 @@
 ./test/cmd/discovery.sh
 ./test/cmd/generic-resources.sh
 ./test/cmd/get.sh
-./test/cmd/initializers.sh
 ./test/cmd/legacy-script.sh
 ./test/cmd/node-management.sh
 ./test/cmd/old-print.sh

hack/testdata/initializer-clusterrolebinding.yaml

-apiVersion: rbac.authorization.k8s.io/v1beta1
-kind: ClusterRoleBinding
-metadata:
-  name: super-admin
-  initializers:
-    pending:
-    - name: podimage.initializer.com
-  labels:
-    clusterrolebinding: super
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: ClusterRole
-  name: admin
-subjects:
-- apiGroup: rbac.authorization.k8s.io
-  kind: User
-  name: super-admin

hack/testdata/initializer-deployments.yaml

-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  name: web
-  initializers:
-    pending:
-    - name: podimage.initializer.com
-  labels:
-    run: web
-spec:
-  replicas: 5
-  selector:
-    matchLabels:
-      run: web
-  template:
-    metadata:
-      labels:
-        run: web
-    spec:
-      containers:
-      - image: nginx:1.10
-        name: web
-        ports:
-        - containerPort: 80
-          protocol: TCP

hack/testdata/initializer-redis-master-service.yaml

-apiVersion: v1
-kind: Service
-metadata:
-  name: redis-master
-  labels:
-    app: redis
-    role: master
-    tier: backend
-  initializers:
-    pending:
-    - name: podimage.initializer.com
-spec:
-  ports:
-  - port: 6379
-    targetPort: 6379
-  selector:
-    app: redis
-    role: master
-    tier: backend

pkg/kubeapiserver/options/admission_test.go

@@ -25,7 +25,7 @@ func TestValidate(t *testing.T) {
 	// 1. Both `--admission-control` and `--enable-admission-plugins` are specified
 	options := NewAdmissionOptions()
 	options.PluginNames = []string{"ServiceAccount"}
-	options.GenericAdmission.EnablePlugins = []string{"Initializers"}
+	options.GenericAdmission.EnablePlugins = []string{"NodeRestriction"}
 	if len(options.Validate()) == 0 {
 		t.Errorf("Expect error, but got none")
 	}
@@ -33,7 +33,7 @@ func TestValidate(t *testing.T) {
 	// 2. Both `--admission-control` and `--disable-admission-plugins` are specified
 	options = NewAdmissionOptions()
 	options.PluginNames = []string{"ServiceAccount"}
-	options.GenericAdmission.DisablePlugins = []string{"Initializers"}
+	options.GenericAdmission.DisablePlugins = []string{"NodeRestriction"}
 	if len(options.Validate()) == 0 {
 		t.Errorf("Expect error, but got none")
 	}

pkg/kubectl/scale.go

@@ -29,8 +29,6 @@ import (
 	scaleclient "k8s.io/client-go/scale"
 )
 
-// TODO: Figure out if we should be waiting on initializers in the Scale() functions below.
-
 // Scaler provides an interface for resources that can be scaled.
 type Scaler interface {
 	// Scale scales the named resource after checking preconditions. It optionally

staging/src/k8s.io/sample-apiserver/pkg/registry/wardle/fischer/strategy.go

@@ -36,8 +36,7 @@ func NewStrategy(typer runtime.ObjectTyper) fischerStrategy {
 	return fischerStrategy{typer, names.SimpleNameGenerator}
 }
 
-// GetAttrs returns labels.Set, fields.Set, the presence of Initializers if any
-// and error in case the given runtime.Object is not a Fischer
+// GetAttrs returns labels.Set, fields.Set, and error in case the given runtime.Object is not a Fischer
 func GetAttrs(obj runtime.Object) (labels.Set, fields.Set, error) {
 	apiserver, ok := obj.(*wardle.Fischer)
 	if !ok {

staging/src/k8s.io/sample-apiserver/pkg/registry/wardle/flunder/strategy.go

@@ -37,8 +37,7 @@ func NewStrategy(typer runtime.ObjectTyper) flunderStrategy {
 	return flunderStrategy{typer, names.SimpleNameGenerator}
 }
 
-// GetAttrs returns labels.Set, fields.Set, the presence of Initializers if any
-// and error in case the given runtime.Object is not a Flunder
+// GetAttrs returns labels.Set, fields.Set, and error in case the given runtime.Object is not a Flunder
 func GetAttrs(obj runtime.Object) (labels.Set, fields.Set, error) {
 	apiserver, ok := obj.(*wardle.Flunder)
 	if !ok {

test/cmd/legacy-script.sh

@@ -39,7 +39,6 @@ source "${KUBE_ROOT}/test/cmd/diff.sh"
 source "${KUBE_ROOT}/test/cmd/discovery.sh"
 source "${KUBE_ROOT}/test/cmd/generic-resources.sh"
 source "${KUBE_ROOT}/test/cmd/get.sh"
-source "${KUBE_ROOT}/test/cmd/initializers.sh"
 source "${KUBE_ROOT}/test/cmd/kubeconfig.sh"
 source "${KUBE_ROOT}/test/cmd/node-management.sh"
 source "${KUBE_ROOT}/test/cmd/old-print.sh"