Merge pull request #37296 from ncdc/skip-dash-in-protobuf-tags

Automatic merge from submit-queue Fix skipping - protobuf fields **What this PR does / why we need it**: fixes the protobuf generator to skip fields with a protobuf tag of `"-"` Match changes in https://github.com/kubernetes/gengo/pull/19 I couldn't get godeps to work to vendor this change in from gengo, so I made the same edits manually in cmd/libs/go2idl. A task for another day... @smarterclayton

Merge pull request #37296 from ncdc/skip-dash-in-protobuf-tags
9541c38f · Kubernetes Submit Queue · GitHub · f1aa0258 · f0247ea5 · 9541c38f
Commit 9541c38f authored Dec 22, 2016 by Kubernetes Submit Queue Committed by GitHub Dec 22, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

generator.go cmd/libs/go2idl/go-to-protobuf/protobuf/generator.go +6 -1

No files found.
--- a/cmd/libs/go2idl/go-to-protobuf/protobuf/generator.go
+++ b/cmd/libs/go2idl/go-to-protobuf/protobuf/generator.go
@@ -630,7 +630,12 @@ func membersToFields(locator ProtobufLocator, t *types.Type, localPackage types.
 			Extras: make(map[string]string),
 		}
-		if err := protobufTagToField(tags.Get("protobuf"), &field, m, t, localPackage); err != nil {
+		protobufTag := tags.Get("protobuf")
+		if protobufTag == "-" {
+			continue
+		}
+		if err := protobufTagToField(protobufTag, &field, m, t, localPackage); err != nil {
 			return nil, err
 		}