Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
97e5c0a3
Commit
97e5c0a3
authored
Feb 11, 2018
by
wackxu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
remove default priority cache in Priority admission controller
parent
f351d8cd
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
22 deletions
+2
-22
admission.go
plugin/pkg/admission/priority/admission.go
+2
-22
No files found.
plugin/pkg/admission/priority/admission.go
View file @
97e5c0a3
...
...
@@ -52,8 +52,6 @@ type priorityPlugin struct {
*
admission
.
Handler
client
internalclientset
.
Interface
lister
schedulinglisters
.
PriorityClassLister
// globalDefaultPriority caches the value of global default priority class.
globalDefaultPriority
*
int32
}
var
_
admission
.
MutationInterface
=
&
priorityPlugin
{}
...
...
@@ -130,10 +128,6 @@ func (p *priorityPlugin) Validate(a admission.Attributes) error {
if
operation
==
admission
.
Create
||
operation
==
admission
.
Update
{
return
p
.
validatePriorityClass
(
a
)
}
if
operation
==
admission
.
Delete
{
p
.
invalidateCachedDefaultPriority
()
return
nil
}
return
nil
default
:
...
...
@@ -217,8 +211,6 @@ func (p *priorityPlugin) validatePriorityClass(a admission.Attributes) error {
}
}
}
// We conservatively invalidate our cache of global default priority upon any changes to any of the existing classes or creation of a new class.
p
.
invalidateCachedDefaultPriority
()
return
nil
}
...
...
@@ -241,24 +233,12 @@ func (p *priorityPlugin) getDefaultPriorityClass() (*scheduling.PriorityClass, e
}
func
(
p
*
priorityPlugin
)
getDefaultPriority
()
(
int32
,
error
)
{
// If global default priority is cached, return it.
if
p
.
globalDefaultPriority
!=
nil
{
return
*
p
.
globalDefaultPriority
,
nil
}
dpc
,
err
:=
p
.
getDefaultPriorityClass
()
if
err
!=
nil
{
return
0
,
err
}
priority
:=
int32
(
scheduling
.
DefaultPriorityWhenNoDefaultClassExists
)
if
dpc
!=
nil
{
priority
=
dpc
.
Value
return
dpc
.
Value
,
nil
}
// Cache the value.
p
.
globalDefaultPriority
=
&
priority
return
priority
,
nil
}
// invalidateCachedDefaultPriority sets global default priority to nil to indicate that it should be looked up again.
func
(
p
*
priorityPlugin
)
invalidateCachedDefaultPriority
()
{
p
.
globalDefaultPriority
=
nil
return
int32
(
scheduling
.
DefaultPriorityWhenNoDefaultClassExists
),
nil
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment