Skip to content

K
k3s
Commit a1265e08 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #37538 from resouer/fix-e2e-respect-id

Automatic merge from submit-queue CreateNodeSelectorPods should respect parameter Fix (1): `CreateNodeSelectorPods` should respect parameter `id`. The existing e2e does not break because it happened use "node-selector" as id, which is the same as the hard coded value. Fix (2): The current `CreateNodeSelectorPods` does not use `nodeSelector` parameter, it hard coded a label instead. The reason current e2e does not influenced because we happened use the same label: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/cluster_size_autoscaling.go#L177 Found these bugs during testing #36238
parents 6fd22784 3777777e
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
test/e2e/cluster_size_autoscaling.go
View file @ a1265e08
......@@ -495,13 +495,13 @@ func CreateNodeSelectorPods(f *framework.Framework, id string, replicas int, nod
config := &testutils.RCConfig{
Client: f.ClientSet,
InternalClient: f.InternalClientset,
Name: "node-selector",
Name: id,
Namespace: f.Namespace.Name,
Timeout: defaultTimeout,
Image: framework.GetPauseImageName(f.ClientSet),
Replicas: replicas,
HostPorts: map[string]int{"port1": 4321},
NodeSelector: map[string]string{"cluster-autoscaling-test.special-node": "true"},
NodeSelector: nodeSelector,
}
err := framework.RunRC(*config)
if expectRunning {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment