Skip to content

K
k3s
Commit a5761d80 authored by Andy Goldstein's avatar Andy Goldstein
Browse files
Options

Use groupName comment for listers/informers

If present, use the "// +groupName" doc comment as the desired group name when generating listers and informers.
parent 6ae80a62
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 0 deletions
cmd/libs/go2idl/informer-gen/generators/packages.go
View file @ a5761d80
...@@ -150,6 +150,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat ...@@ -150,6 +150,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
targetGroupVersions = externalGroupVersions targetGroupVersions = externalGroupVersions
} }
// If there's a comment of the form "// +groupName=somegroup" or
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
// group when generating.
if override := types.ExtractCommentTags("+", p.DocComments)["groupName"]; override != nil {
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
}
var typesToGenerate []*types.Type var typesToGenerate []*types.Type
for _, t := range p.Types { for _, t := range p.Types {
// filter out types which dont have genclient=true. // filter out types which dont have genclient=true.
......
cmd/libs/go2idl/lister-gen/generators/lister.go
View file @ a5761d80
...@@ -106,6 +106,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat ...@@ -106,6 +106,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
internalGVPkg = strings.Join(parts[0:len(parts)-1], "/") internalGVPkg = strings.Join(parts[0:len(parts)-1], "/")
} }
// If there's a comment of the form "// +groupName=somegroup" or
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
// group when generating.
if override := types.ExtractCommentTags("+", p.DocComments)["groupName"]; override != nil {
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
}
var typesToGenerate []*types.Type var typesToGenerate []*types.Type
for _, t := range p.Types { for _, t := range p.Types {
// filter out types which dont have genclient=true. // filter out types which dont have genclient=true.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment