Merge pull request #60069 from wojtek-t/fix_components_statuses_crash

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix race in healthchecking etcds leading to crashes Fix https://github.com/kubernetes/kubernetes/issues/59338

Merge pull request #60069 from wojtek-t/fix_components_statuses_crash
aa02c0f5 · Kubernetes Submit Queue · GitHub · aec91e11 · 38387aec · aa02c0f5
Unverified Commit aa02c0f5 authored Feb 20, 2018 by Kubernetes Submit Queue Committed by GitHub Feb 20, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

storage_factory.go ...rc/k8s.io/apiserver/pkg/server/storage/storage_factory.go +4 -2

No files found.
--- a/staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go
+++ b/staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go
@@ -321,8 +321,10 @@ func (s *DefaultStorageFactory) Backends() []Backend {
 	backends := []Backend{}
 	for server := range servers {
 		backends = append(backends, Backend{
-			Server:    server,
-			TLSConfig: tlsConfig,
+			Server: server,
+			// We can't share TLSConfig across different backends to avoid races.
+			// For more details see: http://pr.k8s.io/59338
+			TLSConfig: tlsConfig.Clone(),
 		})
 	}
 	return backends