Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
ab16ccc1
Commit
ab16ccc1
authored
Jun 24, 2016
by
Tim Hockin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
go2idl: don't mutate a map being iterated
This was causing us to process packages we didn't really want, which was only visible when debugging was enabled.
parent
96c0284e
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
0 deletions
+6
-0
parse.go
cmd/libs/go2idl/parser/parse.go
+6
-0
No files found.
cmd/libs/go2idl/parser/parse.go
View file @
ab16ccc1
...
...
@@ -337,7 +337,13 @@ func (b *Builder) typeCheckPackage(id string) (*tc.Package, error) {
func
(
b
*
Builder
)
makePackages
()
error
{
b
.
pkgs
=
map
[
string
]
*
tc
.
Package
{}
// Take a snapshot to iterate, since this will recursively mutate b.parsed.
keys
:=
[]
string
{}
for
id
:=
range
b
.
parsed
{
keys
=
append
(
keys
,
id
)
}
for
_
,
id
:=
range
keys
{
// We have to check here even though we made a new one above,
// because typeCheckPackage follows the import graph, which may
// cause a package to be filled before we get to it in this
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment