Unverified Commit ae68c6f0 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #64463 from nicksardo/automated-cherry-pick-of-#64349-upstream-release-1.10

Automatic merge from submit-queue. Automated cherry pick of #64349: Fix nodeport repair for ESIPP services Cherry pick of #64349 on release-1.10. #64349: Fix nodeport repair for ESIPP services
parents 4d9a60b0 4c3a6dda
......@@ -204,5 +204,10 @@ func collectServiceNodePorts(service *api.Service) []int {
servicePorts = append(servicePorts, int(servicePort.NodePort))
}
}
if service.Spec.HealthCheckNodePort != 0 {
servicePorts = append(servicePorts, int(service.Spec.HealthCheckNodePort))
}
return servicePorts
}
......@@ -164,6 +164,12 @@ func TestRepairWithExisting(t *testing.T) {
Ports: []api.ServicePort{{NodePort: 111}},
},
},
&api.Service{
ObjectMeta: metav1.ObjectMeta{Namespace: "six", Name: "six"},
Spec: api.ServiceSpec{
HealthCheckNodePort: 144,
},
},
)
registry := &mockRangeRegistry{
......@@ -183,10 +189,10 @@ func TestRepairWithExisting(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if !after.Has(111) || !after.Has(122) || !after.Has(133) {
if !after.Has(111) || !after.Has(122) || !after.Has(133) || !after.Has(144) {
t.Errorf("unexpected portallocator state: %#v", after)
}
if free := after.Free(); free != 98 {
if free := after.Free(); free != 97 {
t.Errorf("unexpected portallocator state: %d free", free)
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment