Skip to content

K
k3s
Commit b3c2c9eb authored by k8s-merge-robot's avatar k8s-merge-robot Committed by GitHub
Browse files
Options

Merge pull request #27381 from dims/fix-issue-2967

Automatic merge from submit-queue Fix problem specifying fqdn:port in command line When specifying --server in kubectl for example, we end up with failure if you use "localhost:8080" instead of "127.0.0.1:8080". This is because of the way url.Parse works as shown in snippet: https://play.golang.org/p/luD57S6sEz Essentially localhost ends up as the Scheme and NOT as the Host. So we add another check to make sure we prepend the scheme when Host ends up being empty as well. Tested with "kubectl --server localhost:8080 get po" Fixes #2967
parents 715d2f23 0d86251f
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 1 deletion
pkg/client/restclient/url_utils.go
View file @ b3c2c9eb
......@@ -36,7 +36,7 @@ func DefaultServerURL(host, apiPath string, groupVersion unversioned.GroupVersio
if err != nil {
return nil, "", err
}
if hostURL.Scheme == "" {
if hostURL.Scheme == "" || hostURL.Host == "" {
scheme := "http://"
if defaultTLS {
scheme = "https://"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment