Unverified Commit b5d21a92 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #64339 from liztio/pronouns

Automatic merge from submit-queue (batch tested with PRs 61803, 64305, 64170, 64361, 64339). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove some unnecessarily gendered pronouns in comments **What this PR does / why we need it**: A bunch of comments are unnecessarily gendered. I've changed them to gender-neutral they/theirs. **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
parents 2b1bfc3a ffeca161
...@@ -156,7 +156,7 @@ func (r *Reset) Run(out io.Writer) error { ...@@ -156,7 +156,7 @@ func (r *Reset) Run(out io.Writer) error {
dirsToClean := []string{"/var/lib/kubelet", "/etc/cni/net.d", "/var/lib/dockershim", "/var/run/kubernetes"} dirsToClean := []string{"/var/lib/kubelet", "/etc/cni/net.d", "/var/lib/dockershim", "/var/run/kubernetes"}
// Only clear etcd data when the etcd manifest is found. In case it is not found, we must assume that the user // Only clear etcd data when the etcd manifest is found. In case it is not found, we must assume that the user
// provided external etcd endpoints. In that case, it is his own responsibility to reset etcd // provided external etcd endpoints. In that case, it is their own responsibility to reset etcd
etcdManifestPath := filepath.Join(kubeadmconstants.KubernetesDir, kubeadmconstants.ManifestsSubDirName, "etcd.yaml") etcdManifestPath := filepath.Join(kubeadmconstants.KubernetesDir, kubeadmconstants.ManifestsSubDirName, "etcd.yaml")
glog.V(1).Infof("[reset] checking for etcd manifest") glog.V(1).Infof("[reset] checking for etcd manifest")
if _, err := os.Stat(etcdManifestPath); err == nil { if _, err := os.Stat(etcdManifestPath); err == nil {
......
...@@ -56,7 +56,7 @@ func init() { ...@@ -56,7 +56,7 @@ func init() {
// For example: // For example:
// https://github.com/kubernetes/kubernetes/blob/36a218e/plugin/pkg/scheduler/factory/factory.go#L422 // https://github.com/kubernetes/kubernetes/blob/36a218e/plugin/pkg/scheduler/factory/factory.go#L422
// Registers predicates and priorities that are not enabled by default, but user can pick when creating his // Registers predicates and priorities that are not enabled by default, but user can pick when creating their
// own set of priorities/predicates. // own set of priorities/predicates.
// PodFitsPorts has been replaced by PodFitsHostPorts for better user understanding. // PodFitsPorts has been replaced by PodFitsHostPorts for better user understanding.
......
...@@ -135,7 +135,7 @@ func (f *FakeExtender) ProcessPreemption( ...@@ -135,7 +135,7 @@ func (f *FakeExtender) ProcessPreemption(
nodeToVictimsCopy := map[*v1.Node]*schedulerapi.Victims{} nodeToVictimsCopy := map[*v1.Node]*schedulerapi.Victims{}
// We don't want to change the original nodeToVictims // We don't want to change the original nodeToVictims
for k, v := range nodeToVictims { for k, v := range nodeToVictims {
// In real world implementation, extender's user should have his own way to get node object // In real world implementation, extender's user should have their own way to get node object
// by name if needed (e.g. query kube-apiserver etc). // by name if needed (e.g. query kube-apiserver etc).
// //
// For test purpose, we just use node from parameters directly. // For test purpose, we just use node from parameters directly.
......
...@@ -167,7 +167,7 @@ func WithMaxInFlightLimit( ...@@ -167,7 +167,7 @@ func WithMaxInFlightLimit(
metrics.DroppedRequests.WithLabelValues(metrics.ReadOnlyKind).Inc() metrics.DroppedRequests.WithLabelValues(metrics.ReadOnlyKind).Inc()
} }
// at this point we're about to return a 429, BUT not all actors should be rate limited. A system:master is so powerful // at this point we're about to return a 429, BUT not all actors should be rate limited. A system:master is so powerful
// that he should always get an answer. It's a super-admin or a loopback connection. // that they should always get an answer. It's a super-admin or a loopback connection.
if currUser, ok := apirequest.UserFrom(ctx); ok { if currUser, ok := apirequest.UserFrom(ctx); ok {
for _, group := range currUser.GetGroups() { for _, group := range currUser.GetGroups() {
if group == user.SystemPrivilegedGroup { if group == user.SystemPrivilegedGroup {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment