Merge pull request #53685 from joonas/hack/cleanup-dangling-functions
Automatic merge from submit-queue (batch tested with PRs 53965, 54117, 53685). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
Remove dangling shell functions
**What this PR does / why we need it**:
This is clean up for shell functionality that was left over from when something was first added and subsequently removed, but didn't include cleaning up all of the logic they references.
**Special notes for your reviewer**:
I traced back the functions to when they were added and had their references removed, so I thought I'd share that for context:
* `kube::golang::current_platform` was added in 5d33ce46, but never ended up being used. My understanding is that this is due to having more or less the same logic available in `kube::golang::host_platform`, which is what's being used.
* `kube::util::gen-analytics` was added in 553f9f82 and had the use of it removed in 902ffd53 when docs
* `kube::util::analytics-link` was added in 553f9f82 and had the use of it removed in ffcc6cad
* `kube::util::get_random_port` was added in 5d08dcf8 and superseded by `kubectl proxy --port=0` in 22b43d8f
* `kube::util::test_host_port_free` was added in 5d08dcf8 and superseded by `kubectl proxy --port=0` in 22b43d8f
I should also note that [`kube::golang::unset_platform_envs()`](https://github.com/kubernetes/kubernetes/blob/e8e72a44444d9ded58bcba13d650c98dab2cb465/hack/lib/golang.sh#L301-L307) was introduced in 5d33ce46 and is currently unused, but was referenced in 9848d6cc and subsequently removed in 38690ff7. If that's something worth including here, I'd be happy to add that also.
**Release note**:
```release-note
NONE
```
Showing
Please
register
or
sign in
to comment