Merge pull request #37688 from nvartolomei/reflector-handle-store-errors

Automatic merge from submit-queue Add error handling for store operations in cache/reflector In my opinion the errors there should be returned, but to have minimal impact I just added runtime error handler. Let me know what you think.

Merge pull request #37688 from nvartolomei/reflector-handle-store-errors
ce0d2ac8 · Kubernetes Submit Queue · GitHub · 81d788dd · c6733f1c · ce0d2ac8
Commit ce0d2ac8 authored Dec 04, 2016 by Kubernetes Submit Queue Committed by GitHub Dec 04, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 3 deletions

reflector.go pkg/client/cache/reflector.go +12 -3

No files found.
--- a/pkg/client/cache/reflector.go
+++ b/pkg/client/cache/reflector.go
@@ -363,14 +363,23 @@ loop:
 			newResourceVersion := meta.GetResourceVersion()
 			switch event.Type {
 			case watch.Added:
-				r.store.Add(event.Object)
+				err := r.store.Add(event.Object)
+				if err != nil {
+					utilruntime.HandleError(fmt.Errorf("%s: unable to add watch event object (%#v) to store: %v", r.name, event.Object, err))
+				}
 			case watch.Modified:
-				r.store.Update(event.Object)
+				err := r.store.Update(event.Object)
+				if err != nil {
+					utilruntime.HandleError(fmt.Errorf("%s: unable to update watch event object (%#v) to store: %v", r.name, event.Object, err))
+				}
 			case watch.Deleted:
 				// TODO: Will any consumers need access to the "last known
 				// state", which is passed in event.Object? If so, may need
 				// to change this.
-				r.store.Delete(event.Object)
+				err := r.store.Delete(event.Object)
+				if err != nil {
+					utilruntime.HandleError(fmt.Errorf("%s: unable to delete watch event object (%#v) from store: %v", r.name, event.Object, err))
+				}
 			default:
 				utilruntime.HandleError(fmt.Errorf("%s: unable to understand watch event %#v", r.name, event))
 			}