Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
e157febf
Commit
e157febf
authored
May 17, 2016
by
Paul Morie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add notes about endgame for test flakes
parent
a24f03c3
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
2 deletions
+11
-2
flaky-tests.md
docs/devel/flaky-tests.md
+11
-2
No files found.
docs/devel/flaky-tests.md
View file @
e157febf
...
@@ -88,11 +88,20 @@ we have the following guidelines:
...
@@ -88,11 +88,20 @@ we have the following guidelines:
3.
If you can reproduce it (or it's obvious from the logs what happened), you
3.
If you can reproduce it (or it's obvious from the logs what happened), you
should then be able to fix it, or in the case where someone is clearly more
should then be able to fix it, or in the case where someone is clearly more
qualified to fix it, reassign it with very clear instructions.
qualified to fix it, reassign it with very clear instructions.
4.
If you can't reproduce it: __don't just close it!__ Every time a flake comes
4.
PRs that fix or help debug flakes may have the P0 priority set to get them
through the merge queue as fast as possible.
5.
Once you have made a change that you believe fixes a flake, it is conservative
to keep the issue for the flake open and see if it manifests again after the
change is merged.
6.
If you can't reproduce a flake: __don't just close it!__ Every time a flake comes
back, at least 2 hours of merge time is wasted. So we need to make monotonic
back, at least 2 hours of merge time is wasted. So we need to make monotonic
progress towards narrowing it down every time a flake occurs. If you can't
progress towards narrowing it down every time a flake occurs. If you can't
figure it out from the logs, add log messages that would have help you figure
figure it out from the logs, add log messages that would have help you figure
it out.
it out. If you make changes to make a flake more reproducible, please link
your pull request to the flake you're working on.
7.
If a flake has been open, could not be reproduced, and has not manifested in
3 months, it is reasonable to close the flake issue with a note saying
why.
# Reproducing unit test flakes
# Reproducing unit test flakes
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment