Commit ead3cc8c authored by Dawn Chen's avatar Dawn Chen Committed by GitHub

Merge pull request #37293 from wojtek-t/fix_scheduler_bug

Fix a bug in scheduler happening after retrying unsuccessful bindings
parents de03fadc e4d215d5
...@@ -114,6 +114,13 @@ func (s *Scheduler) scheduleOne() { ...@@ -114,6 +114,13 @@ func (s *Scheduler) scheduleOne() {
assumed.Spec.NodeName = dest assumed.Spec.NodeName = dest
if err := s.config.SchedulerCache.AssumePod(&assumed); err != nil { if err := s.config.SchedulerCache.AssumePod(&assumed); err != nil {
glog.Errorf("scheduler cache AssumePod failed: %v", err) glog.Errorf("scheduler cache AssumePod failed: %v", err)
// TODO: This means that a given pod is already in cache (which means it
// is either assumed or already added). This is most probably result of a
// BUG in retrying logic. As a temporary workaround (which doesn't fully
// fix the problem, but should reduce its impact), we simply return here,
// as binding doesn't make sense anyway.
// This should be fixed properly though.
return
} }
go func() { go func() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment