Commit f56aa587 authored by nikhiljindal's avatar nikhiljindal

Some improvements to #5687

parent aa417ca2
...@@ -194,11 +194,6 @@ runTests() { ...@@ -194,11 +194,6 @@ runTests() {
kube::log::status "Combined coverage report: ${coverage_html_file}" kube::log::status "Combined coverage report: ${coverage_html_file}"
} }
runTestsForVersion() {
export KUBE_API_VERSION="$1"
runTests "${@:2}"
}
reportCoverageToCoveralls() { reportCoverageToCoveralls() {
if [[ -x "${KUBE_GOVERALLS_BIN}" ]]; then if [[ -x "${KUBE_GOVERALLS_BIN}" ]]; then
${KUBE_GOVERALLS_BIN} -coverprofile="${COMBINED_COVER_PROFILE}" || true ${KUBE_GOVERALLS_BIN} -coverprofile="${COMBINED_COVER_PROFILE}" || true
...@@ -209,7 +204,7 @@ reportCoverageToCoveralls() { ...@@ -209,7 +204,7 @@ reportCoverageToCoveralls() {
IFS=',' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}" IFS=',' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}"
for apiVersion in "${apiVersions[@]}"; do for apiVersion in "${apiVersions[@]}"; do
echo "Running tests for APIVersion: $apiVersion" echo "Running tests for APIVersion: $apiVersion"
runTestsForVersion $apiVersion "${@}" KUBE_API_VERSION="${apiVersion}" runTests "$@"
done done
# We might run the tests for multiple versions, but we want to report only # We might run the tests for multiple versions, but we want to report only
......
...@@ -55,7 +55,7 @@ runTests() { ...@@ -55,7 +55,7 @@ runTests() {
trap cleanup EXIT trap cleanup EXIT
# Convert the CSV to an array of API versions to test # Convert the CSV to an array of API versions to test
IFS=',' read -a apiVersions <<< ${KUBE_TEST_API_VERSIONS} IFS=',' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}"
for apiVersion in "${apiVersions[@]}"; do for apiVersion in "${apiVersions[@]}"; do
runTests $apiVersion runTests "${apiVersion}"
done done
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment