- 18 Aug, 2017 40 commits
-
-
Michael Taufen authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update OWNERS files for networking components This will reduce the approval load for the top level tree owners ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use CollisionCount for collision avoidance in StatefulSet controller **What this PR does / why we need it**: This PR uses the newly added `CollisionCount` in `StatefulSetStatus` for name collision avoidance when the `StatefulSet` controller creates `ControllerRevision`s. The `CreateControllerRevision` method of the `ControllerHistory` interface was augmented to use a user-specified `collisionCount` instead of the internal probe that always starts with 0. The `StatefulSet` controller uses the `CreateControllerRevision` to create `ControllerRevision`s and when it calls it, it passes in the `CollisionCount` of the `StatefulSet` it manipulates. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49909. **Special notes for your reviewer**: /assign @kow3ns **Release note**: ```release-note Use CollisionCount for collision avoidance when creating ControllerRevisions in StatefulSet controller ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Proposal to add @wlan0 to appropriate owner files @thockin @luxas
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50911, 50839) Fix admission plugin registration **What this PR does / why we need it**: The current registration of admission plug-ins happen too late so the command line help is not yielding correct/useful information to users. This is already causing confusion as mentioned in some issues. This patch fixes it by moving plugins.go down to options package because "plugins" in this context are themselves options for users. Registration of plugins is not an expensive operation and it is already done in most execution paths. **Which issue this PR fixes** fixes #50833 **Special notes for your reviewer**: There might be other thoughts on how to better align this with other efforts. This PR is leaving them to future work. For example: in future, we may want to revisit these plugins and migrate them to the shared apiserver repo when appropriate. **Release note**: I'm not sure if a release note is needed for this. Maybe there is a need. ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add diff details to pod validation error This adds a basic (large) diff to the `ValidatePodUpdate` method, but we've been waiting on the "perfect" diff for a long time and it hasn't appeared.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50904, 50691) Make Kubeadm phase certs codebase consistent with other phases **What this PR does / why we need it:** This PR is a refactoring of [#48196](https://github.com/kubernetes/kubernetes/pull/48196), that makes this part of kubeadm more consistent with other parts of kubeadm recently changed, e.g. [controlplane & etcd phase #50302](https://github.com/kubernetes/kubernetes/pull/50302) and [kubeconfig phase #49419](https://github.com/kubernetes/kubernetes/pull/49419) **Which issue this PR fixes:** none **Special notes for your reviewer:** cc @luxas
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50904, 50691) Stackdriver Logging e2e: Explicitly check for docker and kubelet logs presence Check for kubelet and docker logs explicitly in the Stackdriver Logging e2e tests
-
Yinan Li authored
-
David Eads authored
-
Mik Vyatskov authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add enj as reviewer to OWNERS Adding myself as a reviewer for the following areas: - API - auth - registry - storage (etcd) Signed-off-by:Monis Khan <mkhan@redhat.com> **Release note**: ```release-note NONE ``` @kubernetes/sig-api-machinery-pr-reviews @kubernetes/sig-auth-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue remove useless argument "name" **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50255, 50885) remove dead code for cloner I found some dead code in audit webhook backend. This change do some clean work for: https://github.com/kubernetes/kubernetes/pull/48544/commits/2bbe72d4e09f7c95e1ad851187d4733a54644fbe **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50255, 50885) AWS: Arbitrarily choose first (lexicographically) subnet in AZ When there is more than one subnet for an AZ on AWS choose arbitrarily chose the first one lexicographically for consistency. **What this PR does / why we need it**: If two subnets were to be used appear in the same aws az which one is chosen is currently not consistent. This could lead to difficulty in diagnosing issues. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45983 **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50303, 50856) Make route-controller list only relevant routes instead of all of them Ref https://github.com/kubernetes/kubernetes/issues/50854 (somewhat related issue) IIUC from the code, route-controller memory is mainly being used in storing routes and nodes (also CIDRs, but that's not much). This should help reduce that memory usage (particularly when running in a project with large no. of routes), by moving filtering to server-side. For e.g in kubernetes-scale project we have ~5000 routes (each about 600B) => 3 MB of routes This doesn't help with reducing time to list the routes as filtering is also linear. cc @kubernetes/sig-scalability-misc @wojtek-t @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue delete ineffectual assginment **What this PR does / why we need it**: delete ineffectual assignment **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**:
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add enj to OWNERS for test/integration/etcd/etcd_storage_path_test.go @deads2k is the bot smart enough to not spam me with every test change? Perhaps I should create an `OWNERS` file in `test/integration/etcd`? **Release note**: ```release-note NONE ``` @kubernetes/sig-api-machinery-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Rename k8s.io/{kube-gen -> code-generator} -
fabriziopandini authored
-
fabriziopandini authored
-
fabriziopandini authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix typo **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue CollisionCount should have type int32 across controllers that use it for collision avoidance **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50530 **Special notes for your reviewer**: /cc @liyinan926 /assign @kow3ns @thockin @janetkuo **Release note**: ```release-note Change CollisionCount from int64 to int32 across controllers ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue verify pkg/util contains no code **What this PR does / why we need it**: verify util packages contain no go codes related issue: #49923
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50277, 50823, 50376, 50867) NR Infrastructure agent example daemonset Copy of previous newrelic example, then modified to use the new agent "newrelic-infra" instead of "nrsysmond". Also maps all of host node's root fs into /host in the container (ro, but still exposes underlying node info into a container). Updates to README **What this PR does / why we need it**: It provides an example basic configuration to get New Relic Infrastructure monitoring agent installed as a daemonset in containers on a cluster. It started as a clone of examples/newrelic/, then updated to use the "infrastructure" docker image provided by New Relic. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50277, 50823, 50376, 50867) Move e2e taints test file to sig-scheduling **What this PR does / why we need it**: Move taint test file to e2e scheduling and add sig-scheduling prefix. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Ref Umbrella issue #49161 **Special notes for your reviewer**: **Release note**: none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50277, 50823, 50376, 50867) fix issue(#50821)Add image check, if image not changed, transform false **What this PR does / why we need it**: closes #50821 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add node e2e test for Docker's live-restore Ref: https://github.com/kubernetes/kubernetes/issues/42926 This PR adds a test for docker live-restore. If this is fine, we can close the unfinished PR https://github.com/kubernetes/kubernetes/pull/40364. **Release note**: ``` None ```
-
Cao Shufeng authored
I found some dead code in audit webhook backend. This change do some clean work for: https://github.com/kubernetes/kubernetes/pull/48544/commits/2bbe72d4e09f7c95e1ad851187d4733a54644fbe
-
Di Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix several typos in CHANGELOG.md file **What this PR does / why we need it**: Fixed several typos in CHANGELOG.md file. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix GPU resource validation that incorrectly allows zero limits **What this PR does / why we need it**: The validation logic for GPUs is not run if limits is not set for GPUs. We need to check limits equals requests even if just request is set for GPUs. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50182 **Special notes for your reviewer**: /assign @vishh /cc @jiayingz **Release note**: ```release-note fix GPU resource validation that incorrectly allows zero limits ```
-
Di Xu authored
-
tengqm authored
The current registration of admission plug-ins happen too late so the command line help is not yielding correct/useful information to users. This is already causing confusion as mentioned in some issues. This patch fixes it by moving plugins.go down to options package because "plugins" in this context are themselves options for users. Registration of plugins is not an expensive operation and it is already done in most execution paths. In future, we may want to revisit these plugins and migrate them to the shared apiserver repo when appropriate.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Change API version of statefulset scale subresource e2e test to v1beta2 **What this PR does / why we need it**: This PR changes API version of statefulset scale subresource e2e test from `v1beta1` to `v1beta2`. `apps/v1beta2` has been enabled. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #50109 **Release note**: ```release-note NONE ```
-
zhengjiajin authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50536, 50809, 50220, 50399, 50176) Set ExecSync timeout in liveness prober. Although Dockershim doesn't actually support `ExecSync` timeout (see [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/dockershim/exec.go#L137)), we should set the timeout, so that the other runtime which supports the timeout could work properly. Fixes #50389. /cc @yujuhong @timstclair @feiskyer
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50536, 50809, 50220, 50399, 50176) Make admission plugin handle mutating spec of uninitialized pods Address https://github.com/kubernetes/kubernetes/issues/47837#issuecomment-321323243. Updated to handle mutating pod spec of uninitialized pods: * InitialResources * PodNodeSelector * PodTolerationRestriction * ServiceAccount Doesn't change: * NodeRestriction: this plugin only cares about the mirror pods created by nodes, and mirror pods are exempted from initializers, so no modification required * PersistentVolumeLabel, DefaultStorageClass: It only cares about PersistentVolume. We can revisit when we relax its validation. * InitialResource: deprecated according to https://github.com/kubernetes/kubernetes/issues/47837#issuecomment-321388879
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50536, 50809, 50220, 50399, 50176) Refactor statefulset test with sets.String **What this PR does / why we need it**: Delete redundant sort. These string slices only own one element. There is no necessary to sort them. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-