- 10 Oct, 2017 32 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52354, 52949, 53551). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add client and server versions to the e2e.test output. Fixes #53502. ```release-note NONE ``` Sample output: ``` Oct 6 15:02:44.001: INFO: Client version: v1.9.0-alpha.1.737+3b1b19a1-dirty Oct 6 15:02:44.039: INFO: Server version: v1.8.0 ``` /assign @timothysc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52354, 52949, 53551). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable API chunking and promote to beta for 1.9 All list watchers default to using chunking. The server by default fills pages to avoid low cardinality filters from making excessive numbers of requests. Fix an issue with continuation tokens where a `../` could be used if the feature was enabled. ```release-note API chunking via the `limit` and `continue` request parameters is promoted to beta in this release. Client libraries using the Informer or ListWatch types will automatically opt in to chunking. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove replicaset unit tests that are converted to integration tests **What this PR does / why we need it**: This PR revamps existing replicaset unit tests by removing the tests that have been converted to integration tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52118 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. removes k8s.io/kubernetes/pkg/api dependency from the webhook plugin. **What this PR does / why we need it**: removes `k8s.io/kubernetes/pkg/api` dependency from `webhook` plugin. The runtime.scheme can be injected to the webhook from the plugin initializer. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53297, 53328). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cpu Manager - make CoreID's platform unique **What this PR does / why we need it**: Cpu Manager uses topology from cAdvisor(`/proc/cpuinfo`) where coreID's are socket unique - not platform unique - this causes problems on multi-socket platforms. All code assumes unique coreID's (on platform) - `Discovery` function has been changed to assign CoreID as the lowest cpuID from all cpus belonging to the same core. This can be expressed as: `CoreID=min(cpuID's on the same core)` Since cpuID's are platform unique - above gives us guarantee that CoreID's will also be platform unique. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53323
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53297, 53328). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. format some code in dockershim **What this PR does / why we need it**: format some code in dockershim **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53477, 53614). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix potential problem when scaling --replicas=0 **What this PR does / why we need it**: We have defensive code for checking if newRS != nil for DeploymentProgressing and DeploymentTimedOut but not for DeploymentComplete. Let's add the check here as well as this problem was seen in the wild. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes #53613 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move initializer plugin to the generic apiserver * Moves `k8s.io/kuberentes/plugin/pkg/admission/initialization` to `k8s.io/apiserver/pkg/admission/plugin/initialization` * Moves `k8s.io/kubernetes/pkg/kubeapiserver/admission/configuration` to `k8s.io/apiserver/pkg/admission/configuration` * The initializer plugin used to depend on `k8s.io/kubernetes` because it does a type assertion of `api.Pod`. It tries to skip mirror pod. I converted that code to use the generic accessor pattern.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53525, 53652). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. code-generator: fix flag check in generate-internal-groups.sh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53525, 53652). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apimachinery: remove ObjectCopier interface(s) The big commit is a mechanical, transitive removal of the copier interfaces in all structs and function calls.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52987, 53638). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix generate-groups.sh This script should run when user pass arguements like this: ``` generate-groups.sh deepcopy "k8s.io/coredump-detector/" "k8s.io/coredump-detector/apis/" "coredump:v1alpha1" ``` /assign @sttts **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Merge pull request #52987 from mattjmcnaughton/mattjmcnaughton/make-unnecessarily-public-functions-private-in-podautoscaler Automatic merge from submit-queue (batch tested with PRs 52987, 53638). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make unnecessary hpa public funcs private **What this PR does / why we need it**: Previously `pkg.controller.podautoscaler.UnsafeConvertToVersion` was exported. However, it was never used outside of the `podautoscaler` package. Make it private to prevent confusion. Additionally, move the two private functions in `horizontal.go` to be with the other private functions at the bottom of the file - imho its more readable than having them directly at the top of the file, before the public type and function definitions. **Release note**: ```release-note NONE ```
-
Clayton Coleman authored
Pick a reasonable middle ground between allocating larger chunks of memory (2048 * ~500b for pod slices) and having many small allocations as the list is resized by preallocating capacity based on the expected list size. At worst, we'll allocate a 1M slice for pods and only add a single pod to it (if the selector is very specific).
-
Clayton Coleman authored
-
Clayton Coleman authored
Change the filtering logic to require a leading path and clean that afterwards.
-
Clayton Coleman authored
The etcd3 storage now attempts to fill partial pages to prevent clients having to make more round trips (latency from server to etcd is lower than client to server). The server makes repeated requests to etcd of the current page size, then uses the filter function to eliminate any matches. After this change the apiserver will always return full pages, but we leave the language in place that clients must tolerate it. Reduces tail latency of large filtered lists, such as viewing pods assigned to a node.
-
Clayton Coleman authored
All list watchers default to using chunking.
-
Dr. Stefan Schimanski authored
-
mattjmcnaughton authored
Previously `pkg.controller.podautoscaler.UnsafeConvertToVersion` was exported. However, it was never used outside of the `podautoscaler` package. Make it private to prevent confusion. Additionally, move the two private functions in `horizontal.go` to be with the other private functions at the bottom of the file - imho its more readable than having them directly at the top of the file, before the public type and function definitions.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cleaning tests from deprecated usecases due to unsupported version **What this PR does / why we need it**: this part of the #52356 effort **Which issue this PR fixes**: **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Szymon Scharmach authored
-
Cao Shufeng authored
This script should run when user pass arguements like this: generate-groups.sh deepcopy "k8s.io/coredump-detector/" "k8s.io/coredump-detector/apis/" "coredump:v1alpha1"
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. amend about kubectl create secret of changelog **What this PR does / why we need it**: kubectl create secret has a new option --from-env-file that populates a configmap from file which follows a key=val format for each line. maybe copy the above line ,need change the configmap to secret,thanks! **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Retry when checking Azure storage account readiness **What this PR does / why we need it**: When the Azure cloud provider ensures that a default storage container exists, if the storage account exists but is still provisioning, it exits without retrying. This is a bug as the code is wrapped in a backoff policy but never signals the policy to retry. This PR fixes this behaviour by returning values which allow the backoff policy to operate. **Which issue this PR fixes**: fixes #53052 **Special notes for your reviewer**: Not sure how to test this - I have done a deployment using acs-engine and it seems to work but I am not sure of the best way to exercise the failure path. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Return an error if metric cannot be registered **What this PR does / why we need it**: `prometheus.MustRegister` panics if a metric cannot be registered. This PR replaces it with `prometheus.Register`, as it does not panic, and returns the error if the metric cannot be registered. I also adds lacking tests for `RegisterMetricAndTrackRateLimiterUsage`. **Which issue this PR fixes**: Fixes #52872 **Special notes for your reviewer**: None of the `metrics.RegisterMetricAndTrackRateLimiterUsage` invocations check the returned error, so I plan to submit new PRs to address this. **Release note**: ```release-note NONE ``` /sig instrumentation
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. revamp replicaset integration tests **What this PR does / why we need it**: This PR revamps existing replicaset integration tests. Some unit tests have been converted to integration tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #51484 **Release note**: ```release-note NONE ``` **TODO List**: - [x] add an integration test to verify scale endpoint works - [ ] convert testReplicaSetConditionCheck() to integration test, and modify the test as replicaset's condition has been removed - [ ] ~~HPA-related replicaset integration test (may be better suited under HPA integration tests)~~ - [x] verify all tests from "Suggested unit tests to retain" list of the internal doc will not be converted to integration tests, or convert the tests accordingly - [ ] ~~refactor sync call tree (refer deployment and daemonset PRs)~~ - [x] further improve written integration tests (revise test strategies, remove redundant GET / UPDATE calls, add more relevant sub-tests) - [x] remove unit tests that have overlapping testing goals with written integration tests
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Don't skip mounts if we can't find the volume **What this PR does / why we need it**: Return an error instead of skipping the volume while constructing the list of volume mounts for the container runtime. This prevents the scenario of a container writing data to an ephemeral volume when it expects the volume to be persistent. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53421 **Release note**: NONE @kubernetes/sig-storage-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53621, 52320, 53625). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [GCE] Bump GLBC to 0.9.7 Updating GLBC to the latest version ```release-note GCE: Bump GLBC version to [0.9.7](https://github.com/kubernetes/ingress/releases/tag/0.9.7). ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53621, 52320, 53625). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. revamp replicaset e2e tests **What this PR does / why we need it**: This PR removes some replicaset e2e tests as they will be converted to integration tests: (1) condition check test (2) pod adoption test (3) pod release(orphaning) test **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52118 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53621, 52320, 53625). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix a bad cut/paste of a node label. Fixes concerns [raised](https://github.com/kubernetes/kubernetes/pull/53146#pullrequestreview-66541495) in #53146 @mikedanese @jdumars
-
Jun Xiang Tee authored
-
nikhiljindal authored
-
- 09 Oct, 2017 8 commits
-
-
Brendan Burns authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix annoying leader election typo Small typo that annoyed me. It expected `configmaps`
-
Davanum Srinivas authored
We have defensive code for checking if newRS != nil for DeploymentProgressing and DeploymentTimedOut but not for DeploymentComplete. Let's add the check here as well as this problem was seen in the wild.
-
Michelle Au authored
-
p0lyn0mial authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. query --incompatible_comprehension_variables_do_not_leak=false Also set this flag for `bazel query` See #52677 ```release-note NONE ``` /assign ixdy
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not set auto-detect cloud provider as the default in kubelet **What this PR does / why we need it**: This is part of the move to external cloud providers. Please see plan detail in issue 50986. This PR covers step 2: v1.9 - set no cloud provider as the default in kubelet but still allow opt in for auto-detect **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes: https://github.com/kubernetes/kubernetes/issues/50986 **Special notes for your reviewer**: **Release note**: ```release-note kubelet's `--cloud-provider` flag no longer defaults to "auto-detect". If you want cloud-provider support in kubelet, you must set a specific cloud-provider explicitly. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Return err when delete volume failed Return err when delete volume failed **Release note**: ```release-note NONE ``` /kind bug /sig openstack
-