1. 09 Jul, 2018 1 commit
  2. 25 Jun, 2018 5 commits
  3. 24 Jun, 2018 6 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #65411 from nikhita/fix-publishing-bot-fakeclient · 7a9a30a4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 63773, 65411). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      client-go/examples/fake-client: add doc.go to fix go build warnings
      
      The publishing bot is currently broken (https://github.com/kubernetes/kubernetes/issues/56876#issuecomment-399763681). This is due to the following error:
      
      ```
      [24 Jun 18 15:08 UTC]: Running smoke tests for branch master
      [24 Jun 18 15:08 UTC]: /bin/bash -xec "godep restore\ngo build ./...\ngo test $(go list ./... | grep -v /vendor/)\n"
      	+ godep restore
      	+ go build ./...
      	go build k8s.io/client-go/examples/fake-client: no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client
      [24 Jun 18 15:09 UTC]: exit status 1
          	+ godep restore
          	+ go build ./...
          	go build k8s.io/client-go/examples/fake-client: no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client
      
      [24 Jun 18 15:09 UTC]: exit status 1```
      ```
      
      The fakeclient package does not have any non-test go files. The test file was added in https://github.com/kubernetes/kubernetes/pull/65291 2 days ago.
      
      This causes `go build` to give a warning: `no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client`, which breaks the publishing bot. This PR adds a dummy doc.go file in the package to avoid this warning and fix the publishing bot.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      7a9a30a4
    • Kubernetes Submit Queue's avatar
      Merge pull request #63773 from k82cn/rm_unused_var · f23ae617
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 63773, 65411). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Removed unused vars.
      Signed-off-by: 's avatarDa K. Ma <klaus1982.cn@gmail.com>
      
      **Release note**:
      ```release-note
      None
      ```
      f23ae617
    • Nikhita Raghunath's avatar
      client-go/examples/fake-client: add doc.go to fix go build warnings · 764ae696
      Nikhita Raghunath authored
      The fakeclient package does not have any non-test go files. This
      causes `go build` to give a warning: `no non-test Go files in ...`.
      This also causes the publishing bot to fail.
      
      This PR adds a dummy doc.go file in the package to avoid this warning.
      764ae696
    • Kubernetes Submit Queue's avatar
      Merge pull request #65391 from smarterclayton/describe · ec37c0f6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      When splitting `snake_case` words, omit the underscore
      
      While we require camelCase by convention for official APIs, CRDs may use
      `snake_case`, and the generic describer prints this as `Snake _ Case`.  We should print `Snake Case`
      
      Prow is impacted by this for the ProwJob CRD:
      
      ```
        Decoration _ Config:
          Gcs _ Configuration:
            Bucket:                    origin-ci-test
            Default _ Org:             openshift
            Default _ Repo:            origin
            Path _ Strategy:           single
          Gcs _ Credentials _ Secret:  gcs-publisher-credentials
      ```
      
      @kubernetes/sig-cli-pr-reviews
      
      ```release-note
      Using `kubectl describe` on CRDs that use underscores will be prettier.
      ```
      ec37c0f6
    • Kubernetes Submit Queue's avatar
      Merge pull request #65396 from bsalamat/sched_no_sort · f0311d82
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Improve scheduler's performance by eliminating sorting of nodes by their score
      
      **What this PR does / why we need it**:
      Profiling scheduler, I noticed that scheduler spends a significant amount of time in sorting the nodes after we score them to find nodes with the highest score. Finding nodes with the highest score does not need sorting the array. This PR replaces the sort with a linear scan.
      
      Eliminating the sort results in over 10% improvement in throughput of the scheduler.
      
      Before (3 runs for 5000 nodes, scheduling 1000 pods in a cluster running 2000 pods):
      BenchmarkScheduling/5000Nodes/2000Pods-12         	    1000	  20682552 ns/op
      BenchmarkScheduling/5000Nodes/2000Pods-12         	    1000	  20464729 ns/op
      BenchmarkScheduling/5000Nodes/2000Pods-12         	    1000	  21188906 ns/op
      
      After:
      BenchmarkScheduling/5000Nodes/2000Pods-12         	    1000	  18485866 ns/op
      BenchmarkScheduling/5000Nodes/2000Pods-12         	    1000	  18457749 ns/op
      BenchmarkScheduling/5000Nodes/2000Pods-12         	    1000	  18418200 ns/op
      
      **Release note**:
      
      ```release-note
      Improve scheduler's performance by eliminating sorting of nodes by their score.
      ```
      f0311d82
    • Da K. Ma's avatar
      Removed unused vars. · 66d558df
      Da K. Ma authored
      Signed-off-by: 's avatarDa K. Ma <klaus1982.cn@gmail.com>
      66d558df
  4. 23 Jun, 2018 15 commits
  5. 22 Jun, 2018 13 commits