This introduces some decoupling between the mainline logic and the
federation logic.

Moves some utility functions into `util` package.

Automatic merge from submit-queue

rkt: Convert image name to be a valid acidentifier

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
Fix a bug under the rkt runtime whereby image-registries with ports would not be fetched from
```

This fixes a bug whereby an image reference that included a port was not
recognized after being downloaded, and so could not be run

This is the quick-and-simple fix. In the longer term, we'll want to refactor image logic a bit more to handle the many special cases that the current code does not, mostly related to library images on dockerhub.

/cc @yifan-gu @kubernetes/sig-rktnetes

Automatic merge from submit-queue

Update elasticsearch and kibana usage

```release-note
Updated default Elasticsearch and Kibana used for elasticsearch logging destination to versions 2.4.1 and 4.6.1 respectively.
```

Updated controllers for elasticsearch and kibana to use newer versions of images. Fixed e2e test because of elasticsearch backward incompatible API changes.

Fixed out of sync elasticsearch controller for coreos.

@piosz

Automatic merge from submit-queue

Update pkg/volume/OWNERS to include Jan Safranek

Automatic merge from submit-queue

Self-assign logging tests

@fejta @piosz

Automatic merge from submit-queue

Updated addon manager READMEs

Updates addon-manager's README. Based on the pre-condition that the addon manager keeps current "reconciled" pattern instead of "fire-once".

@mikedanese

Revert "Only delete GKE clusters that exist"

Jan maintains the binder and volume driver code and should be listed as an owner of this package.

Automatic merge from submit-queue

Optimize computing fields in pod

Automatic merge from submit-queue

Only delete GKE clusters that exist

This matches the gce pattern: https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/util.sh#L1197

Automatic merge from submit-queue

Predicate cacheing and cleanup

Fix to #31795 

First pass @ cleanup and caching of the CheckServiceAffinity function.  

The cleanup IMO is necessary because the logic around the pod listing and the use of the "implicit selector" (which is reverse engineered to enable the homogenous pod groups).

Should still pass the E2Es.

@timothysc @wojtek-t

Automatic merge from submit-queue

Loadbalanced client src ip preservation enters beta

Sounds like we're going to try out the proposal (https://github.com/kubernetes/kubernetes/issues/30819#issuecomment-249877334) for annotations -> fields on just one feature in 1.5 (scheduler). Or do we want to just convert to fields right now?

Automatic merge from submit-queue

Add NodePort value in kubectl output

This PR enhances kubectl output after the command execution: `kubectl get svc`.
It additionally shows the value of the NodePort.

This PR is a response for this issue: https://github.com/kubernetes/kubernetes/issues/34100

Automatic merge from submit-queue

Verify petset status.replicas in e2e test

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**: follow up #33983. PetSet status.replicas bug is fixed, so adding tests for it (especially for the `should handle healthy pet restarts during scale` case)

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:  cc @erictune @foxish @kubernetes/sig-apps

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
NONE
```

Comments addressed, Make emptyMetadataProducer a func to avoid casting,
FakeSvcLister: remove error return for len(svc)=0.  New test for
predicatePrecomp to make method semantics explictly enforced when meta
is missing. Precompute wrapper.

Automatic merge from submit-queue

wait until the pods are deleted completely

Drain the pods on a node safely by keeping polling until all pods has been deleted.

```release-note
kubectl drain now waits until pods have been delete from the Node before exiting
```

Fixes: #34782

Automatic merge from submit-queue

If token validation fails, give the user the expected format.

If a user specifies their own token to kubeadm, and it fails validation, the error they currently receive isn't the friendliest. This first change adds messaging for the expected token format, with more improvements to follow as part of #33930. It also adds some unit tests to document the behavior we have currently.

CC: @mikedanese, @krousey, @kubernetes/sig-cluster-lifecycle

Part of #33930.

Automatic merge from submit-queue

Set non-always RestartPolicy for write-pod in pv e2e

Due to https://github.com/kubernetes/kubernetes/pull/34632 the RestartPolicy can't be Always (& it shouldn't be anyway)

Automatic merge from submit-queue

kubectl: Fix --help output for kubectl create service loadbalancer

Automatic merge from submit-queue

Add comment for why EndpointsStore doesn't have DeleteFunc

I was confused about why EndpointsStore does not need to have the DeleteFunc. I think it would be helpful to have a comment here.

@bprashanth @bowei

Automatic merge from submit-queue

registry: remove redundant PDB deep-copy from eviction REST

Automatic merge from submit-queue

Retry curl when it failed during download

Fixes #34769

For now I'm adding retry only to etcd installation as I saw it recently to fail in one of my PRs. We may change it also in other places if it also happens.

Automatic merge from submit-queue

Makeuse of PVC namespace when provisioning gluster volumes.

Depends on https://github.com/kubernetes/kubernetes/pull/34611

Automatic merge from submit-queue

check_node_count falls out of use, clear from docs/devel/e2e-tests.md

delete "--check_node_count " for testing against local clusters

Automatic merge from submit-queue

Don't report FS stats for system containers in the Kubelet Summary API

Fixes https://github.com/kubernetes/kubernetes/issues/31999

Automatic merge from submit-queue

add a clean code for TestCanSupport

Automatic merge from submit-queue

Fixing flakes caused by petset tests.

**What this PR does / why we need it**: We should wait till the key/value has been replicated to database slaves before trying to read from them.

**Which issue this PR fixes** Fixes https://github.com/kubernetes/kubernetes/issues/33904, https://github.com/kubernetes/kubernetes/issues/33895

cc @kubernetes/sig-apps

Automatic merge from submit-queue

Add secret e2e test for keys mapping

**What this PR does / why we need it**: Adds a basic e2e test missing in secrets

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*:

**Special notes for your reviewer**:

**Release note**:
```NONE
```
This patch adds a secret e2e test. While configmap e2e tests are far
more complete, this patch makes secret e2e tests one step closer.

Also, now is more easy to add more tests without code duplication (as I
did in earlier patches :-/), because of the functions created, and is
more easy to make it similar to confimap e2e in the future, that is
really complete.

Automatic merge from submit-queue

requests.storage is a standard resource name

The value `requests.storage` is a valid standard resource name but was omitted from the standard list.

Automatic merge from submit-queue

Avoid unnecessary reallocations of slice in Cacher

Automatic merge from submit-queue

PVC informer lister supports listing

This will be used in follow-on PRs for quota evaluation backed by informers for pvcs.

/cc @deads2k @eparis @kubernetes/sig-storage

Automatic merge from submit-queue

Change code of conduct to call CNCF CoC by reference

**What this PR does / why we need it**:

Revises the Kubernetes Code of Conduct (CoC) to point to the CNCF CoC by reference. The CNCF CoC is nearly identical to the Kubernetes one. The only changes are replacing `Kubernetes` with `CNCF` and referencing the Linux Foundation events CoC.

Here is an exact diff of the changes between the Kubernetes CoC and the CNCF CoC: https://github.com/cncf/foundation/commit/9f3936e486806e4c2efffb25ebd3306dee203943

Note that this PR attempts to resolve https://github.com/cncf/foundation/issues/2 which is to have a standard CoC for all CNCF projects.

**Special notes for your reviewer**:

Cc @sarahnovotny @bgrant0607 @aronchick @caniszczyk @monadic