- 19 Jan, 2017 2 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Adding cos as an alias for gci. **What this PR does / why we need it**: Adding COS as an alias for GCI. cc: @adityakali @wonderfly
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Curating Owners: cmd/kubelet cc @yujuhong @dchen1107 @vishh In an effort to expand the existing pool of reviewers and establish a two-tiered review process (first someone lgtms and then someone experienced in the project approves), we are adding new reviewers to existing owners files. If You Care About the Process: ------------------------------ We did this by algorithmically figuring out who’s contributed code to the project and in what directories. Unfortunately, that doesn’t work well: people that have made mechanical code changes (e.g change the copyright header across all directories) end up as reviewers in lots of places. Instead of using pure commit data, we generated an excessively large list of reviewers and pruned based on all time commit data, recent commit data and review data (number of PRs commented on). At this point we have a decent list of reviewers, but it needs one last pass for fine tuning. Also, see https://github.com/kubernetes/contrib/issues/1389. TLDR: ----- As an owner of a sig/directory and a leader of the project, here’s what we need from you: 1. Use PR https://github.com/kubernetes/kubernetes/pull/35715 as an example. 2. The pull-request is made editable, please edit the `OWNERS` file to remove the names of people that shouldn't be reviewing code in the future in the **reviewers** section. You probably do NOT need to modify the **approvers** section. Names asre sorted by relevance, using some secret statistics. 3. Notify me if you want some OWNERS file to be removed. Being an approver or reviewer of a parent directory makes you a reviewer/approver of the subdirectories too, so not all OWNERS files may be necessary. 4. Please use ALIAS if you want to use the same list of people over and over again (don't hesitate to ask me for help, or use the pull-request above as an example)
-
- 18 Jan, 2017 38 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40105, 40095) Update dependencies: aws-sdk-go to 1.6.10; also cadvisor updating cadvisor mainly to include [this bugfix #1558](https://github.com/google/cadvisor/pull/1558) Because cadvisor vendors a newer version of aws than kubernetes, the aws dependency needed to be updated as well. cc: @justinsb @zmerlynn @timstclair
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40105, 40095) [OpenStack-Heat] Fix regex used to get object-store URL **Release note**: ```release-note Fixes a bug in the OpenStack-Heat kubernetes provider, in the handling of differences between the Identity v2 and Identity v3 APIs ```
-
caleb miles authored
make the sig-node-reviewers alias the reviewer for `cmd/kubelet/app`
-
caleb miles authored
add derekwaynecarr and Random-Liu as approvers and set the alias sig-node-reviewers as the reviewer
-
Maisem Ali authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39898, 39904) [scheduler] interface for config **What this PR fixes** This PR converts the Scheduler configuration factory into an interface, so that - the scheduler_perf and scheduler integration tests dont rely on the struct for their implementation - the exported functionality of the factory (i.e. what it needs to provide to create a scheduler configuration) is completely explicit, rather then completely coupled to a struct. - makes some parts of the factory immutable, again to minimize possible coupling. This makes it easier to make a custom factory in instances where we might specifically want to import scheduler logic without actually reusing the entire scheduler codebase.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Build release tars using bazel **What this PR does / why we need it**: builds equivalents of the various kubernetes release tarballs, solely using bazel. For example, you can now do ```console $ make bazel-release $ hack/e2e.go -v -up -test -down ``` **Special notes for your reviewer**: this is currently dependent on https://github.com/ixdy/bazel/commit/3b29803eb528ff525c7024190ffbf4b08c598cf2, which I have yet to turn into a pull request, since I'm still trying to figure out if this is the best approach. Basically, the issue comes up with the way we generate the various server docker image tarfiles and load them on nodes: * we `md5sum` the binary being encapsulated (e.g. kube-proxy) and save that to `$binary.docker_tag` in the server tarball * we then build the docker image and tag using that md5sum (e.g. `gcr.io/google_containers/kube-proxy:$MD5SUM`) * we `docker save` this image, which embeds the full tag in the `$binary.tar` file. * on cluster startup, we `docker load` these tarballs, which are loaded with the tag that we'd created at build time. the nodes then use the `$binary.docker_tag` file to find the right image. With the current bazel `docker_build` rule, the tag isn't saved in the docker image tar, so the node is unable to find the image after `docker load`ing it. My changes to the rule save the tag in the docker image tar, though I don't know if there are subtle issues with it. (Maybe we want to only tag when `--stamp` is given?) Also, the docker images produced by bazel have the timestamp set to the unix epoch, which is not great for debugging. Might be another thing to change with a `--stamp`. Long story short, we probably need to follow up with bazel folks on the best way to solve this problem. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36467, 36528, 39568, 40094, 39042) do not filter kubectl get pods if -o json or yaml Fixes: https://github.com/kubernetes/kubernetes/issues/38327 This patch sets the value of --show-all to true if the output format specified is 'json' or 'yaml'. **Release note**: ```release-note release-note-none ``` @smarterclayton
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36467, 36528, 39568, 40094, 39042) Bump GCE to container-vm-v20170117 Base image update only, no kubelet or Docker updates. ```release-note Update GCE ContainerVM deployment to container-vm-v20170117 to pick up CVE fixes in base image. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36467, 36528, 39568, 40094, 39042) Improve code coverage for algorithm/predicates. Improve code coverage for algorithm/predicates for #39559 . Improved coverage from 71.3% to 81.9%. Coverage report: [combined-coverage.html.gz](https://github.com/kubernetes/kubernetes/files/691518/combined-coverage.html.gz)
-
Sean M. Collins authored
"publicURL" is used for endpoints in the Identity v2 API, while in the Identity v3 API it has been changed to just "public" Fixes #40102
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Curating Owners: pkg/kubelet cc @euank @vishh @dchen1107 @feiskyer @yujuhong @yifan-gu @derekwaynecarr @saad-ali In an effort to expand the existing pool of reviewers and establish a two-tiered review process (first someone lgtms and then someone experienced in the project approves), we are adding new reviewers to existing owners files. If You Care About the Process: ------------------------------ We did this by algorithmically figuring out who’s contributed code to the project and in what directories. Unfortunately, that doesn’t work well: people that have made mechanical code changes (e.g change the copyright header across all directories) end up as reviewers in lots of places. Instead of using pure commit data, we generated an excessively large list of reviewers and pruned based on all time commit data, recent commit data and review data (number of PRs commented on). At this point we have a decent list of reviewers, but it needs one last pass for fine tuning. Also, see https://github.com/kubernetes/contrib/issues/1389. TLDR: ----- As an owner of a sig/directory and a leader of the project, here’s what we need from you: 1. Use PR https://github.com/kubernetes/kubernetes/pull/35715 as an example. 2. The pull-request is made editable, please edit the `OWNERS` file to remove the names of people that shouldn't be reviewing code in the future in the **reviewers** section. You probably do NOT need to modify the **approvers** section. Names asre sorted by relevance, using some secret statistics. 3. Notify me if you want some OWNERS file to be removed. Being an approver or reviewer of a parent directory makes you a reviewer/approver of the subdirectories too, so not all OWNERS files may be necessary. 4. Please use ALIAS if you want to use the same list of people over and over again (don't hesitate to ask me for help, or use the pull-request above as an example)
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Curating Owners: test/e2e_node cc @random-liu @timstclair @vishh In an effort to expand the existing pool of reviewers and establish a two-tiered review process (first someone lgtms and then someone experienced in the project approves), we are adding new reviewers to existing owners files. If You Care About the Process: ------------------------------ We did this by algorithmically figuring out who’s contributed code to the project and in what directories. Unfortunately, that doesn’t work well: people that have made mechanical code changes (e.g change the copyright header across all directories) end up as reviewers in lots of places. Instead of using pure commit data, we generated an excessively large list of reviewers and pruned based on all time commit data, recent commit data and review data (number of PRs commented on). At this point we have a decent list of reviewers, but it needs one last pass for fine tuning. Also, see https://github.com/kubernetes/contrib/issues/1389. TLDR: ----- As an owner of a sig/directory and a leader of the project, here’s what we need from you: 1. Use PR https://github.com/kubernetes/kubernetes/pull/35715 as an example. 2. The pull-request is made editable, please edit the `OWNERS` file to remove the names of people that shouldn't be reviewing code in the future in the **reviewers** section. You probably do NOT need to modify the **approvers** section. Names asre sorted by relevance, using some secret statistics. 3. Notify me if you want some OWNERS file to be removed. Being an approver or reviewer of a parent directory makes you a reviewer/approver of the subdirectories too, so not all OWNERS files may be necessary. 4. Please use ALIAS if you want to use the same list of people over and over again (don't hesitate to ask me for help, or use the pull-request above as an example)
-
Mike Danese authored
update glibc to version pushed on 16-Jan-2017 19:12
-
David Ashpole authored
-
jayunit100 authored
-
Mike Danese authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add node problem detector role Adds a node problem detector role based on https://github.com/kubernetes/node-problem-detector/blob/master/pkg/problemclient/problem_client.go
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Use versioned Taint/Toleration/AvoidPods objects when marshalling fixes #39847 `kubectl taint`, the kubelet's `--register-with-taints` option, and several Taint/Toleration/AllowPod annotation helpers were marshaling/unmarshaling using internal structs
-
David Ashpole authored
-
David Ashpole authored
-
Zach Loafman authored
Base image update only, no kubelet or Docker updates.
-
Antoine Pelisse authored
-
juanvallejo authored
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39625, 39842) AWS: Remove duplicate calls to DescribeInstance during volume operations This change removes all duplicate calls to describeInstance from aws volume code path. **What this PR does / why we need it**: This PR removes the duplicate calls present in disk check code paths in AWS. I can confirm that `getAWSInstance` actually returns all instance information already and hence there is no need of making separate `describeInstance` call. Related to - https://github.com/kubernetes/kubernetes/issues/39526 cc @justinsb @jsafrane
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 39625, 39842) Add RBAC v1beta1 Add `rbac.authorization.k8s.io/v1beta1`. This scrubs `v1alpha1` to remove cruft, then add `v1beta1`. We'll update other bits of infrastructure to code to `v1beta1` as a separate step. ```release-note The `attributeRestrictions` field has been removed from the PolicyRule type in the rbac.authorization.k8s.io/v1alpha1 API. The field was not used by the RBAC authorizer. ``` @kubernetes/sig-auth-misc @liggitt @erictune
-
Antoine Pelisse authored
-
Jordan Liggitt authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Enable lazy initialization of ext3/ext4 filesystems **What this PR does / why we need it**: It enables lazy inode table and journal initialization in ext3 and ext4. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #30752, fixes #30240 **Release note**: ```release-note Enable lazy inode table and journal initialization for ext3 and ext4 ``` **Special notes for your reviewer**: This PR removes the extended options to mkfs.ext3/mkfs.ext4, so that the defaults (enabled) for lazy initialization are used. These extended options come from a script that was historically located at */usr/share/google/safe_format_and_mount* and later ported to GO so this dependency to the script could be removed. After some search, I found the original script here: https://github.com/GoogleCloudPlatform/compute-image-packages/blob/legacy/google-startup-scripts/usr/share/google/safe_format_and_mount Checking the history of this script, I found the commit [Disable lazy init of inode table and journal.](https://github.com/GoogleCloudPlatform/compute-image-packages/commit/4d7346f7f59cb88ec934c436bd853b74f4ebbaf5). This one introduces the extended flags with this description: ``` Now that discard with guaranteed zeroing is supported by PD, initializing them is really fast and prevents perf from being affected when the filesystem is first mounted. ``` The problem is, that this is not true for all cloud providers and all disk types, e.g. Azure and AWS. I only tested with magnetic disks on Azure and AWS, so maybe it's different for SSDs on these cloud providers. The result is that this performance optimization dramatically increases the time needed to format a disk in such cases. When mkfs.ext4 is told to not lazily initialize the inode tables and the check for guaranteed zeroing on discard fails, it falls back to a very naive implementation that simply loops and writes zeroed buffers to the disk. Performance on this highly depends on free memory and also uses up all this free memory for write caching, reducing performance of everything else in the system. As of https://github.com/kubernetes/kubernetes/issues/30752, there is also something inside kubelet that somehow degrades performance of all this. It's however not exactly known what it is but I'd assume it has something to do with cgroups throttling IO or memory. I checked the kernel code for lazy inode table initialization. The nice thing is, that the kernel also does the guaranteed zeroing on discard check. If it is guaranteed, the kernel uses discard for the lazy initialization, which should finish in a just few seconds. If it is not guaranteed, it falls back to using *bio*s, which does not require the use of the write cache. The result is, that free memory is not required and not touched, thus performance is maxed and the system does not suffer. As the original reason for disabling lazy init was a performance optimization and the kernel already does this optimization by default (and in a much better way), I'd suggest to completely remove these flags and rely on the kernel to do it in the best way.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40038, 40041, 39036) don't show deleted pull secrets - kubectl describe This patch filters out any image pull secrets that have been deleted when printing the describer output for a service account. Related downstream bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1403376 **Release note**: ```release-note release-note-none ``` @fabianofranz @AdoHe
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40038, 40041, 39036) move admission to genericapiserver I disconnected the initialization that was type specific for later assessment. @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Start making `k8s.io/client-go` authoritative for generic client packages Right now, client-go has copies of various generic client packages which produces golang type incompatibilities when you want to switch between different kinds of clients. In many cases, there's no reason to have two sets of packages. This pull eliminates the copy for `pkg/client/transport` and makes `client-go` the authoritative copy. I recommend going by commits, the first just synchronizes the client-go code again so that I could test the copy script to make sure it correctly preserves the original package. @kubernetes/sig-api-machinery-misc @lavalamp @sttts
-
deads2k authored
-
Klaus Ma authored
-
deads2k authored
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Added RBAC for heapster in kubemark Fixes #39952 cc @wojtek-t @gmarek @deads2k
-