1. 11 Jul, 2018 3 commits
  2. 02 Jul, 2018 15 commits
  3. 01 Jul, 2018 4 commits
  4. 30 Jun, 2018 18 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #65402 from hanxiaoshuai/fix0623 · 4ebebfc4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65349, 65354, 65402). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Get rid of depends on kubectl in kubeadm
      
      **What this PR does / why we need it**:
      Get rif of depends on kubectl in kubeadm
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      4ebebfc4
    • Kubernetes Submit Queue's avatar
      Merge pull request #65354 from hanxiaoshuai/fix06222 · e8f35c02
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65349, 65354, 65402). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fixtodo: Move these kubelet start/stop functions to phases/kubelet
      
      **What this PR does / why we need it**:
      fixtodo: Move these kubelet start/stop functions to phases/kubelet
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      e8f35c02
    • Kubernetes Submit Queue's avatar
      Merge pull request #65349 from hanxiaoshuai/fix0622 · d70b8f50
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65349, 65354, 65402). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      check error when failed to prepull the images
      
      **Special notes for your reviewer**:
      return error when failed to prepull the images
      **Release note**:
      
      ```release-note
      NONE
      ```
      d70b8f50
    • Yang Li's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #65627 from IvanovOleg/master · df09802b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 64758, 65627). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fixed the wrong elasticsearch node counter
      
      **What this PR does / why we need it**:
      I am experiencing the nasty bug during the deployment of the elasticsearch-logging statefulset on my custom Kubernetes in Azure (AzureDisk persistant storage). Let's imaging that we want two master nodes which our elasticsearch will try to find during the discovery procedure. Because of the delay between creation of two nodes (azure disk creation) there will be a situation when only one node exists in the service endpoint list and it will be enough to pass the elasticsearch logging discovery step. Only one node will be written to the elasticsearch.yml, but it expects two. Elasticsearch will not be able to find required two nodes. Then Kubernetes will terminate the first pod while the second pod is almost ready (remove that endpoint from service). Then it adds the ip of the second pod to the endpoint and discovery fails as well. This is the endless procedure.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Fixes the wrong elasticsearch node counter
      
      ```
      df09802b
    • Kubernetes Submit Queue's avatar
      Merge pull request #64758 from pivotal-k8s/64222-vcp-ca-cert · 64243d48
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Setup TLS with CA Cert for vsphere cloud provider
      
      - Extend config to take a path to a CA Certificate
      - Use the CA Cert when establishing a connection with the SOAP client
      
      Testing
      We provide certs and keys for tests as fixtures, `vclib/fixtures`.
      Those were created (and can be regenerated) using `vclib/fixtures/createCerts.sh`.
      
      At the moment it's possible to configure a CA path and at the same time allow insecure
      communication between vsphere cloud provider and vcenter. This may
      change in the future; we might opt for overwriting the insecure
      communication if a CA is configured / log and transparently pass the
      arguments to the vcenter command / other. To be discussed.
      
      At the moment the CA is a global level configuration. In other
      words, all vcenter servers need to use certificates signed by the same
      CA. There might be use cases for different CA per vcenter server; to be
      discussed.
      
      
      
      
      
      **What this PR does / why we need it**:
      This PR adds the option of configuring a trusted CA for the communication between the vsphere cloud provider and the vcenter control plane.
      
      **Which issue(s) this PR fixes**:
      Fixes #64222
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      - Can configure the vsphere cloud provider with a trusted Root-CA
      ```
      64243d48
    • hangaoshuai's avatar
      Get rid of depends on kubectl in kubeadm · bf5b6335
      hangaoshuai authored
      bf5b6335
    • Kubernetes Submit Queue's avatar
      Merge pull request #65534 from honkiko/remove-dup-masq-rule · f1f16614
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65188, 65541, 65534). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      ipvs: remove duplicated masq rules
      
      Duplicated masq rules are created by current implementation:
      ```
      -A KUBE-NODE-PORT -m comment --comment "mark MASQ for
      externaltrafficpolicy=cluster" -j KUBE-MARK-MASQ
      -A KUBE-NODE-PORT -j KUBE-MARK-MASQ
      ```
      The last one is always there. So the one inside if statement could
      just be removed.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      
      ```
      f1f16614
    • Kubernetes Submit Queue's avatar
      Merge pull request #65541 from jiayingz/upgrade-test · f119fa14
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65188, 65541, 65534). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Increase certain waiting time window in gpu_device_plugin e2e_node test.
      
      Kubelet restart process seems to get a bit slower recently. From running
      the gpu_device_plugin e2e_node test on GCE, I saw it took ~37 seconds
      for kubelet to start CM DeviceManager after it restarts, and then took
      ~12 seconds for the gpu device plugin to re-register. As the result,
      this e2e_node test fails because the current 10 sec waiting time is too
      small. Restarting a container also seems to get slower that it sometimes
      exceeds the current 2 min waiting time in ensurePodContainerRestart().
      This change increase both waiting time to 5 min to leave enough space
      on slower machines.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      none
      ```
      f119fa14
    • Kubernetes Submit Queue's avatar
      Merge pull request #65188 from aveshagarwal/master-rhbz-1555057 · ea3451f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65188, 65541, 65534). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Increase glog level of some scheduling errors.
      
      In our production environments, we are noticing that for every scheduling error, we are logging 3 errors at following lines:
      
      1. https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/scheduler.go#L194
      
      2. https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/factory/factory.go#L1416
      
      3. https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/factory/factory.go#L1323
      
      This PR increases log levels of the last 2 errors to V(3).Infof. We can discuss if it would be helpful to increase the log level of the first error too.
      
      @kubernetes/sig-scheduling-pr-reviews 
      @bsalamat @k82cn @liggitt @sjenning 
      
      ```release-note
      None.
      ```
      ea3451f8
    • Kubernetes Submit Queue's avatar
      Merge pull request #65645 from sttts/sttts-gengo-import-aliases · a9be647e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65582, 65480, 65310, 65644, 65645). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Bump gengo to remove _ from generated import aliases
      
      Pickup https://github.com/kubernetes/gengo/pull/113 and https://github.com/kubernetes/gengo/pull/111.
      
      Avoid tons of golint exceptions for https://github.com/kubernetes/kubernetes/pull/64664.
      a9be647e
    • Kubernetes Submit Queue's avatar
      Merge pull request #65644 from tvansteenburgh/master · 97e2d2af
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65582, 65480, 65310, 65644, 65645). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add Ubuntu 18.04 (Bionic) series to Juju charms
      
      **What this PR does / why we need it**:
      Adds Ubuntu 18.04 (Bionic) series to Juju charms. 16.04 (Xenial) is still the default series, but with this change the charms can be easily deployed on Bionic if desired.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      Add Ubuntu 18.04 (Bionic) series to Juju charms
      ```
      97e2d2af
    • Kubernetes Submit Queue's avatar
      Merge pull request #65310 from wenlxie/upstream.master.fixlocalvolumevmnotfound · 55c5aaac
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65582, 65480, 65310, 65644, 65645). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix local volume directory can't be deleted issue
      
      **What this PR does / why we need it**:
      Need to add volume mode field to constructed pv spec.
      
      **Special notes for your reviewer**:
      I  get an issue:
      1) kubelet has lots of logs with errors  related with volume mode
      ```
      Jun 21 10:31:18  kubelet[19333]: E0621 10:31:18.422321   19333 reconciler.go:179] operationExecutor.NewVolumeHandler for UnmountVolume failed for volume "lv-e57cf589-4658-4881-b125-7b9f35c2c8eb" (UniqueName: "kubernetes.io/local-volume/4103e613-656c-11e8-8c20-74dbd180ddb4-lv-e57cf589-4658-4881-b125-7b9f35c2c8eb") pod "4103e613-656c-11e8-8c20-74dbd180ddb4" (UID: "4103e613-656c-11e8-8c20-74dbd180ddb4") : cannot get volumeMode for volume: lv-e57cf589-4658-4881-b125-7b9f35c2c8eb
      Jun 21 10:31:18  kubelet[19333]: E0621 10:31:18.422351   19333 reconciler.go:179] operationExecutor.NewVolumeHandler for UnmountVolume failed for volume "lv-b1e788ac-78eb-4d26-819a-263cef5337ea" (UniqueName: "kubernetes.io/local-volume/4082c1da-656c-11e8-8c20-74dbd180ddb4-lv-b1e788ac-78eb-4d26-819a-263cef5337ea") pod "4082c1da-656c-11e8-8c20-74dbd180ddb4" (UID: "4082c1da-656c-11e8-8c20-74dbd180ddb4") : cannot get volumeMode for volume: lv-b1e788ac-78eb-4d26-819a-263cef5337ea
      ```
      2) The pod is an orphan pod and have the volume directory left at the node
      
      3) Because of the errors, the volume directory will never be deleted
      
      **Release note**:
      ```release-note
      Fix local volume directory can't be deleted because of volumeMode error
      ```
      55c5aaac
    • Kubernetes Submit Queue's avatar
      Merge pull request #65480 from liggitt/rotate-serving-certificate · ecf2c0e4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65582, 65480, 65310, 65644, 65645). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      allow enabling kubelet serving certificate rotation via flag
      
      allows the server rotation feature to be exercised via flags as well as config file
      
      ```release-note
      NONE
      ```
      ecf2c0e4
    • Kubernetes Submit Queue's avatar
      Merge pull request #65582 from dtaniwaki/fix-test-failure-of-truncated-time · b265f7c6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65582, 65480, 65310, 65644, 65645). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix test failure of truncated time
      
      **What this PR does / why we need it**:
      
      The test of `TestFsStoreAssignedModified` in `pkg/kubelet/kubeletconfig/checkpoint/store` fails in my environment like below.
      
      ```
      $ make test WHAT=./pkg/kubelet/kubeletconfig/checkpoint/store/
      Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admissionregistration.k8s.io/v1beta1,admission.k8s.io/v1beta1,apps/v1beta1,apps/v1beta2,apps/v1,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2beta1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,coordination.k8s.io/v1beta1,extensions/v1beta1,events.k8s.io/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,scheduling.k8s.io/v1beta1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,storage.k8s.io/v1alpha1,
      +++ [0628 22:53:39] Running tests without code coverage
      --- FAIL: TestFsStoreAssignedModified (0.00s)
              fsstore_test.go:316: expect "2018-06-28T22:53:43+09:00" but got "2018-06-28T22:53:43+09:00"
      FAIL
      FAIL    k8s.io/kubernetes/pkg/kubelet/kubeletconfig/checkpoint/store    0.236s
      make: *** [test] Error 1
      ```
      
      My environment is
      OS: macOS Sierra Version 10.12.6
      File System: Journaled HFS+
      
      The error message confused me because the comparing times looked the same in the error log. If we know certain systems truncate times, I think we can just compare less precise times to avoid confusions in tests.
      
      **Special notes for your reviewer**:
      N/A
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b265f7c6
    • Kubernetes Submit Queue's avatar
      Merge pull request #65586 from juju-solutions/feature/prep-1.11 · 10913b7b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65518, 65624, 65380, 65390, 65586). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Preparing for 1.11 release and update ingress image to 0.16.1
      
      **What this PR does / why we need it**: This is to prepare Juju charms to default to 1.11 release. 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      10913b7b
    • Kubernetes Submit Queue's avatar
      Merge pull request #65390 from cfork/test · 16dbb95c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65518, 65624, 65380, 65390, 65586). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      cleanup: remove deadcode
      
      /kind cleanup
      
      remove deadcode
      remove unnecessary conversion
      
      ```release-note
      NONE
      ```
      16dbb95c
    • Kubernetes Submit Queue's avatar
      Merge pull request #65380 from janetkuo/delete-ds-12 · 1c2b2de6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 65518, 65624, 65380, 65390, 65586). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove kubectl delete hack that handles DaemonSet deletion
      
      **What this PR does / why we need it**: follow up #64847
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      
      **Special notes for your reviewer**: 
      /cc @liggitt @soltysh 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      1c2b2de6