- 11 Oct, 2017 21 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix format specifiers in Azure cloud provider **What this PR does / why we need it**: Fixes invalid/mismatched format specifiers in Azure cloud provider logging statements (`glog...Infof(...)`) that would cause information to be lost in logging output, as flagged by `go vet`. **Which issue this PR fixes**: None **Special notes for your reviewer**: None **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Using assertions in Unit tests Using assertions: 1. cmd/kube-controller-manager/app/controller_manager_test.go 2. pkg/controller/bootstrap/jws_test.go 3. pkg/controller/cloud/node_controller_test.go 4. pkg/controller/controller_utils_test.go Partially fix https://github.com/kubernetes/kubernetes/issues/43788
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cleaning node controller from code for unsupported versions **What this PR does / why we need it**: **Which issue this PR fixes**: fixes #52356 **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50223, 53205). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Create e2e tests for Custom Metrics - Stackdriver Adapter and HPA based on custom metrics from Stackdriver **What this PR does / why we need it**: - Add e2e test for Custom Metrics - Stackdriver Adapter - Add 2e2 test for HPA based on custom metrics from Stackdriver - Enable HorizontalPodAutoscalerUseRESTClients option **Release note**: ```release-note Horizontal pod autoscaler uses REST clients through the kube-aggregator instead of the legacy client through the API server proxy. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove duplicate code fixing empty name error **What this PR does / why we need it**: Removes two helper functions which have duplicate code; code can be safely added to the calling function. This does add an extra parameter to calls. Since the helpers are file local functions with only two call sites it is trivial to see that this PR maintains current logic. **Special notes for your reviewer**: The diff is a bit convoluted since this PR [re]moves lines in consecutive functions. **Release note**: ```release-note NONE ``` /sig cli /kind cleanup
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52520, 52033, 53626, 50478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix kube-proxy to use proper iptables commands for IPv6 operation For iptables save and restore operations, kube-proxy currently uses the IPv4 versions of the iptables save and restore utilities (iptables-save and iptables-restore, respectively). For IPv6 operation, the IPv6 versions of these utilities need to be used (ip6tables-save and ip6tables-restore, respectively). Both this change and PR #48551 are needed to get Kubernetes services to work in an IPv6-only Kubernetes cluster (along with setting '--bind-address ::0' on the kube-proxy command line. This change was alluded to in a discussion on services for issue #1443. fixes #50474 **What this PR does / why we need it**: This change modifies kube-proxy so that it uses the proper commands for iptables save and iptables restore for IPv6 operation. Currently kube-proxy uses 'iptables-save' and 'iptables-restore' regardless of whether it is being used in IPv4 or IPv6 mode. This change fixes kube-proxy so that it uses 'ip6tables-save' and 'ip6tables-restore' commands when kube-proxy is being run in IPv6 mode. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50474 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52520, 52033, 53626, 50478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. GCE kube-down: Delete all remaining firewall rules when DELETE_NETWORK is set **What this PR does / why we need it**: From https://github.com/kubernetes/kubernetes/issues/52347#issuecomment-335245693, we think it'd be reasonable to cleanup firewall resources as well during GCE kube-down. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #NONE **Special notes for your reviewer**: /assign @shyamjvs @bowei **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52520, 52033, 53626, 50478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Removed the IPv6 prefix size limit for cluster-cidr Fixes #50395 /sig network /area ipv6 cc @rpothier
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52520, 52033, 53626, 50478). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add 'ETCD_DOCKER_REPOSITORY' env var override to 'cluster/' scripts. **What this PR does / why we need it**: This allows the etcd docker registry that is currently hard coded to `gcr.io/google_containers/etcd` in the `etcd.manifest` template to be overridden. This can be used to test new versions of etcd with kubernetes that have not yet been published to `gcr.io/google_containers/etcd` and also enables cluster operators that use the 'cluster/' scripts to manage the etcd images used by their cluster in an internal repository. Example usage: ``` $ export ETCD_DOCKER_REPOSITORY=gcr.io/jpbetz-public-images/etcd $ export ETCD_IMAGE=3.0.17 $ cluster/kube-up.sh ... $ gcloud compute ssh kubernetes-master ~ $ sudo cat /etc/kubernetes/manifests/etcd.manifest { "apiVersion": "v1", "kind": "Pod", "metadata": { "name":"etcd-server", ... }, "spec":{ "hostNetwork": true, "containers":[ { "name": "etcd-container", "image": "gcr.io/jpbetz-public-images/etcd:3.0.17", ... ``` **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move endpoints IPPart function to util **What this PR does / why we need it**: Clean up proxier.go Move endpoints IPPart function to util so that it can be consumed by different proxiers. BTW, the newer `IPPart()` supports IPV6, we need to update it in `ipvs/proxier.go` **Which issue this PR fixes**: closes #53632 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig network /area kube-proxy
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix minor typo **What this PR does / why we need it**: Typo error **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Chen Li authored
Using assertions for unit tests: 1. cmd/kube-controller-manager/app/controller_manager_test.go 2. pkg/controller/bootstrap/jws_test.go 3. pkg/controller/cloud/node_controller_test.go 4. pkg/controller/controller_utils_test.go
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubectl: Remove swagger 1.2 entirely. **What this PR does / why we need it**: Remove dead code since nothing is using swagger 1.2 anymore. This doesn't change any feature, it's just removing unused code. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: Follow up on #44589 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase backoffLimit for job that we expect to fail several times **What this PR does / why we need it**: Since the introduction of `backoffLimit` for a job that single test failed majority of times on: `BackoffLimitExceeded: Job has reach the specified backoff limit`. I'm bumping this to 999, so that it has enough room to fail several times. **Which issue this PR fixes**: Fixes #35507. **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
m1093782566 authored
-
m1093782566 authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53678, 53677, 53682, 53673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix to prevent downward api change break on older versions Signed-off-by:
Timothy St. Clair <timothysc@gmail.com> **What this PR does / why we need it**: Prevents "should provide pod and host IP as an env var [Conformance]" from running on older versions whose api does not have that field and will break on those clusters. This is not a upstream tested configuration, but downstream folks do this regularly. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: N/A **Special notes for your reviewer**: N/A **Release note**: ``` Prevent downward api-change from breaking on older version ``` /cc @kubernetes/sig-testing-bugs @jpbetz @marun
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53678, 53677, 53682, 53673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make sure we use rwlocks not just RLock We need to use of rwlock for updating the desired state of world. I think `-race` flag doesn't detects this consistently. Fixes #53590
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53678, 53677, 53682, 53673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix typo in StatefulSet e2e test Found it while reviewing #53218 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Append an alpha label to the exclude load balancer annotation. There were concerns that this was not going through the alpha/beta process, so adding an `alpha` label. @mikedanese @caseydavenport @jdumars
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. clarifying CLI output **What this PR does / why we need it**: backporting documentation changes made to generated CLI documentation so that the source is correct for updates to the documentation and kubernetes website. This is part of what is needed to resolve https://github.com/kubernetes/kubernetes.github.io/issues/5618 and is updated based on review feedback while fixing that bug at https://github.com/kubernetes/kubernetes.github.io/pull/5824 **Which issue this PR fixes** needed for full resolution of https://github.com/kubernetes/kubernetes.github.io/issues/5618, but will not fix it in itself due to generated documentation being stored as a separate process **Special notes for your reviewer**: Feedback on these changes originated from edits in the k8s docs repository and feedback to regenerated markdown to resolve them. ```release-note NONE ```
-
- 10 Oct, 2017 19 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. wait for pod to be fully deleted **What this PR does / why we need it**: Fix flaky glusterfs io-streaming tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49529 **Special notes for your reviewer**: 1) max potential wait for complete pod deletion is ~~15m~~ 5m. 2) ~~removed [Flaky] from HostCleanup, _e2e/node/kubelet.go_ since pod deletion is reliable now.~~ 3) ~~added tag [Slow] to HostCleanup due to long max wait for pod deletion.~~ After all CI tests run reliably we can consider removing the [Flaky] tag (2, above), or do that in a separate pr. ```release-note NONE ``` cc @msau42
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52354, 52949, 53551). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add client and server versions to the e2e.test output. Fixes #53502. ```release-note NONE ``` Sample output: ``` Oct 6 15:02:44.001: INFO: Client version: v1.9.0-alpha.1.737+3b1b19a1-dirty Oct 6 15:02:44.039: INFO: Server version: v1.8.0 ``` /assign @timothysc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52354, 52949, 53551). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable API chunking and promote to beta for 1.9 All list watchers default to using chunking. The server by default fills pages to avoid low cardinality filters from making excessive numbers of requests. Fix an issue with continuation tokens where a `../` could be used if the feature was enabled. ```release-note API chunking via the `limit` and `continue` request parameters is promoted to beta in this release. Client libraries using the Informer or ListWatch types will automatically opt in to chunking. ```
-
Hemant Kumar authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove replicaset unit tests that are converted to integration tests **What this PR does / why we need it**: This PR revamps existing replicaset unit tests by removing the tests that have been converted to integration tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52118 **Release note**: ```release-note NONE ```
-
Antoine Pelisse authored
-
Zihong Zheng authored
-
Janet Kuo authored
-
Brendan Burns authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. removes k8s.io/kubernetes/pkg/api dependency from the webhook plugin. **What this PR does / why we need it**: removes `k8s.io/kubernetes/pkg/api` dependency from `webhook` plugin. The runtime.scheme can be injected to the webhook from the plugin initializer. **Release note**: ``` NONE ```
-
Timothy St. Clair authored
Signed-off-by:Timothy St. Clair <timothysc@gmail.com>
-
Joe Betz authored
This allows the etcd docker registry that is currently hard coded to `gcr.io/google_containers/etcd` in the `etcd.manifest` template to be overridden. This can be used to test new versions of etcd with kubernetes that have not yet been published to `gcr.io/google_containers/etcd` and also enables cluster operators to manage the etcd images used by their cluster in an internal repository.
-
Joe Heck authored
backporting documentation changes made to generated CLI documentation so that the source is correct for updates to the documentation and kubernetes website. This is part of what is needed to resolve https://github.com/kubernetes/kubernetes.github.io/issues/5618 and is updated based on review feedback while fixing that bug at https://github.com/kubernetes/kubernetes.github.io/pull/5824
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53297, 53328). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cpu Manager - make CoreID's platform unique **What this PR does / why we need it**: Cpu Manager uses topology from cAdvisor(`/proc/cpuinfo`) where coreID's are socket unique - not platform unique - this causes problems on multi-socket platforms. All code assumes unique coreID's (on platform) - `Discovery` function has been changed to assign CoreID as the lowest cpuID from all cpus belonging to the same core. This can be expressed as: `CoreID=min(cpuID's on the same core)` Since cpuID's are platform unique - above gives us guarantee that CoreID's will also be platform unique. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53323
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53297, 53328). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. format some code in dockershim **What this PR does / why we need it**: format some code in dockershim **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
jeff vance authored
-
Yassine TIJANI authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53477, 53614). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix potential problem when scaling --replicas=0 **What this PR does / why we need it**: We have defensive code for checking if newRS != nil for DeploymentProgressing and DeploymentTimedOut but not for DeploymentComplete. Let's add the check here as well as this problem was seen in the wild. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes #53613 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move initializer plugin to the generic apiserver * Moves `k8s.io/kuberentes/plugin/pkg/admission/initialization` to `k8s.io/apiserver/pkg/admission/plugin/initialization` * Moves `k8s.io/kubernetes/pkg/kubeapiserver/admission/configuration` to `k8s.io/apiserver/pkg/admission/configuration` * The initializer plugin used to depend on `k8s.io/kubernetes` because it does a type assertion of `api.Pod`. It tries to skip mirror pod. I converted that code to use the generic accessor pattern.
-