1. 25 Mar, 2017 8 commits
    • Manjunath A Kumatagi's avatar
      Fix docker volume selinux issue · 52f9875c
      Manjunath A Kumatagi authored
      52f9875c
    • Kubernetes Submit Queue's avatar
      Merge pull request #41581 from marun/cleanup-test-integration · 4aa91685
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581)
      
      Cleanup make test-integration
      
      ``make test-integration`` was using the first positional arg passed to ``WHAT`` to filter the list of integration test packages.  This PR switches to passing ``WHAT`` verbatim to be consistent with how ``make test`` works.  That means the new way to scope execution to a single integration package will be:
      
      ```bash
      make test-integration WHAT="./test/integration/auth" KUBE_TEST_ARGS="-run=^TestKindAuthorization$"
      ```
      
      Instead of:
      
      ```bash
      make test-integration WHAT="auth -test.run=^TestKindAuthorization$"
      ```
      
      This PR also ensures that the script exits after running a single test case and that etcd cleanup is not done twice at the end of a successful test run.  Both were issues encountered while diagnosing the scoping issue.
      
      cc: @thockin @deads2k @stevekuznetsov @ncdc @derekwaynecarr
      4aa91685
    • Kubernetes Submit Queue's avatar
      Merge pull request #42170 from rootfs/azure-file-prv · 3fcb7cb3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581)
      
      Enable storage class support in Azure File volume
      
      **What this PR does / why we need it**:
      Support StorageClass in Azure file volume
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Support StorageClass in Azure file volume
      
      ```
      3fcb7cb3
    • Kubernetes Submit Queue's avatar
      Merge pull request #41813 from shiywang/timeout_options · 20b01be0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581)
      
      Be able to specify the timeout to wait for pod for kubectl logs/attach
      
      Fixes https://github.com/kubernetes/kubernetes/issues/41786
      current flag is `get-pod-timeout`, we can have a discussion if you have better one, default unit is seconds, above 0
      
      @soltysh @kargakis ptal, thanks
      @kubernetes/sig-cli-feature-requests
      20b01be0
    • Kubernetes Submit Queue's avatar
      Merge pull request #43170 from madhusudancs/fed-system-ns · ae0faca7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581)
      
      Add the ability to customize federation system namespace in e2e turn up scripts.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      ae0faca7
    • Kubernetes Submit Queue's avatar
      Merge pull request #43642 from ixdy/release-candidate-regexes · 0859bf1e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43642, 43170, 41813, 42170, 41581)
      
      Update a few regex patterns to support release candidates
      
      **What this PR does / why we need it**: A release candidate was cut for 1.6 (v1.6.0-rc.1), but some scripts don't recognize this version string.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      0859bf1e
    • krousey's avatar
      Merge pull request #43650 from rmmh/fix-defer · 6a10125f
      krousey authored
      Remove an accidentally duplicated line when adding a defer in #42157.
      
      Unblocking queue
      6a10125f
    • Ryan Hitchman's avatar
  2. 24 Mar, 2017 32 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #42631 from NickrenREN/pv-isVolumeBoundToClaim-1 · d585eb30
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42522, 42545, 42556, 42006, 42631)
      
      optimize the binding logic of bindClaimToVolume
      
      extract var shouldSetBoundByController and do not need to judge volumename twice
      **Release note**:
      ```release-note
      NONE
      ```
      d585eb30
    • Kubernetes Submit Queue's avatar
      Merge pull request #42006 from screeley44/error-events3 · 803369b9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42522, 42545, 42556, 42006, 42631)
      
      Fixes MountVolume.NewMounter errors not displayed to users via describe events
      
      Fixes #42004 
      
      This fixes the problem of mount errors being eaten and not displayed to users again.  Specifically erros caught in MountVolume.NewMounter (like missing endpoints, etc...)
      
      Current behavior for any mount failure:
      
      ```
      Events:
        FirstSeen    LastSeen    Count    From            SubObjectPath    Type        Reason        Message
        ---------    --------    -----    ----            -------------    --------    ------        -------
        12m        12m        1    default-scheduler            Normal        Scheduled    Successfully assigned glusterfs-bb-pod1 to 127.0.0.1
        10m        1m        5    kubelet, 127.0.0.1            Warning        FailedMount    Unable to mount volumes for pod "glusterfs-bb-pod1_default(67c9dfa7-f9f5-11e6-aee2-5254003a59cf)": timeout expired waiting for volumes to attach/mount for pod "default"/"glusterfs-bb-pod1". list of unattached/unmounted volumes=[glusterfsvol]
        10m        1m        5    kubelet, 127.0.0.1            Warning        FailedSync    Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod "default"/"glusterfs-bb-pod1". list of unattached/unmounted volumes=[glusterfsvol]
      ```
      
      New Behavior:
      
      For example on glusterfs - deliberately didn't create endpoints, now correct message is displayed:
      ```
      Events:
        FirstSeen	LastSeen	Count	From			SubObjectPath	Type		Reason		Message
        ---------	--------	-----	----			-------------	--------	------		-------
        2m		2m		1	default-scheduler			Normal		Scheduled	Successfully assigned glusterfs-bb-pod1 to 127.0.0.1
        54s		54s		1	kubelet, 127.0.0.1			Warning		FailedMount	Unable to mount volumes for pod "glusterfs-bb-pod1_default(8edd2c25-fa09-11e6-92ae-5254003a59cf)": timeout expired waiting for volumes to attach/mount for pod "default"/"glusterfs-bb-pod1". With error timed out waiting for the condition. list of unattached/unmounted volumes=[glusterfsvol]
        54s		54s		1	kubelet, 127.0.0.1			Warning		FailedSync	Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod "default"/"glusterfs-bb-pod1". With error timed out waiting for the condition. list of unattached/unmounted volumes=[glusterfsvol]
        2m		6s		814	kubelet, 127.0.0.1			Warning		FailedMount	MountVolume.NewMounter failed for volume "kubernetes.io/glusterfs/8edd2c25-fa09-11e6-92ae-5254003a59cf-glusterfsvol" (spec.Name: "glusterfsvol") pod "8edd2c25-fa09-11e6-92ae-5254003a59cf" (UID: "8edd2c25-fa09-11e6-92ae-5254003a59cf") with: endpoints "glusterfs-cluster" not found
      ```
      803369b9
    • Kubernetes Submit Queue's avatar
      Merge pull request #42556 from resouer/fix-id · a4986e38
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42522, 42545, 42556, 42006, 42631)
      
      Use pod sandbox id in checkpoint
      
      **What this PR does / why we need it**: we should log out sandbox id when checkpoint error
      
      **Release note**:
      
      ```NONE
      ```
      a4986e38
    • Kubernetes Submit Queue's avatar
      Merge pull request #42545 from shiywang/e2e · 57fbbc61
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42522, 42545, 42556, 42006, 42631)
      
      add e2e test for `apply set/view last-applied` command
      
      @pwittrock  @kubernetes/sig-cli-pr-reviews
      57fbbc61
    • Kubernetes Submit Queue's avatar
      Merge pull request #42522 from NickrenREN/pv-err-print · d2175bab
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      print err message when update store failed
      
      ```release-note
      NONE
      ```
      d2175bab
    • Madhusudan.C.S's avatar
    • Jeff Grafton's avatar
      e39978e6
    • Kubernetes Submit Queue's avatar
      Merge pull request #43635 from bowei/gce-owner · bc6e77d4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add bowei to OWNERS of cloudproviders/gce
      
      ```release-note
      none
      ```
      bc6e77d4
    • Kubernetes Submit Queue's avatar
      Merge pull request #42551 from shashidharatd/e2e-tests · a34da764
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42237, 42297, 42279, 42436, 42551)
      
      Cleanup federation_util.go in e2e/framework
      
      The only function GetValidDNSSubdomainName in  test/e2e/framework/federation_util.go is no longer used for some time now. so cleaning it up.
      
      cc @kubernetes/sig-federation-pr-reviews @madhusudancs
      a34da764
    • Kubernetes Submit Queue's avatar
      Merge pull request #42436 from vmware/add-stateful-set-example.kerneltime · c2286b8c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42237, 42297, 42279, 42436, 42551)
      
      Add example for how to use vSphere volumes in Stateful Sets
      
      **What this PR does / why we need it**: Examples yaml for using vSphere volumes in stateful sets.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      c2286b8c
    • Kubernetes Submit Queue's avatar
      Merge pull request #42279 from copejon/fix-pvc-poll-error-message · 694088b3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42237, 42297, 42279, 42436, 42551)
      
      Reword PVC polling message to log a more readable message.
      
      **What this PR does / why we need it**:
      Previous message used to report an error is misleading and poorly written.  This PR changes the log to be more readable.
      
      ```release-note
      NONE
      ```
      694088b3
    • Kubernetes Submit Queue's avatar
      Merge pull request #42297 from YuPengZTE/devErrorf · fb537762
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42237, 42297, 42279, 42436, 42551)
      
      should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...)
      Signed-off-by: 's avataryupengzte <yu.peng36@zte.com.cn>
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      fb537762
    • Kubernetes Submit Queue's avatar
      Merge pull request #42237 from kargakis/remove-extra-deep-copy · f22e621f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      controller: drop extra rs deep-copy
      
      @janetkuo @mwielgus
      f22e621f
    • Kubernetes Submit Queue's avatar
      Merge pull request #42157 from jsafrane/fix-zone-test · 5136922f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix test for provisioning in unmanaged zone.
      
      defer evaluates arguments of the deferred function immediately, so it actually
      deleted a storage class and a claim before the test could do anything useful.
      
      The test passed just accidentally, as the test is expected to time out. It
      timed out from wrong reasons though.
      
      @copejon @kubernetes/sig-storage-pr-reviews 
      
      ```release-note
      NONE
      ```
      5136922f
    • Bowei Du's avatar
      Add bowei to OWNERS of cloudproviders/gce · 0ab072dd
      Bowei Du authored
      0ab072dd
    • Anthony Yeh's avatar
      Update CHANGELOG.md for v1.6.0-rc.1. · 24d601b0
      Anthony Yeh authored
      24d601b0
    • Kubernetes Submit Queue's avatar
      Merge pull request #42034 from brendandburns/azure · 264c8b43
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41139, 41186, 38882, 37698, 42034)
      
      Add support for bring-your-own ip address for Services on Azure
      
      @colemickens @codablock
      264c8b43
    • Kubernetes Submit Queue's avatar
      Merge pull request #37698 from jsafrane/remove-all-filesystems · d14854fd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41139, 41186, 38882, 37698, 42034)
      
      Make kubelet never delete files on mounted filesystems
      
      With bug #27653, kubelet could remove mounted volumes and delete user data.
      The bug itself is fixed, however our trust in kubelet is significantly lower.
      Let's add an extra version of RemoveAll that does not cross mount boundary
      (rm -rf --one-file-system).
      
      It calls lstat(path) three times for each removed directory - once in
      RemoveAllOneFilesystem and twice in IsLikelyNotMountPoint, however this way
      it's platform independent and the directory that is being removed by kubelet
      should be almost empty.
      d14854fd
    • Kubernetes Submit Queue's avatar
      Merge pull request #38882 from fraenkel/configmap_env_file · 0e17e5bd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41139, 41186, 38882, 37698, 42034)
      
      create configmap from-env-file
      
      Allow ConfigMaps to be created from Docker based env files.
      
      See proposal https://github.com/kubernetes/community/issues/165
      
      **Release-note:**
      ```release-note
      1. create configmap has a new option --from-env-file that populates a configmap from file which follows a key=val format for each line.
      2. create secret has a new option --from-env-file that populates a configmap from file which follows a key=val format for each line.
      ```
      0e17e5bd
    • Kubernetes Submit Queue's avatar
      Merge pull request #41186 from dixudx/fix_percona_aptkey · 336a7609
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41139, 41186, 38882, 37698, 42034)
      
      update the signing key for percona debian and ubuntu packages
      
      **What this PR does / why we need it**:
      
      > W: GPG error: http://repo.percona.com trusty InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 9334A25F8507EFA5
      
      The signing key has already been updated. Please refer to [Update the Signing Key for Percona Debian and Ubuntu Packages](https://www.percona.com/blog/2016/10/13/new-signing-key-for-percona-debian-and-ubuntu-packages/) for detailed explanations.
      336a7609
    • Kubernetes Submit Queue's avatar
      Merge pull request #41139 from juanvallejo/jvallejo/set-cluster-api-value · 0d53679e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      config set cluster api value
      
      Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1420280
      
      **Release note**:
      ```release-note
      release-note-none
      ```
      
      This patch sets a specified api version if one is given while setting cluster values in kubeconfig
      
      cc @AdoHe  @pweil-
      0d53679e
    • Kubernetes Submit Queue's avatar
      Merge pull request #43343 from madhusudancs/fed-remove-kubefed-init-todos · f1575cca
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [Federation] Remove TODOs that are already implemented or are irrelevant now.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f1575cca
    • Kubernetes Submit Queue's avatar
      Merge pull request #42723 from FengyunPan/update_description · 1e092179
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Update the description to match function
      
      The description of NewReplicaSetController() does not match
      its function, and the description of NewDeploymentController()
      does not match its function. Let's update their descriptions.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      1e092179
    • Kubernetes Submit Queue's avatar
      Merge pull request #43609 from Random-Liu/update-npd-rbac · 53d14e9a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Update NPD rbac.
      
      I recently enabled NPD in gke.
      
      However, I found that in gke e2e test (https://k8s-testgrid.appspot.com/google-gke#gci-gke), npd on the node could not talk with apiserver, and reported full of following errors:
      ```
      E0324 05:08:26.745545    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
      E0324 05:08:37.719423    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
      E0324 05:08:47.719694    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
      ```
      
      I created a GKE cluster (v1.7.0-alpha.0.1483+1e879c69) myself, and found that addon manager could not create npd binding with the following error:
      ```
      error: error validating "/etc/kubernetes/addons/node-problem-detector/standalone/npd-binding.yaml": error validating data: couldn't find type: v1alpha1.ClusterRoleBinding; if you choose to ignore these errors, turn validation off with --validate=false
      ```
      
      I found that rbac was updated to beta, but npd was missed because it was merged after https://github.com/kubernetes/kubernetes/commit/9e6a3496b44e9a5ab9740cb903e46f769d65cde3#diff-b05c70853d9a772b310db71a61297841.
      
      I updated rbac to beta in the master manifest and npd on the node could talk with apiserver immediately.
      We must get this in 1.6 to make NPD working. @dchen1107 
      
      @dchen1107 @fabioy @liggitt
      53d14e9a
    • Kubernetes Submit Queue's avatar
      Merge pull request #41696 from justinsb/rationalize_aws_owners · 92f8d9be
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add approvers to the aws OWNERS file
      
      Without this it was picking up reviewers from a much higher directory.
      
      ```release-note
      NONE
      ```
      92f8d9be
    • Kubernetes Submit Queue's avatar
      Merge pull request #43302 from harryge00/fix-typo · 7e6b8c19
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix typos
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      7e6b8c19
    • Kubernetes Submit Queue's avatar
      Merge pull request #43071 from zjj2wry/master · 596fc98c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add comment end
      596fc98c
    • Kubernetes Submit Queue's avatar
      Merge pull request #43208 from NickrenREN/rc-expectation · 3b1d2343
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      small change to ControlleeExpectations result judgement
      
      GetByKey() will never return err, so err != nil {} is redundant,remove it and remove the err return too
      
      
      **Release note**:
      ```release-note
      NONE
      ```
      3b1d2343
    • Kubernetes Submit Queue's avatar
      Merge pull request #43217 from SEJeff/fix-spelling-tyop · 1aff24cb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix spelling of the word successfully
      
      A serious business project like kubernetes necessitates serious business logs.
      1aff24cb
    • Kubernetes Submit Queue's avatar
      Merge pull request #43148 from justinsb/typo_newgroupmetadfactory · 04b35a55
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix typo: NewGroupMetadFactory
      
      NewGroupMetadFactory -> NewGroupMetaFactory
      
      ```release-note
      NONE
      ```
      04b35a55
    • Kubernetes Submit Queue's avatar
      Merge pull request #42903 from krousey/owners · ba63cb45
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove krousey from some OWNERS files
      ba63cb45
    • Kubernetes Submit Queue's avatar
      Merge pull request #41404 from k82cn/correct_comments · 9169eda6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Updated comments for admission/storageclass.
      
      Correct comments to reflect fun's feature.
      9169eda6