- 07 Feb, 2018 37 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not recycle volumes that are used by pods **What this PR does / why we need it**: Recycler should wait until all pods that use a volume are finished. Consider this scenario: 1. User creates a PVC that's bound to a NFS PV. 2. User creates a pod that uses the PVC 3. User deletes the PVC. Now the PV gets `Released` (the PVC does not exists) and recycled, however the PV is still mounted to a running pod. PVC protection won't help us, because it puts finalizers on PVC that is under user's control and user can remove it. This PR checks that there is no pod that uses a PV before it recycles it. **Release note**: ```release-note NONE ``` /sig storage
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable HPA tests on large clusters Fix https://github.com/kubernetes/kubernetes/issues/55887 After https://github.com/kubernetes/test-infra/pull/6667 was able to run HPA tests 3 times successfully on 2k node cluster. /cc @shyamjvs @wojtek-t ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove mapper dependency for cmdutil.Factory#PrintSuccess **Release note**: ```release-note NONE ``` Part of a series of patches removing printing stack dependency on mappings the rest mapper **Before** ``` $ kubectl label pod/my-pod label=label pod "my-pod" labeled ``` **After** ``` $ kubectl label pod/my-pod label=label pods "my-pod" labeled ``` cc @deads2k
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add keyring parameter in Ceph RBD provisioner **What this PR does / why we need it**: userSecretName is a mandatory parameter for the kubernetes.io/rbd storage provisioner. Ceph RBD persistent volumes however don't need the secretRef. If no secret is given, a local keyring file (/etc/ceph/keyring) on the node will be used. This behaviour should also work with the storage provisioner. If no userSecretName parameter is given, no secretRef should be created in the resulting persistent volume. **Special notes for your reviewer**: **Release note**: ```release-note Add "keyring" parameter for Ceph RBD provisioner ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove duplicated comment
-
juanvallejo authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. simplify if logic **What this PR does / why we need it**: simplify if logic ,make it more clear Thanks. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove a todo which is out of date **What this PR does / why we need it**: fix todo: move container.go to e2e/framework **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57230, 59400). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. make sure mounter not nil and fix some typo **What this PR does / why we need it**: make sure mounter not nil then and fix some typo **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Mathias Merscher authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update kubeadm supported etcd version to 3.2.14 in 1.10 **What this PR does / why we need it**: Kubernetes will upgrade to etcd server 3.2.14 in 1.10 cycle (#58645), update DefaultEtcdVersion in kubeadm to this version. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: relevant PR: #57480 #58645 fixes: https://github.com/kubernetes/kubeadm/issues/621 **Special notes for your reviewer**: /cc @kubernetes/sig-cluster-lifecycle-pr-reviews **Release note**: ```release-note NONE ``` kubeadm don't need to advertise this in release notes.
-
Marek Siarkowicz authored
-
bin liu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix TODO:change to a api-server watch What this PR does / why we need it: fix TODO (vladimirvivien) instead of polling api-server, change to a api-server watch Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #58031 Special notes for your reviewer: Release note: NONE @vladimirvivien,@jsafrane,@saad-ali I saw some TODO there and I am very interested in fixing it. Please let me know if it is not inappropriate to do this.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58444, 59283, 59437, 59325, 59449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix to register priority function ResourceLimitsPriority correctly. **What this PR does / why we need it**: This PR fixes registration of priority function ResourceLimitsPriority. Previously this function was being registered inside `init()`. Since this priority function ResourceLimitsPriority is behind feature gate `ResourceLimitsPriorityFunction` and if the feature is enabled, it was not visible in `init()` function. So now the registration of this priority function is moved inside `ApplyFeatureGates()` in scheduler where it can be correctly registered after the feature has been enabled. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ``` @kubernetes/sig-scheduling-pr-reviews @bsalamat @ravisantoshgudimetla
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58444, 59283, 59437, 59325, 59449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Document kubeadm API Fixes https://github.com/kubernetes/kubeadm/issues/336 @kubernetes/sig-cluster-lifecycle-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58444, 59283, 59437, 59325, 59449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. authentication: remove TokenRequest from authentication.k8s.io/v1beta1 We don't actually need v1beta1 TokenRequest so should we leave the API group sparse? https://github.com/kubernetes/kubernetes/issues/58790 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58444, 59283, 59437, 59325, 59449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bzl: make integration tests actually work #59283 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58444, 59283, 59437, 59325, 59449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update PriorityClassName API doc **What this PR does / why we need it**: It updates the comment (and hence API doc) for PriorityClassName of PodSpec. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig scheduling
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59394, 58769, 59423, 59363, 59245). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ensure euqiv hash calculation is per schedule **What this PR does / why we need it**: Currently, equiv hash is calculated per schedule, but also, per node. This is a potential cause of dragging integration test, see #58881 We should ensure this only happens once during scheduling of specific pod no matter how many nodes we have. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #58989 **Special notes for your reviewer**: **Release note**: ```release-note Ensure euqiv hash calculation is per schedule ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59394, 58769, 59423, 59363, 59245). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kube-scheduler: Use default predicates/prioritizers if they are unspecified in the policy config **What this PR does / why we need it**: The scheduler has built-in default sets of predicate/prioritizer that are applied on pod scheduling. It can also take a policy config file where predicate/prioritizer and extender settings can be specified. The current behavior is that if we want to configure an extender using the policy config, we have to also provide the default predicate/prioritizer settings. Otherwise, the empty predicate/prioritizer sets will be used. This is inconvenient, and it's hard to keep the policy config up to date with the scheduler's defaults. This PR changes the scheduler to use the default predicate/prioritizer sets if they are unspecified in the policy config. But an empty list would bypass non-mandatory predicates/prioritizers. This will change the behavior of a policy config that does not specify (but not empty list) predicate/prioritizer, but it's unlike someone is using such config in practice. **Special notes for your reviewer**: I think it makes sense to have this in 1.9 as well because - It's safe, given the scope of this change and the fact that it's very unlikely that someone is using a policy config with empty predicates/prioritizers. - Compared with the risk, asking users to provide the default predicate/prioritizer sets for is error-prone and may cause other issues. **Release note**: ```release-note kube-scheduler: Use default predicates/prioritizers if they are unspecified in the policy config ``` /sig scheduling /assign @bsalamat /cc @vishh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59394, 58769, 59423, 59363, 59245). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Only populate alias range for nic0 when invoking instance.UpdateNetworkInterface. **What this PR does / why we need it**: Without the fix, GCP will emit errors, e.g., googleapi: Error 400: Invalid value for field 'resource.accessConfigs': ''. Updating this field is not supported., invalid **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # N/A **Special notes for your reviewer**: **Release note**: ```release-note "NONE" ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59394, 58769, 59423, 59363, 59245). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. IPv6: Ensure calculated node CIDR size for pod subnets is valid With IPv4, the node CIDR prefix is set to /24, which gives 256 pods per node and 256 nodes, when assuming a /16 is used for the pod subnet. For IPv6, the node CIDR prefix, is hard coded to /64. This does not work, because the pod subnet prefix must be /66 or higher and must be a larger subnet (lower value) than the node CIDR prefix. In addition, the bit mask used to track the subnets (implying the number of nodes), can only handle 32K entries, so the difference between pod subnet prefix and node CIDR prefix cannot be more than 16 (bits). To address this, the following algorithm is proposed to provide as many pods per node as possible, and not exceed the number of nodes. If the pod subnet prefix is from /66 to /104, we'll set the node CIDR prefix to 16 more, so that the bit map is not exceeded. The rest of the bits will be for pods per node. If the subnet prefix is from /105 to /112, we'll split the available bits between what is used for the nodes and what is used for the pods per node. This will give a node CIDR prefix from /116 to /120. If the subnet prefix is from /113 to /119, we'll do like IPv4 and ensure that there are 256 pods per node, and the remaining bits will be for the nodes, giving a node CIDR prefix of /120 always. This supports a limited number of nodes, in some cases. If the subnet prefix is /120 to /128, we don't have enough bits and will set the node CIDR prefix to be the same as the pod subnet prefix. This will cause a falure later, when it tests that the pod subnet prefix is larger than the node CIDR prefi. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #58766 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. svcacct: move claim generation out of TokenGenerator More no-op refactoring. https://github.com/kubernetes/kubernetes/issues/58790 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Better timeout in slower virtual machines **What this PR does / why we need it**: 60 seconds seems to work better in slower boxes **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ensure docker daemon opts are in effect before docker login **What this PR does / why we need it**: Make sure the kubernetes-worker charm is using the configured `docker-opts` daemon options prior to running the `docker-logins` handler. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # https://github.com/juju-solutions/layer-docker/issues/112 **Special notes for your reviewer**: **Release note**: ```release-note Fixed charm issue where docker login would run prior to daemon options being set. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add context to all relevant cloud APIs **What this PR does / why we need it**: This adds context to all the relevant cloud provider interface signatures. Callers of those APIs are currently satisfied using context.TODO(). There will be follow on PRs to push the context through the stack. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #815 **Special notes for your reviewer**: For an idea of the full scope of this change please look at PR #58532. **Release note**: ```release-note Implementers of the cloud provider interface will note the addition of a context to this interface. Trivial code modification will be necessary for a cloud provider to continue to compile. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix some log param error this patch fix some log parameter mistakes. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note /release-note-none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. test: bump timeout on //pkg/master TestValidOpenAPISpec often takes over a minute. This bumps the timeout from 60 seconds to 300 seconds. On my computer it takes ~73 seconds consisently. The calls to Validate() take the majority of the time. some recent failures: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59436/pull-kubernetes-bazel-test/29606/ https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59437/pull-kubernetes-bazel-test/29601/ https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59423/pull-kubernetes-bazel-test/29560/ https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59325/pull-kubernetes-bazel-test/29554/ ```release-note NONE ```
-
tanshanshan authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix TODO: moving Driver name check in API validation **What this PR does / why we need it**: fix TODO in csi_plugin.go ,moving Driver name check in API validation **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #58163 **Special notes for your reviewer**: **Release note**: NONE @vladimirvivien,@jsafrane,@saad-ali I saw some TODO there and I am very interested in fixing it. Please let me know if it is not inappropriate to do this.
-
Bobby (Babak) Salamat authored
-
Bobby (Babak) Salamat authored
-
hangaoshuai authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add unit test for endpoint allocate **What this PR does / why we need it**: Adds a unit test for covering `allocate` function at endpoint. **Release note**: ```release-note None ``` /kind testing /area hw-accelerators /cc @jiayingz @vishh @derekwaynecarr @RenaudWasTaken @resouer @ConnorDoyle
-
Avesh Agarwal authored
-
linyouchong authored
-
- 06 Feb, 2018 3 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Abstract some duplicated code in the iptables proxier Reorganizes the iptables proxier code so we only have the list of "-A FOO -j KUBE-BAR" rules in one place rather than duplicating the same list in multiple places. Split out from #56164 for ease of review/merging. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [GCE] Instance comparable host path **What this PR does / why we need it**: When creating a new TargetPool, insert new instances with the comparable host path instead of the full path, e.g. /zone/%s/instances/%s instead of the full https://www.googleapis.com/compute/v1/projects/... url. With this change, `createTargetPoolAndHealthCheck` and `updateTargetPool` insert gceInstance paths in a consistent manner. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Release note**: ```release-note NONE ```
-
Harry Zhang authored
-