- 10 Oct, 2017 20 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53477, 53614). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix potential problem when scaling --replicas=0 **What this PR does / why we need it**: We have defensive code for checking if newRS != nil for DeploymentProgressing and DeploymentTimedOut but not for DeploymentComplete. Let's add the check here as well as this problem was seen in the wild. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes #53613 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move initializer plugin to the generic apiserver * Moves `k8s.io/kuberentes/plugin/pkg/admission/initialization` to `k8s.io/apiserver/pkg/admission/plugin/initialization` * Moves `k8s.io/kubernetes/pkg/kubeapiserver/admission/configuration` to `k8s.io/apiserver/pkg/admission/configuration` * The initializer plugin used to depend on `k8s.io/kubernetes` because it does a type assertion of `api.Pod`. It tries to skip mirror pod. I converted that code to use the generic accessor pattern.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53525, 53652). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. code-generator: fix flag check in generate-internal-groups.sh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53525, 53652). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apimachinery: remove ObjectCopier interface(s) The big commit is a mechanical, transitive removal of the copier interfaces in all structs and function calls.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52987, 53638). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix generate-groups.sh This script should run when user pass arguements like this: ``` generate-groups.sh deepcopy "k8s.io/coredump-detector/" "k8s.io/coredump-detector/apis/" "coredump:v1alpha1" ``` /assign @sttts **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Merge pull request #52987 from mattjmcnaughton/mattjmcnaughton/make-unnecessarily-public-functions-private-in-podautoscaler Automatic merge from submit-queue (batch tested with PRs 52987, 53638). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make unnecessary hpa public funcs private **What this PR does / why we need it**: Previously `pkg.controller.podautoscaler.UnsafeConvertToVersion` was exported. However, it was never used outside of the `podautoscaler` package. Make it private to prevent confusion. Additionally, move the two private functions in `horizontal.go` to be with the other private functions at the bottom of the file - imho its more readable than having them directly at the top of the file, before the public type and function definitions. **Release note**: ```release-note NONE ```
-
Dr. Stefan Schimanski authored
-
mattjmcnaughton authored
Previously `pkg.controller.podautoscaler.UnsafeConvertToVersion` was exported. However, it was never used outside of the `podautoscaler` package. Make it private to prevent confusion. Additionally, move the two private functions in `horizontal.go` to be with the other private functions at the bottom of the file - imho its more readable than having them directly at the top of the file, before the public type and function definitions.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cleaning tests from deprecated usecases due to unsupported version **What this PR does / why we need it**: this part of the #52356 effort **Which issue this PR fixes**: **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Cao Shufeng authored
This script should run when user pass arguements like this: generate-groups.sh deepcopy "k8s.io/coredump-detector/" "k8s.io/coredump-detector/apis/" "coredump:v1alpha1"
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. amend about kubectl create secret of changelog **What this PR does / why we need it**: kubectl create secret has a new option --from-env-file that populates a configmap from file which follows a key=val format for each line. maybe copy the above line ,need change the configmap to secret,thanks! **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Retry when checking Azure storage account readiness **What this PR does / why we need it**: When the Azure cloud provider ensures that a default storage container exists, if the storage account exists but is still provisioning, it exits without retrying. This is a bug as the code is wrapped in a backoff policy but never signals the policy to retry. This PR fixes this behaviour by returning values which allow the backoff policy to operate. **Which issue this PR fixes**: fixes #53052 **Special notes for your reviewer**: Not sure how to test this - I have done a deployment using acs-engine and it seems to work but I am not sure of the best way to exercise the failure path. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Return an error if metric cannot be registered **What this PR does / why we need it**: `prometheus.MustRegister` panics if a metric cannot be registered. This PR replaces it with `prometheus.Register`, as it does not panic, and returns the error if the metric cannot be registered. I also adds lacking tests for `RegisterMetricAndTrackRateLimiterUsage`. **Which issue this PR fixes**: Fixes #52872 **Special notes for your reviewer**: None of the `metrics.RegisterMetricAndTrackRateLimiterUsage` invocations check the returned error, so I plan to submit new PRs to address this. **Release note**: ```release-note NONE ``` /sig instrumentation
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. revamp replicaset integration tests **What this PR does / why we need it**: This PR revamps existing replicaset integration tests. Some unit tests have been converted to integration tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #51484 **Release note**: ```release-note NONE ``` **TODO List**: - [x] add an integration test to verify scale endpoint works - [ ] convert testReplicaSetConditionCheck() to integration test, and modify the test as replicaset's condition has been removed - [ ] ~~HPA-related replicaset integration test (may be better suited under HPA integration tests)~~ - [x] verify all tests from "Suggested unit tests to retain" list of the internal doc will not be converted to integration tests, or convert the tests accordingly - [ ] ~~refactor sync call tree (refer deployment and daemonset PRs)~~ - [x] further improve written integration tests (revise test strategies, remove redundant GET / UPDATE calls, add more relevant sub-tests) - [x] remove unit tests that have overlapping testing goals with written integration tests
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Don't skip mounts if we can't find the volume **What this PR does / why we need it**: Return an error instead of skipping the volume while constructing the list of volume mounts for the container runtime. This prevents the scenario of a container writing data to an ephemeral volume when it expects the volume to be persistent. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53421 **Release note**: NONE @kubernetes/sig-storage-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53621, 52320, 53625). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [GCE] Bump GLBC to 0.9.7 Updating GLBC to the latest version ```release-note GCE: Bump GLBC version to [0.9.7](https://github.com/kubernetes/ingress/releases/tag/0.9.7). ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53621, 52320, 53625). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. revamp replicaset e2e tests **What this PR does / why we need it**: This PR removes some replicaset e2e tests as they will be converted to integration tests: (1) condition check test (2) pod adoption test (3) pod release(orphaning) test **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52118 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53621, 52320, 53625). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix a bad cut/paste of a node label. Fixes concerns [raised](https://github.com/kubernetes/kubernetes/pull/53146#pullrequestreview-66541495) in #53146 @mikedanese @jdumars
-
Jun Xiang Tee authored
-
nikhiljindal authored
-
- 09 Oct, 2017 20 commits
-
-
Brendan Burns authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix annoying leader election typo Small typo that annoyed me. It expected `configmaps`
-
Davanum Srinivas authored
We have defensive code for checking if newRS != nil for DeploymentProgressing and DeploymentTimedOut but not for DeploymentComplete. Let's add the check here as well as this problem was seen in the wild.
-
Michelle Au authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. query --incompatible_comprehension_variables_do_not_leak=false Also set this flag for `bazel query` See #52677 ```release-note NONE ``` /assign ixdy
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not set auto-detect cloud provider as the default in kubelet **What this PR does / why we need it**: This is part of the move to external cloud providers. Please see plan detail in issue 50986. This PR covers step 2: v1.9 - set no cloud provider as the default in kubelet but still allow opt in for auto-detect **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes: https://github.com/kubernetes/kubernetes/issues/50986 **Special notes for your reviewer**: **Release note**: ```release-note kubelet's `--cloud-provider` flag no longer defaults to "auto-detect". If you want cloud-provider support in kubelet, you must set a specific cloud-provider explicitly. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Return err when delete volume failed Return err when delete volume failed **Release note**: ```release-note NONE ``` /kind bug /sig openstack
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. In DevicePluginHandlerImpl.Allocate(), skips untracked extended resou… …rces. Otherwise, we would fail a Pod allocation request that has an extended resource not managed by any device plugin. **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # https://github.com/kubernetes/kubernetes/issues/53548 **Special notes for your reviewer**: **Release note**: ```release-note Ignore extended resources that are not registered with kubelet ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use const instead of hard code for volume plugin **What this PR does / why we need it**: nits: cleanup hard-coded volume plugin name **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Refactor network policy e2e tests, and add additional logging when tests fail **What this PR does / why we need it**: - Restructure tests, clean up duplicate code - Add additional logging, so it's easier to debug when the tests fail - Add retry on the client side pods because sometimes kubelet will start the pod when the network is not ready, resulting in flaky tests - Add readiness probe for the server pods to further reduce the flakiness. Current failure messages when a test fails: ``` checking client-can-connect could communicate with server. Expected error: <*errors.errorString | 0xc420868820>: { s: "pod \"client-can-connect\" failed with status: {Phase:Failed Conditions:[{Type:Initialized Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:} {Type:Ready Status:False LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:57 -0700 PDT Reason:ContainersNotReady Message:containers with unready status: [client-can-connect-container]} {Type:PodScheduled Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:}] Message: Reason: HostIP:10.138.0.2 PodIP:10.60.1.180 StartTime:2017-07-25 15:54:48 -0700 PDT InitContainerStatuses:[] ContainerStatuses:[{Name:client-can-connect-container State:{Waiting:nil Running:nil Terminated:&ContainerStateTerminated{ExitCode:1,Signal:0,Reason:Error,Message:,StartedAt:2017-07-25 15:54:49 -0700 PDT,FinishedAt:2017-07-25 15:54:57 -0700 PDT,ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57,}} LastTerminationState:{Waiting:nil Running:nil Terminated:nil} Ready:false RestartCount:0 Image:gcr.io/google_containers/redis:e2e ImageID:docker://sha256:e5e67996c442f903cda78dd983ea6e94bb4e542950fd2eba666b44cbd303df42 ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57}] QOSClass:BestEffort}", } pod "client-can-connect" failed with status: {Phase:Failed Conditions:[{Type:Initialized Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:} {Type:Ready Status:False LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:57 -0700 PDT Reason:ContainersNotReady Message:containers with unready status: [client-can-connect-container]} {Type:PodScheduled Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:}] Message: Reason: HostIP:10.138.0.2 PodIP:10.60.1.180 StartTime:2017-07-25 15:54:48 -0700 PDT InitContainerStatuses:[] ContainerStatuses:[{Name:client-can-connect-container State:{Waiting:nil Running:nil Terminated:&ContainerStateTerminated{ExitCode:1,Signal:0,Reason:Error,Message:,StartedAt:2017-07-25 15:54:49 -0700 PDT,FinishedAt:2017-07-25 15:54:57 -0700 PDT,ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57,}} LastTerminationState:{Waiting:nil Running:nil Terminated:nil} Ready:false RestartCount:0 Image:gcr.io/google_containers/redis:e2e ImageID:docker://sha256:e5e67996c442f903cda78dd983ea6e94bb4e542950fd2eba666b44cbd303df42 ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57}] QOSClass:BestEffort} not to have occurred ``` Failure message with this PR: ``` should support a 'default-deny' policy [Feature:NetworkPolicy] [It] /Users/gunjan/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/network_policy.go:81 Jul 25 14:35:55.978: Pod client-cannot-connect should be able to connect to service svc-server, but was not able to connect. Pod logs: Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80) wget: download timed out Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80) wget: download timed out Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80) wget: download timed out Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80) wget: download timed out Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80) wget: download timed out Current NetworkPolicies: [{{ } {deny-all e2e-tests-network-policy-tbzm8 /apis/networking.k8s.io/v1/namespaces/e2e-tests-network-policy-tbzm8/networkpolicies/deny-all 20fa92ab-7181-11e7-855b-42010a8a0003 87694 1 2017-07-25 14:35:07 -0700 PDT <nil> <nil> map[] map[] [] nil [] } {{map[] []} []}}] Pods: [Pod: server, Status: &PodStatus{Phase:Running,Conditions:[{Initialized True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT } {Ready True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:35:00 -0700 PDT } {PodScheduled True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT }],Message:,Reason:,HostIP:10.138.0.2,PodIP:10.60.1.145,StartTime:2017-07-25 14:34:52 -0700 PDT,ContainerStatuses:[{server-container-80 {nil ContainerStateRunning{StartedAt:2017-07-25 14:34:53 -0700 PDT,} nil} {nil nil nil} true 0 gcr.io/google_containers/porter:4524579c docker://sha256:711ccbc1c74f3417f2a0f403c194017b3bde09eec3c3b42dc9c838db3894c223 docker://3fa73da57380ef28520f8bbf53b3540f523ab76d45a1b42cc9a1e4573eb45639}],QOSClass:BestEffort,InitContainerStatuses:[],} Pod: server, Status: &PodStatus{Phase:Running,Conditions:[{Initialized True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT } {Ready True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:35:00 -0700 PDT } {PodScheduled True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT }],Message:,Reason:,HostIP:10.138.0.2,PodIP:10.60.1.145,StartTime:2017-07-25 14:34:52 -0700 PDT,ContainerStatuses:[{server-container-80 {nil ContainerStateRunning{StartedAt:2017-07-25 14:34:53 -0700 PDT,} nil} {nil nil nil} true 0 gcr.io/google_containers/porter:4524579c docker://sha256:711ccbc1c74f3417f2a0f403c194017b3bde09eec3c3b42dc9c838db3894c223 docker://3fa73da57380ef28520f8bbf53b3540f523ab76d45a1b42cc9a1e4573eb45639}],QOSClass:BestEffort,InitContainerStatuses:[],} ] ``` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Clean up in `cluster_size_autoscaling.go` **What this PR does / why we need it**: Fix `golint` errors. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [OpenStack]Add codes to check the count of nodes(members) After merging this PR(#53146), if there is no available nodes for the loadbalancer service, UpdateLoadBalancer() will run panic. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Address code-gen issue 7 nil pointer when incorrect pkg name **What this PR does / why we need it**: When using the code-gen tool, if the comments in the ```doc.go``` file has a misspelled pkg name, it ends with a nil pointer. This can be difficult to debug. This PR fixes that by logging an error and continuing. https://github.com/kubernetes/code-generator/issues/7 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: I was not sure whether just exiting here would be correct behaviour as reading the code , I noticed in other places it continues if the pkg is nil. Also perhaps I should use the ```glog.V(5).info``` ? ```release-note `NONE` ```
-
Chao Xu authored
-
Chao Xu authored
move k8s.io/kubernetes/plugin/pkg/admission/initialization to k8s.io/apiserver/pkg/admission/plugin/initialization/initialization.go; move k8s.io/kubernetes/pkg/kubeapiserver/admission/configuration to k8s.io/apiserver/pkg/admission/configuration.
-
Matt Liggett authored
Also set this flag for `bazel query` See #52677
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiextensions: add round trip tests for CRD schema conversion Follow up test for https://github.com/kubernetes/kubernetes/pull/52281. Need to update go-openapi to get this - https://github.com/go-openapi/spec/pull/31 - in. **Special notes for your reviewer**: The tests won't pass until https://github.com/kubernetes/kubernetes/pull/52281 is merged. **Release note**: ```release-note NONE ``` /cc @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add possibility to ignore volume label in dynamic provisioning **What this PR does / why we need it**: this is needed if openstack cinder zone name does not match to compute zone names. For instance if there is only one cinder zone and many compute zones. **Which issue this PR fixes**: fixes #53488 **Special notes for your reviewer**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve `horizontal.go` documentation **What this PR does / why we need it**: Resolve the remaining `golint` errors in the `pkg/controller/podautoscaler` package by improving the documentation in `horizontal.go`. Now all public methods have comments. **Special notes for your reviewer**: Re discussions in [this pr](https://github.com/kubernetes/kubernetes/pull/52238). **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add launching Cluster Autoscaler in Kubemark **What this PR does / why we need it**: Allows to launch Cluster Autoscaler in Kubemark. To do it, set ENABLE_KUBEMARK_CLUSTER_AUTOSCALER flag to true. This currently only works with one nodegroup, for which you can specify minimum and maximum number of nodes and name. (KUBEMARK_AUTOSCALER_MIN_NODES, KUBEMARK_AUTOSCALER_MAX_NODES, KUBEMARK_AUTOSCALER_MIG_NAME). Is is important to note that NUM_NODES has a different meaning when launching Cluster Autoscaler - we always start with only one node, but NUM_NODES is used to calculate the size of Kubemark master and addon components. There are no changes to the current setup if ENABLE_KUBEMARK_CLUSTER_AUTOSCALER is set to false. **Release note**: ``` NONE ```
-