1. 10 Oct, 2017 20 commits
  2. 09 Oct, 2017 20 commits
    • Brendan Burns's avatar
      Fix a typo. · 3cccf3b2
      Brendan Burns authored
      3cccf3b2
    • Kubernetes Submit Queue's avatar
      Merge pull request #51958 from deads2k/scheduler-03-typo · fcde4c9b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix annoying leader election typo
      
      Small typo that annoyed me. It expected `configmaps`
      fcde4c9b
    • Davanum Srinivas's avatar
      Fix potential problem when scaling --replicas=0 · 5690ba62
      Davanum Srinivas authored
      We have defensive code for checking if newRS != nil for
      DeploymentProgressing and DeploymentTimedOut but not for
      DeploymentComplete. Let's add the check here as well as
      this problem was seen in the wild.
      5690ba62
    • Michelle Au's avatar
      266120c1
    • Kubernetes Submit Queue's avatar
      Merge pull request #53599 from mml/query-incompatible-disallow · 175a6dee
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      query --incompatible_comprehension_variables_do_not_leak=false
      
      Also set this flag for `bazel query`
      
      See #52677
      
      ```release-note
      NONE
      ```
      
      /assign ixdy
      175a6dee
    • Kubernetes Submit Queue's avatar
      Merge pull request #53573 from dims/remove-auto-detect-as-default-for-kubelet · 8659623f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Do not set auto-detect cloud provider as the default in kubelet
      
      **What this PR does / why we need it**:
      
      This is part of the move to external cloud providers. Please see
      plan detail in issue 50986. This PR covers step 2:
       v1.9 - set no cloud provider as the default in kubelet but still allow
       opt in for auto-detect
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Fixes: https://github.com/kubernetes/kubernetes/issues/50986
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      kubelet's `--cloud-provider` flag no longer defaults to "auto-detect".  If you want cloud-provider support in kubelet, you must set a specific cloud-provider explicitly.
      ```
      8659623f
    • Kubernetes Submit Queue's avatar
      Merge pull request #53588 from NickrenREN/openstack-deletevolume · e8ee831a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Return err when delete volume failed
      
      Return err when delete volume failed
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /kind bug
      /sig openstack
      e8ee831a
    • Kubernetes Submit Queue's avatar
      Merge pull request #53547 from jiayingz/deviceplugin-fix · c12dab37
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      In DevicePluginHandlerImpl.Allocate(), skips untracked extended resou…
      
      …rces.
      
      Otherwise, we would fail a Pod allocation request that has an extended
      resource not managed by any device plugin.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      https://github.com/kubernetes/kubernetes/issues/53548
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Ignore extended resources that are not registered with kubelet
      ```
      c12dab37
    • Kubernetes Submit Queue's avatar
      Merge pull request #52662 from xiangpengzhao/volume-const · 3752a511
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52662, 53547, 53588, 53573, 53599). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use const instead of hard code for volume plugin
      
      **What this PR does / why we need it**:
      nits: cleanup hard-coded volume plugin name
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      3752a511
    • Kubernetes Submit Queue's avatar
      Merge pull request #49593 from gunjan5/np-e2e · c7f970c5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Refactor network policy e2e tests, and add additional logging when tests fail
      
      **What this PR does / why we need it**:
      - Restructure tests, clean up duplicate code
      - Add additional logging, so it's easier to debug when the tests fail
      - Add retry on the client side pods because sometimes kubelet will start the pod when the network is not ready, resulting in flaky tests
      - Add readiness probe for the server pods to further reduce the flakiness.
      
      Current failure messages when a test fails:
      ```
      checking client-can-connect could communicate with server.
        Expected error:
            <*errors.errorString | 0xc420868820>: {
                s: "pod \"client-can-connect\" failed with status: {Phase:Failed Conditions:[{Type:Initialized Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:} {Type:Ready Status:False LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:57 -0700 PDT Reason:ContainersNotReady Message:containers with unready status: [client-can-connect-container]} {Type:PodScheduled Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:}] Message: Reason: HostIP:10.138.0.2 PodIP:10.60.1.180 StartTime:2017-07-25 15:54:48 -0700 PDT InitContainerStatuses:[] ContainerStatuses:[{Name:client-can-connect-container State:{Waiting:nil Running:nil Terminated:&ContainerStateTerminated{ExitCode:1,Signal:0,Reason:Error,Message:,StartedAt:2017-07-25 15:54:49 -0700 PDT,FinishedAt:2017-07-25 15:54:57 -0700 PDT,ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57,}} LastTerminationState:{Waiting:nil Running:nil Terminated:nil} Ready:false RestartCount:0 Image:gcr.io/google_containers/redis:e2e ImageID:docker://sha256:e5e67996c442f903cda78dd983ea6e94bb4e542950fd2eba666b44cbd303df42 ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57}] QOSClass:BestEffort}",
            }
            pod "client-can-connect" failed with status: {Phase:Failed Conditions:[{Type:Initialized Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:} {Type:Ready Status:False LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:57 -0700 PDT Reason:ContainersNotReady Message:containers with unready status: [client-can-connect-container]} {Type:PodScheduled Status:True LastProbeTime:0001-01-01 00:00:00 +0000 UTC LastTransitionTime:2017-07-25 15:54:48 -0700 PDT Reason: Message:}] Message: Reason: HostIP:10.138.0.2 PodIP:10.60.1.180 StartTime:2017-07-25 15:54:48 -0700 PDT InitContainerStatuses:[] ContainerStatuses:[{Name:client-can-connect-container State:{Waiting:nil Running:nil Terminated:&ContainerStateTerminated{ExitCode:1,Signal:0,Reason:Error,Message:,StartedAt:2017-07-25 15:54:49 -0700 PDT,FinishedAt:2017-07-25 15:54:57 -0700 PDT,ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57,}} LastTerminationState:{Waiting:nil Running:nil Terminated:nil} Ready:false RestartCount:0 Image:gcr.io/google_containers/redis:e2e ImageID:docker://sha256:e5e67996c442f903cda78dd983ea6e94bb4e542950fd2eba666b44cbd303df42 ContainerID:docker://c91c33139672c20a5231bcba9437d74e12d35a6d19275b41bb8e571148b4ab57}] QOSClass:BestEffort}
        not to have occurred
      ```
      
      Failure message with this PR:
      ```
       should support a 'default-deny' policy [Feature:NetworkPolicy] [It]
          /Users/gunjan/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/network_policy.go:81
      
          Jul 25 14:35:55.978: Pod client-cannot-connect should be able to connect to service svc-server, but was not able to connect.
          Pod logs:
          Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80)
          wget: download timed out
          Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80)
          wget: download timed out
          Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80)
          wget: download timed out
          Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80)
          wget: download timed out
          Connecting to svc-server.e2e-tests-network-policy-tbzm8:80 (10.63.254.124:80)
          wget: download timed out
      
      
         Current NetworkPolicies:
          	[{{ } {deny-all  e2e-tests-network-policy-tbzm8 /apis/networking.k8s.io/v1/namespaces/e2e-tests-network-policy-tbzm8/networkpolicies/deny-all 20fa92ab-7181-11e7-855b-42010a8a0003 87694 1 2017-07-25 14:35:07 -0700 PDT <nil> <nil> map[] map[] [] nil [] } {{map[] []} []}}]
      
         Pods:
          	[Pod: server, Status: &PodStatus{Phase:Running,Conditions:[{Initialized True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT  } {Ready True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:35:00 -0700 PDT  } {PodScheduled True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT  }],Message:,Reason:,HostIP:10.138.0.2,PodIP:10.60.1.145,StartTime:2017-07-25 14:34:52 -0700 PDT,ContainerStatuses:[{server-container-80 {nil ContainerStateRunning{StartedAt:2017-07-25 14:34:53 -0700 PDT,} nil} {nil nil nil} true 0 gcr.io/google_containers/porter:4524579c docker://sha256:711ccbc1c74f3417f2a0f403c194017b3bde09eec3c3b42dc9c838db3894c223 docker://3fa73da57380ef28520f8bbf53b3540f523ab76d45a1b42cc9a1e4573eb45639}],QOSClass:BestEffort,InitContainerStatuses:[],}
           Pod: server, Status: &PodStatus{Phase:Running,Conditions:[{Initialized True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT  } {Ready True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:35:00 -0700 PDT  } {PodScheduled True 0001-01-01 00:00:00 +0000 UTC 2017-07-25 14:34:52 -0700 PDT  }],Message:,Reason:,HostIP:10.138.0.2,PodIP:10.60.1.145,StartTime:2017-07-25 14:34:52 -0700 PDT,ContainerStatuses:[{server-container-80 {nil ContainerStateRunning{StartedAt:2017-07-25 14:34:53 -0700 PDT,} nil} {nil nil nil} true 0 gcr.io/google_containers/porter:4524579c docker://sha256:711ccbc1c74f3417f2a0f403c194017b3bde09eec3c3b42dc9c838db3894c223 docker://3fa73da57380ef28520f8bbf53b3540f523ab76d45a1b42cc9a1e4573eb45639}],QOSClass:BestEffort,InitContainerStatuses:[],}
          ]
      ```
      **Release note**:
      
      ```release-note
      NONE
      ```
      c7f970c5
    • Kubernetes Submit Queue's avatar
      Merge pull request #52944 from mattjmcnaughton/mattjmcnaughton/clean-up-cluster_size_autoscaling · fb808183
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Clean up in `cluster_size_autoscaling.go`
      
      **What this PR does / why we need it**:
      
      Fix `golint` errors.
      
      **Release note**:
      ```release-note
      NONE
      ```
      fb808183
    • Kubernetes Submit Queue's avatar
      Merge pull request #53197 from FengyunPan/node-0 · 1dc1eb73
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      [OpenStack]Add codes to check the count of nodes(members)
      
      After merging this PR(#53146), if there is no available nodes for
      the loadbalancer service, UpdateLoadBalancer() will run panic.
      
      **Release note**:
      ```release-note
      NONE
      ```
      1dc1eb73
    • Kubernetes Submit Queue's avatar
      Merge pull request #53567 from maleck13/code-gen-nil-pointer-fix · bd9788f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53567, 53197, 52944, 49593). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Address code-gen issue 7 nil pointer when incorrect pkg name
      
      **What this PR does / why we need it**:
      When using the code-gen tool, if the comments in the ```doc.go``` file has a misspelled pkg name, it ends with a nil pointer. This can be difficult to debug. This PR fixes that by logging an error and continuing. 
      https://github.com/kubernetes/code-generator/issues/7
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      I was not sure whether just exiting here would be correct behaviour as reading the code , I noticed in other places it continues if the pkg is nil.
      Also perhaps I should use the ```glog.V(5).info```  ?
      
      ```release-note
      `NONE`
      ```
      bd9788f8
    • Chao Xu's avatar
      generated · bbac32c2
      Chao Xu authored
      bbac32c2
    • Chao Xu's avatar
      move initializer to the generic apiserver · 89a0511f
      Chao Xu authored
      move k8s.io/kubernetes/plugin/pkg/admission/initialization to
      k8s.io/apiserver/pkg/admission/plugin/initialization/initialization.go;
      move k8s.io/kubernetes/pkg/kubeapiserver/admission/configuration to
      k8s.io/apiserver/pkg/admission/configuration.
      89a0511f
    • Matt Liggett's avatar
      query --incompatible_comprehension_variables_do_not_leak=false · 67ca7a53
      Matt Liggett authored
      Also set this flag for `bazel query`
      
      See #52677
      67ca7a53
    • Kubernetes Submit Queue's avatar
      Merge pull request #52793 from nikhita/crd-validation-conversion-tests · e339400f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      apiextensions: add round trip tests for CRD schema conversion
      
      Follow up test for https://github.com/kubernetes/kubernetes/pull/52281.
      
      Need to update go-openapi to get this - https://github.com/go-openapi/spec/pull/31 - in.
      
      **Special notes for your reviewer**: The tests won't pass until https://github.com/kubernetes/kubernetes/pull/52281 is merged.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /cc @sttts
      e339400f
    • Kubernetes Submit Queue's avatar
      Merge pull request #53523 from zetaab/ignore_volume_label · 92210a7d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      add possibility to ignore volume label in dynamic provisioning
      
      **What this PR does / why we need it**: this is needed if openstack cinder zone name does not match to compute zone names. For instance if there is only one cinder zone and many compute zones.
      
      **Which issue this PR fixes**: fixes #53488
      
      **Special notes for your reviewer**: 
      
      ```release-note
      NONE
      ```
      92210a7d
    • Kubernetes Submit Queue's avatar
      Merge pull request #52985 from mattjmcnaughton/mattjmcnaughton/improve-horizontal-documentation · e7c61da1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Improve `horizontal.go` documentation
      
      **What this PR does / why we need it**:
      
      Resolve the remaining `golint` errors in the
      `pkg/controller/podautoscaler` package by improving the documentation
      in `horizontal.go`. Now all public methods have comments.
      
      **Special notes for your reviewer**:
      Re discussions in [this pr](https://github.com/kubernetes/kubernetes/pull/52238).
      
      **Release note**:
      ```release-note
      NONE
      ```
      e7c61da1
    • Kubernetes Submit Queue's avatar
      Merge pull request #53334 from bskiba/ca_km_clean · a3103ec9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add launching Cluster Autoscaler in Kubemark
      
      **What this PR does / why we need it**:
      Allows to launch Cluster Autoscaler in Kubemark. 
      To do it, set ENABLE_KUBEMARK_CLUSTER_AUTOSCALER flag to true. This currently only works with one nodegroup, for which you can specify minimum and maximum number of nodes and name. (KUBEMARK_AUTOSCALER_MIN_NODES, KUBEMARK_AUTOSCALER_MAX_NODES, KUBEMARK_AUTOSCALER_MIG_NAME).
      Is is important to note that NUM_NODES has a different meaning when launching Cluster Autoscaler - we always start with only one node, but NUM_NODES is used to calculate the size of Kubemark master and addon components.
      
      There are no changes to the current setup if ENABLE_KUBEMARK_CLUSTER_AUTOSCALER is set to false.
      
      **Release note**:
      ```
      NONE
      ```
      a3103ec9