- 15 Mar, 2017 27 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40964, 42967, 43091, 43115) Update hack scripts to use godep v79 and ensure_godep_version **What this PR does / why we need it**: Based on #42965 and https://github.com/kubernetes/kubernetes/pull/42958#discussion_r105568318, this pins the godep version at v79, which should fix some issues when running godep in go1.8 local environments. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42817 **Special notes for your reviewer**: This should likely get the v1.6 milestone so that it can be merged into master. While I'm setting a default godep version, I'm continuing to use the local pins per this comment: https://github.com/kubernetes/kubernetes/pull/42965#issuecomment-285962723 . **Release note**: ```release-note NONE ``` cc: @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40964, 42967, 43091, 43115) Improve code coverage for pkg/kubelet/status/generate.go **What this PR does / why we need it**: Improve code coverage for pkg/kubelet/status/generate.go from #39559 Thanks. **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Guarantee watch before action in e2e event observer helper function. **What this PR does / why we need it**: Adds a missing synchronization barrier to an e2e event observation helper function. - This change should guarantee that in observeEventAfterAction, the action is only executed after the informer begins watching the event stream. **Release note**: ```release-note NONE ``` cc @kubernetes/sig-scheduling-pr-reviews @bsalamat
-
Christoph Blecker authored
-
Christoph Blecker authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40404, 43134, 43117) Fix ES cluster logging test Fix #37324 Test was broken because fluentd-gcp now parses golang and fluentd-es doesn't
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40404, 43134, 43117) Add -p to mkdirs in gci-mounter function of gce configure.sh script Ref https://github.com/kubernetes/kubernetes/issues/40139#issuecomment-286068409 cc @wojtek-t
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40404, 43134, 43117) Improve code coverage for scheduler/api/validation **What this PR does / why we need it**: Improve code coverage for scheduler/api/validation from #39559 Thanks **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix Deployment upgrade test. **What this PR does / why we need it**: When the upgrade test operates on Deployments in a pre-1.6 cluster (i.e. during the Setup phase), it needs to use the v1.5 deployment/util logic. In particular, the v1.5 logic does not filter children to only those with a matching ControllerRef. **Which issue this PR fixes**: Fixes #42738 **Special notes for your reviewer**: **Release note**: ```release-note ``` cc @kubernetes/sig-apps-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43106, 43110) Wait for garbagecollector to be synced in test Fix #42952 Without the `cache.WaitForCacheSync` in the test, it's possible for the GC to get a merged event of RC's creation and its update (update to deletionTimestamp != 0), before GC gets the creation event of the pod, so it's possible the GC will handle the foreground deletion of the RC before it adds the Pod to the dependency graph, thus the race. With the `cache.WaitForCacheSync` in the test, because GC runs a single thread to process graph changes, it's guaranteed the Pod will be added to the dependency graph before GC handles the foreground deletion of the RC. Note that this pull fixes the race in the test. The race described in the first point of #26120 still exists.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43106, 43110) Bumped rescheduler version to 0.3.0 fix #32531 https://github.com/kubernetes/contrib/pull/2474 needs to be merged first cc @ethernetdan @marun @k82cn @aveshagarwal
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue add a compatibility shim for certs to support a cluster downgrade Fixes https://github.com/kubernetes/kubernetes/issues/42660
-
Piotr Szczesniak authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Retry calls to ReadFileViaContainer in PD tests **What this PR does / why we need it**: kubectl exec occasionally fails to return a valid output string. It seems to be an issue with docker #34256. This PR retries the 'kubectl exec' call to workaround the issue. This should fix the flaky PD test issues. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #28283 **Release note**: NONE
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42747, 43030) dockershim: remove corrupted sandbox checkpoints This is a workaround to ensure that kubelet doesn't block forever when the checkpoint is corrupted. This is a workaround for #43021
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42747, 43030) kube-proxy/iptables: optimize endpoint map creation by excluding invalid endpoints earlier We don't need to do as much work as we were doing, if we exclude invalid endpoints earlier in the endpoints processing. Fixes: https://github.com/kubernetes/kubernetes/issues/42210 @freehan @liggitt @thockin if you could review this with a fine-toothed comb... I can't immediately think of why invalid endpoints would be useful for the HealthChecker, and this PR prevents the HC from seeing these endpoints.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Deduplicate and consolidate contributing information to community repo * Move remaining community stuff out of kubernetes/kubernetes/README and CONTRIBUTING (to kubernets/community/README) so that there's only one thing to maintain. * Put self-contained things into their own MD files. * Have other docs point to those files rather than attempt to repeat their content. * Make all docs smaller. This PR is a companion to kubernetes/community#434 Closes kubernetes/community#420
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue dockershim: call sync() after writing the checkpoint This ensures the checkpoint files are persisted. This fixes #43021
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue vendor: Update github.com/evanphx/json-patch Regenerated files for https://github.com/kubernetes/kubernetes/pull/40387 Fixes #40218
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090) Add a timeout to allow replacement pod to become ready Hopefully fixes https://github.com/kubernetes/kubernetes/issues/37259 ``` I0314 04:26:02.562] Mar 14 04:26:02.562: INFO: Pod my-hostname-net-1bgrj still exists I0314 04:26:22.491] Mar 14 04:26:22.491: INFO: Waiting for pod my-hostname-net-1bgrj to disappear I0314 04:26:22.496] Mar 14 04:26:22.495: INFO: Pod my-hostname-net-1bgrj no longer exists I0314 04:26:22.496] STEP: verifying whether the pod from the unreachable node is recreated I0314 04:26:22.498] Mar 14 04:26:22.498: INFO: Pod name my-hostname-net: Found 3 pods out of 3 I0314 04:26:22.499] STEP: ensuring each pod is running I0314 04:26:22.499] STEP: trying to dial each unique pod I0314 04:26:22.579] Mar 14 04:26:22.579: INFO: Controller my-hostname-net: Got expected result from replica 1 [my-hostname-net-5jrdb]: "my-hostname-net-5jrdb", 1 of 3 required successes so far I0314 04:26:22.642] Mar 14 04:26:22.642: INFO: Controller my-hostname-net: Got expected result from replica 2 [my-hostname-net-mjf3c]: "my-hostname-net-mjf3c", 2 of 3 required successes so far I0314 04:31:22.645] Mar 14 04:31:22.644: INFO: Controller my-hostname-net: Failed to Get from replica 3 [my-hostname-net-rf46s]: Get https://35.184.87.178/api/v1/namespaces/e2e-tests-network-partition-s5gqt/pods/my-hostname-net-rf46s/proxy/: context deadline exceeded ``` The issue appears to be that we have a race between the pod being "running + ready" and being accessible via the APIServer proxy. cc @kow3ns @bowei @davidopp
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090) Move e2e sched event predicates to new file. **What this PR does / why we need it**: Small e2e test refactor for scheduler. Moves scheduler event predicates out of opaque_resource.go for reuse elsewhere. **Release note**: ```release-note NONE ``` cc @kubernetes/sig-scheduling-pr-reviews @timothysc @bsalamat
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090) Update ScaleIO volume plugin default readOnly value This commit updates the code to set readOnly attribute to be set to false. **What this PR does / why we need it**: This PR is a minor fix that updates the default value of `readOnly` attribute to `false`. **Release note**: ```release-note NONE ```
-
Yu-Ju Hong authored
This ensures the checkpoint files are persisted.
-
Mikhail Vyatskov authored
-
Anthony Yeh authored
When the upgrade test operates on Deployments in a pre-1.6 cluster (i.e. during the Setup phase), it needs to use the v1.5 deployment/util logic. In particular, the v1.5 logic does not filter children to only those with a matching ControllerRef.
-
Anirudh authored
-
- 14 Mar, 2017 13 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43018, 42713, 42819) Update startup scripts for kube-dns ConfigMap and ServiceAccount Follow up PR of #42757. This PR changes all existing startup scripts to support default kube-dns ConfigMap and ServiceAccount. @bowei cc @liggitt **Release note**: ```release-note NONE ```
-
Chao Xu authored
-
Connor Doyle authored
- This change should guarantee that in observeEventAfterAction, the action is only executed after the informer begins watching the event stream.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43018, 42713) kubeadm: Don't drain and remove the current node on kubeadm reset **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: In v1.5, `kubeadm reset` would drain your node and remove it from your cluster if you specified, but now in v1.6 we can't do that due to the RBAC rules we have set up. After conversations with @liggitt, I also agree this functionality was somehow a little mis-placed (though still very convenient to use), so we're removing it for v1.6. It's the system administrator's duty to drain and remove nodes from the cluster, not the nodes' responsibility. The current behavior is therefore a bug that needs to be fixed in v1.6 **Release note**: ```release-note kubeadm: `kubeadm reset` won't drain and remove the current node anymore ``` @liggitt @deads2k @jbeda @dmmcquay @pires @errordeveloper
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43018, 42713) Log instead of fail on GLBCs tendency to leak resources **What this PR does / why we need it**: Stops upgrade tests from flaking because the GLBC does not cleanup all resources due to a race condition. **Which issue this PR fixes**: fixes #38569 **Special notes for your reviewer**: To be reviewed by @mml ```release-note NONE ```
-
Connor Doyle authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42775, 42991, 42968, 43029) Add e2e test for Deployment controllerRef orphaning and adoption Follow up #42908 @enisoc @kubernetes/sig-apps-bugs @kargakis
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42775, 42991, 42968, 43029) Initial breakout of scheduling e2es to help assist in assignment and refactoring **What this PR does / why we need it**: This PR segregates the scheduling specific e2es to isolate the library which will assist both in refactoring but also auto-assignment of issues. **Which issue this PR fixes** xref: https://github.com/kubernetes/kubernetes/issues/42691#issuecomment-285563265 **Special notes for your reviewer**: All this change does is shuffle code around and quarantine. Behavioral, and other cleanup changes, will be in follow on PRs. As of today, the e2es are a monolith and there is massive symbol pollution, this 1st step allows us to segregate the e2es and tease apart the dependency mess. **Release note**: ``` NONE ``` /cc @kubernetes/sig-scheduling-pr-reviews @kubernetes/sig-testing-pr-reviews @marun @skriss /cc @gmarek - same trick for load + density, etc.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42775, 42991, 42968, 43029) Remove 'beta' from default storage class annotation I forgot to update default storage class annotation in my storage.k8s.io/v1beta1 -> v1 PRs. Let's fix it before 1.6 is released. I consider it as a bugfix, in #40088 I already updated the release notes to include non-beta annotation `storageclass.kubernetes.io/is-default-class` ```release-note NONE ``` @kubernetes/sig-storage-pr-reviews @msau42, please help with merging.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 42775, 42991, 42968, 43029) `kubectl taint` update for `NoExecute`. **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Fixes #42774 **Release note**: ```release-note ```
-
Mikkel Oscar Lyderik Larsen authored
Updates github.com/evanphx/json-patch dependency to a version that doesn't crash when handling an invalid json patch. Includes fix from https://github.com/evanphx/json-patch/pull/35 Fix #40218
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add DaemonSet templateGeneration validation and tests, and fix a bunch of validation test errors For DaemonSet update: 1. Validate that templateGeneration is increased when and only when template is changed 1. Validate that templateGeneration is never decreased 1. Added validation tests for templateGeneration 1. Fix a bunch of errors in validate tests - fake tests: almost all validation test error cases failed on "missing resource version", "name changes", "missing update strategy", "selector/template labels mismatch", not on the real validation we wanted to test - some error cases should be success cases @kargakis @lukaszo @kubernetes/sig-apps-bugs *I've verified locally that all DaemonSet e2e tests pass with this change.*
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43034, 43066) Fix StatefulSet apps e2e tests Fixes https://github.com/kubernetes/kubernetes/issues/42490 ```release-note NONE ``` cc @kubernetes/sig-apps-bugs
-