1. 31 Jul, 2018 9 commits
    • Shyam Jeedigunta's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #66691 from spiffxp/default-unbound-cluster-gce-vars · 05acb32a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Default some unbound cluster/gce env vars
      
      **What this PR does / why we need it**:
      
      Sets defaults for two env vars used by cluster/gce/* scripts so as to
      avoid the following warnings when bringing a cluster up for test
      ```
      METADATA_CONCEALMENT_NO_FIREWALL: unbound variable
      CUSTOM_KUBE_DASHBOARD_BANNER: unbound variable
      ```
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #60850
      
      ```release-note
      NONE
      ```
      05acb32a
    • Kubernetes Submit Queue's avatar
      Merge pull request #66694 from spiffxp/dd-status-none · 10688257
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      dd status=none does not exist on macOS
      
      **What this PR does / why we need it**:
      
      When running cluster/kubectl.sh on macOS 10.13.6, the use of the
      `status=none` operand leads to `dd: unknown operand status` being
      printed out as an error message. Redirecting to /dev/null does
      the same thing, supressing transfer status.
      
      ```release-note
      NONE
      ```
      10688257
    • Kubernetes Submit Queue's avatar
      Merge pull request #66690 from spiffxp/verify-no-libressl · 1b6a5054
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66284, 66690). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Exit gce kube-up.sh early if openssl is LibreSSL
      
      **What this PR does / why we need it**:
      
      macOS has an openssl binary, but it's actually LibreSSL, which doesn't play well with the easyrsa script that cluster/gce/util.sh uses to generate certs
      
      Instead of waiting until we generate certs to discover easyrsa doesn't work, consider openssl a prereq for gce, and include a check for the version string starting with OpenSSL
      
      Also, mirror kube-up.sh's "... calling" output in kube-down.sh
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes kubernetes/community#1954
      
      ```release-note
      NONE
      ```
      1b6a5054
    • Kubernetes Submit Queue's avatar
      Merge pull request #66284 from stewart-yu/stewart-sharedtype-move · 2bee858a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Move the` k8s.io/kubernetes/pkg/util/pointer` package to` k8s.io/utils/pointer`
      
      **What this PR does / why we need it**:
      Move `k8s.io/kubernetes/pkg/util/pointer` to  `shared utils` directory, so that we can use it  easily.
      Close #66010 accidentally, and can't reopen it, so the same as #66010 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      2bee858a
    • Kubernetes Submit Queue's avatar
      Merge pull request #66734 from stewart-yu/stewart-e2e-badoutput · d78f4911
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix wrong format output in e2e log
      
      **What this PR does / why we need it**:
      When i run e2e, occuring  some  output log as below:
      ```
      STEP: Creating pod1
      STEP: Creating a pod
      Jul 28 14:09:12.876: INFO: pod "security-context-bd6750a8-922c-11e8-abe9-286ed488d743" created on Node "127.0.0.1"
      Jul 28 14:09:12.876: INFO: Running '/usr/local/bin/kubectl --server=http://127.0.0.1:8080 --kubeconfig=/var/run/kubernetes/admin.kubeconfig exec --namespace=e2e-tests-persistent-local-volumes-test-dlbf7 security-context-bd6750a8-922c-11e8-abe9-286ed488d743 -- /bin/sh -c cat /mnt/volume1/test-file'
      Jul 28 14:09:13.119: INFO: stderr: ""
      Jul 28 14:09:13.119: INFO: stdout: "test-file-content\n"
      Jul 28 14:09:13.119: INFO: podRWCmdExec out: "test-file-content\n" err: %!q(<nil>)
      STEP: Writing in pod1
      Jul 28 14:09:13.119: INFO: Running '/usr/local/bin/kubectl --server=http://127.0.0.1:8080 --kubeconfig=/var/run/kubernetes/admin.kubeconfig exec --namespace=e2e-tests-persistent-local-volumes-test-dlbf7 security-context-bd6750a8-922c-11e8-abe9-286ed488d743 -- /bin/sh -c mkdir -p /mnt/volume1; echo /tmp/local-volume-test-b97fe819-922c-11e8-abe9-286ed488d743 > /mnt/volume1/test-file'
      Jul 28 14:09:13.331: INFO: stderr: ""
      Jul 28 14:09:13.331: INFO: stdout: ""
      Jul 28 14:09:13.331: INFO: podRWCmdExec out: "" err: %!q(<nil>)
      STEP: Deleting pod1
      STEP: Deleting pod security-context-bd6750a8-922c-11e8-abe9-286ed488d743 in namespace e2e-tests-persistent-local-volumes-test-dlbf7
      STEP: Creating pod2
      STEP: Creating a pod
      ```
      the `podRWCmdExec out: "" err: %!q(<nil>)` line are wrong
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      d78f4911
    • Kubernetes Submit Queue's avatar
      Merge pull request #66739 from islinwb/ipvs_mods_check · 24fa5edb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66489, 66728, 66739). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove incomplete check of ipvs modules in hack/local-up-cluster.sh
      
      **What this PR does / why we need it**:
      Currently `hack/local-up-cluster.sh` executes `sudo modprobe -a ip_vs ip_vs_rr ip_vs_wrr ip_vs_sh nf_conntrack_ipv4` to check whether the ipvs required modules exist, which leaves out the scenario https://github.com/kubernetes/kubernetes/issues/63801 mentioned.
      Since `func CanUseIPVSProxier` in  `pkg/proxy/ipvs/proxier.go` covers all scenarios, maybe we should just remove this part instead of adding codes.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      24fa5edb
    • Kubernetes Submit Queue's avatar
      Merge pull request #66728 from gnufied/fix-volume-modifition-aws · 1f8b3fde
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66489, 66728, 66739). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Speed up volume modifications on AWS
      
      Volume becomes reusable after it reached optimizing state.
      
      /sig storage
      /sig aws
      
      
      ```release-note
      Make EBS volume expansion faster
      ```
      
      cc @d-nishi @kokhang
      1f8b3fde
    • Kubernetes Submit Queue's avatar
      Merge pull request #66489 from tanshanshan/todoclean · 1b9cc581
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66489, 66728, 66739). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Reuse iptablesContainerPortalArgs, remove function iptablesContainerNodePortArgs
      
      **What this PR does / why we need it**:
      
      reuse iptablesContainerPortalArgs, remove function iptablesContainerNodePortArgs
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      1b9cc581
  2. 30 Jul, 2018 5 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #65948 from figo/stateless · 742a90cb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Simplify device manager: make endpoint stateless
      
      While reviewing devicemanager code, found the caching layer on endpoint is redundant.
      Here are the 3 related objects in picture:
      
      **devicemanager  <->  endpoint <-> plugin**
      
      plugin is the source of truth for devices and device health status.
      devicemanager maintain healthyDevices, unhealthyDevices, allocatedDevices based on updates
      from plugin.
      
      So there is no point for endpoint to cache devices, this patch is removing the cache layer,
      endpoint becomes stateless, which i believe should be the case (but i do welcome review
      if i missed something here).
      
      also removing the Manager.Devices() since i didn't find any caller of this other than test.
      
      if we need to get all devices from manager in future, it just need to return healthyDevices + unhealthyDevices, so don't have to call endpoint after all.
      
      This patch makes code more readable, data model been simplified.
      
      
      
      **What this PR does / why we need it**:
      this patch simplify the device manager code, make it more maintainable.
      
      **Which issue(s) this PR fixes** *:
      this is a refactor of device manager code
      
      **Special notes for your reviewer**:
      will need to rebase the code if #58755 get checked-in first.
      
      **Release note**:
      
      ```release-note
      None
      ```
      
      /sig node
      /cc @jiayingz @RenaudWasTaken @vishh @saad-ali @vikaschoudhary16 @vladimirvivien @anfernee
      742a90cb
    • Kubernetes Submit Queue's avatar
      Merge pull request #66760 from tanshanshan/e2e-error · a934499c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66686, 66760). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Error in return value should be tested
      
      **What this PR does / why we need it**:
      Error in return value should be tested
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a934499c
    • Kubernetes Submit Queue's avatar
      Merge pull request #66686 from dims/test-image-for-a-release-1.7-based-sample-apiserver · 5ef6a6a2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      test image for a release 1.7 based sample-apiserver
      
      **What this PR does / why we need it**:
      In our e2e test suite we have use an image "gcr.io/kubernetes-e2e-test-images:k8s-aggregator-sample-apiserver:1.7v2". We need a way to build a fresh image that can we can use instead of that one. Especially we need one that has a multi-arch fat manifest so e2e tests can be run across multiple architectures.
      
      This is especially important since we are in the process of promoting the test in question to the conformance suite - https://github.com/kubernetes/kubernetes/pull/63947
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      /cc @mkumatag 
      /cc @ixdy 
      /cc @luxas 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      5ef6a6a2
    • tanshanshan's avatar
      error in return value should be tested · af0fc11d
      tanshanshan authored
      af0fc11d
    • hui luo's avatar
      While reviewing devicemanager code, found · 7101c174
      hui luo authored
      the caching layer on endpoint is redundant.
      
      Here are the 3 related objects in picture:
      devicemanager <-> endpoint <-> plugin
      
      Plugin is the source of truth for devices
      and device health status.
      
      devicemanager maintain healthyDevices,
      unhealthyDevices, allocatedDevices based on updates
      from plugin.
      
      So there is no point for endpoint caching devices,
      this patch is removing this caching layer on endpoint,
      
      Also removing the Manager.Devices() since i didn't
      find any caller of this other than test, i am adding a
      notification channel to facilitate testing,
      
      If we need to get all devices from manager in future,
      it just need to return healthyDevices + unhealthyDevices,
      we don't have to call endpoint after all.
      
      This patch makes code more readable, data model been simplified.
      7101c174
  3. 28 Jul, 2018 14 commits
  4. 27 Jul, 2018 12 commits