- 28 Jun, 2017 1 commit
-
-
Christopher M. Luciano authored
GPU support is ramping up and we do not have a lot of reviewers that are familiar with the codebase. I added myself as a reviewer and copied a few people from the kubelet OWNERS file as approvers. Signed-off-by:Christopher M. Luciano <cmluciano@us.ibm.com>
-
- 30 May, 2017 39 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fixtypo **What this PR does / why we need it**: fix typo seperated -> separated **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946) Allow PSP's to specify a whitelist of allowed paths for host volume **What this PR does / why we need it**: This PR adds the ability to whitelist paths for the host volume to ensure pods cannot access directories they aren't supposed to. E.g. `/var/lib/kubelet`, `/etc/kubernetes/*`, etc. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #29326 **Special notes for your reviewer**: **Release note**: ```release-note Allow PSP's to specify a whitelist of allowed paths for host volume based on path prefixes ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946) Add `kubectl config rename-context` Add `kubectl config rename-context` This command allows renaming a context, instead of editing manually in .kubeconfig Fix https://github.com/kubernetes/kubernetes/issues/45131 ```release-note Add `kubectl config rename-context` ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946) AWS: consider instances of all states in DisksAreAttached, not just "running" Require callers of `getInstancesByNodeNames(Cached)` to specify the states they want to filter instances by, if any. DisksAreAttached, cannot only get "running" instances because of the following attach/detach bug we discovered: 1. Node A stops (or reboots) and stays down for x amount of time 2. Kube reschedules all pods to different nodes; the ones using ebs volumes cannot run because their volumes are still attached to node A 3. Verify volumes are attached check happens while node A is down 4. Since aws ebs bulk verify filters by running nodes, it assumes the volumes attached to node A are detached and removes them all from ASW 5. Node A comes back; its volumes are still attached to it but the attach detach controller has removed them all from asw and so will never detach them even though they are no longer desired on this node and in fact desired elsewhere 6. Pods cannot run because their volumes are still attached to node A So the idea here is to remove the wrong assumption that callers of `getInstancesByNodeNames(Cached)` only want "running" nodes. I hope this isn't too confusing, open to alternative ways of fixing the bug + making the code nice. ping @gnufied @kubernetes/sig-storage-bugs ```release-note Fix AWS EBS volumes not getting detached from node if routine to verify volumes are attached runs while the node is down ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946) add error info **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946) De-duplication of verb in policy.go **What this PR does / why we need it**: https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go#L224 contains `get` verb. **Which issue this PR fixes**: **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Move hardPodAffinitySymmetricWeight to scheduler policy config **What this PR does / why we need it**: Move hardPodAffinitySymmetricWeight to scheduler policy config **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43845 **Special notes for your reviewer**: If you like this, will add test later **Release note**: ``` Move hardPodAffinitySymmetricWeight from KubeSchedulerConfiguration to scheduler Policy config ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Support storageclass storage updates to v1 **What this PR does / why we need it**: enable cluster administrators to update storageclasses stored in etcd from storage.k8s.io/v1beta1 to storage.k8s.io/v1. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: I had a hard time getting the test to work with how it was handling KUBE_API_VERSIONS and RUNTIME_CONFIG. I would appreciate some extra review attention there. Also, I had to hack in a `cluster-scoped` "namespace" to get the verification portions of the test script to work. I'm definitely open to ideas for how to improve that if needed. **Release note**: ```release-note Support updating storageclasses in etcd to storage.k8s.io/v1. You must do this prior to upgrading to 1.8. ``` cc @kubernetes/sig-storage-pr-reviews @kubernetes/sig-api-machinery-pr-reviews @jsafrane @deads2k @saad-ali @enj
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459) Move admission lifecycle to genericapi **What this PR does / why we need it**: ends the whole sequence of moving some admission plugins to generic api. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459) Make kubemark scripts fail fast Fixes https://github.com/kubernetes/kubernetes/issues/46601 /cc @wojtek-t @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459) Require DeleteStrategy for all registry.Store **What this PR does / why we need it**: All `registry.Store` objects already set a non-nil `DeleteStrategy`. This change ensures that all future objects do so as well. Signed-off-by:Monis Khan <mkhan@redhat.com> xref: #24153 openshift/origin/issues/14198 cc @deads2k @liggitt @caesarxuchao @lavalamp @smarterclayton @derekmahar In regards to this, why is the `RESTDeleteStrategy` a useless interface (as far as deletion goes)? We cast it to `GarbageCollectionDeleteStrategy` or `RESTGracefulDeleteStrategy` in an attempt to do operations related to deletion, but we have "default" behavior for both of those cases. It should be possible to make `DeleteStrategy` optional by using the other strategies as the `runtime.ObjectTyper` and then defaulting a `nil` `DeleteStrategy` with the expected behavior. ```go // RESTDeleteStrategy defines deletion behavior on an object that follows Kubernetes // API conventions. type RESTDeleteStrategy interface { runtime.ObjectTyper } type GarbageCollectionPolicy string const ( DeleteDependents GarbageCollectionPolicy = "DeleteDependents" OrphanDependents GarbageCollectionPolicy = "OrphanDependents" ) // GarbageCollectionDeleteStrategy must be implemented by the registry that wants to // orphan dependents by default. type GarbageCollectionDeleteStrategy interface { // DefaultGarbageCollectionPolicy returns the default garbage collection behavior. DefaultGarbageCollectionPolicy() GarbageCollectionPolicy } // RESTGracefulDeleteStrategy must be implemented by the registry that supports // graceful deletion. type RESTGracefulDeleteStrategy interface { // CheckGracefulDelete should return true if the object can be gracefully deleted and set // any default values on the DeleteOptions. CheckGracefulDelete(ctx genericapirequest.Context, obj runtime.Object, options *metav1.DeleteOptions) bool } ``` **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459) Fixes kubectl cached discovery on Windows Fixes https://github.com/kubernetes/kubectl/issues/18 The `kubectl` cached discovery makes use of `func (f *File) Chmod(mode FileMode) error` which is not supported and errors out on Windows, making `kubectl get` and potentially a number of other commands to fail miserably on that platform. `os.Chmod` by file name, on the other hand, does not error out and should be used instead. **Release note**: ```release-note NONE ``` @deads2k @brendandburns @kubernetes/sig-cli-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue gcloud command syntax changed between alpha and beta versions syntax for secondary-ranges changed from: name=NAME,range=RANGE to NAME=RANGE
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525) move CustomResourceDefinitions from alpha to beta CRDs are built upon the known ThirdPartyResource API with the lessons learned guiding the new shape. Short comings of the old TPR API even have specific tests to ensure that CRDs do not face the same issues. Given that, this API qualifies for beta. These are straight mechanical changes. @kubernetes/sig-api-machinery-misc @ericchiang You asked about this in the original pull.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525) fix typo in taint_controller **What this PR does / why we need it**: fix typo in taint_controller **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**:
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525) Export ErrWatchClosed from watch.Until This is needed so that users of watch.Until may check for this particular error instead of attempting to match the error string.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525) add unit for freed image size **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525) Fix typo **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue use make slice to store objects to improve efficiency Signed-off-by:allencloud <allen.sun@daocloud.io> **What this PR does / why we need it**: we we know the slice length in advance, I think we had better use make to create the specified length of slice. This will improve some kind of performance. Since if we create a slice with []type{}, we did not know how much space runtime should reserve, since slice implementation should be continuous in memory. While when we make a slice with specified length, runtime would reserve a continuous memory space which will not result in slice movement in case of current space is not enough. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue delete unreachable code Signed-off-by:yupengzte <yu.peng36@zte.com.cn> **What this PR does / why we need it**: After panic, the code is unreachable,delete them. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubelet: remove a redundant check for mounting the hosts file HostNetwork is not part of the Pod.Spec.SecurityContext in the versioned pod. Remove the redundant check. See https://github.com/kubernetes/kubernetes/issues/43632#issuecomment-304370330 for the explanation.
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) Speed up and reduce number of memory allocations in kube-proxy This is a second (and last PR) in this series - this solves all very-low-hanging fruits. This PR: - reduces cpu usage by ~25% - reduces memory allocations by ~3x (together with #46033 by 10-12x) Without this PR: ``` (pprof) top 8.59GB of 8.79GB total (97.75%) Dropped 238 nodes (cum <= 0.04GB) Showing top 10 nodes out of 64 (cum >= 0.11GB) flat flat% sum% cum cum% 3.66GB 41.60% 41.60% 8.72GB 99.17% k8s.io/kubernetes/pkg/proxy/iptables.(*Proxier).syncProxyRules 3.07GB 34.96% 76.56% 3.07GB 34.96% runtime.rawstringtmp 0.62GB 7.09% 83.65% 0.62GB 7.09% runtime.hashGrow 0.34GB 3.82% 87.46% 0.34GB 3.82% runtime.stringtoslicebyte 0.29GB 3.24% 90.71% 0.58GB 6.61% encoding/base32.(*Encoding).EncodeToString 0.22GB 2.47% 93.18% 0.22GB 2.47% strings.genSplit 0.18GB 2.04% 95.22% 0.18GB 2.04% runtime.convT2E 0.11GB 1.22% 96.44% 0.73GB 8.36% runtime.mapassign 0.10GB 1.08% 97.52% 0.10GB 1.08% syscall.ByteSliceFromString 0.02GB 0.23% 97.75% 0.11GB 1.25% syscall.SlicePtrFromStrings ``` with this PR: ``` (pprof) top 2.98GB of 3.08GB total (96.78%) Dropped 246 nodes (cum <= 0.02GB) Showing top 10 nodes out of 70 (cum >= 0.10GB) flat flat% sum% cum cum% 1.99GB 64.60% 64.60% 1.99GB 64.60% runtime.rawstringtmp 0.58GB 18.95% 83.55% 0.58GB 18.95% runtime.hashGrow 0.10GB 3.40% 86.95% 0.69GB 22.47% runtime.mapassign 0.09GB 2.86% 89.80% 0.09GB 2.86% syscall.ByteSliceFromString 0.08GB 2.63% 92.44% 0.08GB 2.63% runtime.convT2E 0.03GB 1.13% 93.56% 0.03GB 1.13% syscall.Environ 0.03GB 0.99% 94.56% 0.03GB 0.99% bytes.makeSlice 0.03GB 0.97% 95.52% 0.03GB 1.06% os.Stat 0.02GB 0.65% 96.18% 3.01GB 97.79% k8s.io/kubernetes/pkg/proxy/iptables.(*Proxier).syncProxyRules 0.02GB 0.6% 96.78% 0.10GB 3.35% syscall.SlicePtrFromStrings ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) [e2e]Fix define redundant parameter When timeout to reach HTTP service, redundant parameter make the error is nil.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) Add unversioned.MicroTime type Ref. #36752 cc @smarterclayton @wojtek-t @dchen1107 @timothysc @bgrant0607
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) check err Signed-off-by:yupengzte <yu.peng36@zte.com.cn> **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) Make log-monitor give up on trying to ssh to a dead node after some time Fix #38263
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) add test for set image validation **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) Add Unit Test:describe configmap **What this PR does / why we need it**: Add Unit Test:describe configmap **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) fmt.Errorf replaces errors **What this PR does / why we need it**: fmt.Errorf replaces errors importing errors is redundant. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) Fix screwed-up log message format It had two %-verbs and three arguments **What this PR does / why we need it**: Fixes kubelet log lines like this: May 08 11:49:04 brya-1 kubelet[23248]: W0508 11:49:04.248123 23248 eviction_manager.go:128] Failed to admit pod kube-proxy-g3hjs_kube-system(55c1fbbb-33e4-11e7-b83c-42010a800002) - node has conditions: %v%!(EXTRA []v1.NodeConditionType=[MemoryPressure]) to remove the `%v%!(EXTRA` **Release note**: ```release-note NONE ``` -
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46561, 46566) Fix golint errors in cmd/kube-apiserver **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46561, 46566) Return nil when err is nil **What this PR does / why we need it**: Return nil directly when err is nil **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) Matches single without selector This is reducing cpu-usage of apiserver by ~5% in 5000-node clusters.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) ommitting close file while testing manifest ommitting close file while testing manifest.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) Fix comment typo in kube-apiserver and cachesize **What this PR does / why we need it**: Fix comment typo in files cmd/kube-apiserver/app/server.go and pkg/registry/cachesize/cachesize.go **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Not a major issue, just a minor improvement. **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) fix some typo **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Wojciech Tyczynski authored
-