1. 28 Jun, 2017 1 commit
  2. 30 May, 2017 39 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #46165 from x1957/kubelet · 052cd6d3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fixtypo 
      
      **What this PR does / why we need it**:
      fix typo seperated -> separated
      
      **Release note**:
      
      ```release-note
      None
      ```
      052cd6d3
    • Kubernetes Submit Queue's avatar
      Merge pull request #43946 from jhorwit2/jah/host-path-psp · b5eadb5d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)
      
      Allow PSP's to specify a whitelist of allowed paths for host volume
      
      **What this PR does / why we need it**:
      
      This PR adds the ability to whitelist paths for the host volume to ensure pods cannot access directories they aren't supposed to. E.g. `/var/lib/kubelet`, `/etc/kubernetes/*`, etc. 
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #29326
      
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Allow PSP's to specify a whitelist of allowed paths for host volume based on path prefixes
      ```
      b5eadb5d
    • Kubernetes Submit Queue's avatar
      Merge pull request #46114 from arthur0/rename_context · 1889d654
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)
      
      Add `kubectl config rename-context`
      
      Add `kubectl config rename-context`
      
      This command allows renaming a context, instead of editing manually in .kubeconfig
      
      Fix https://github.com/kubernetes/kubernetes/issues/45131
      
      ```release-note
      Add `kubectl config rename-context`
      ```
      1889d654
    • Kubernetes Submit Queue's avatar
      Merge pull request #46463 from wongma7/getinstances · 222d2474
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)
      
      AWS: consider instances of all states in DisksAreAttached, not just "running"
      
      Require callers of `getInstancesByNodeNames(Cached)` to specify the states they want to filter instances by, if any. DisksAreAttached, cannot only get "running" instances because of the following attach/detach bug we discovered:
      
      1. Node A stops (or reboots) and stays down for x amount of time
      2. Kube reschedules all pods to different nodes; the ones using ebs volumes cannot run because their volumes are still attached to node A
      3. Verify volumes are attached check happens while node A is down
      4. Since aws ebs bulk verify filters by running nodes, it assumes the volumes attached to node A are detached and removes them all from ASW
      5. Node A comes back; its volumes are still attached to it but the attach detach controller has removed them all from asw and so will never detach them even though they are no longer desired on this node and in fact desired elsewhere
      6. Pods cannot run because their volumes are still attached to node A
      
      So the idea here is to remove the wrong assumption that callers of `getInstancesByNodeNames(Cached)` only want "running" nodes.
      
      I hope this isn't too confusing, open to alternative ways of fixing the bug + making the code nice.
      
      ping @gnufied @kubernetes/sig-storage-bugs
      
      ```release-note
      Fix AWS EBS volumes not getting detached from node if routine to verify volumes are attached runs while the node is down
      ```
      222d2474
    • Kubernetes Submit Queue's avatar
      Merge pull request #46281 from zjj2wry/err · 69c4a8ff
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)
      
      add error info
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      69c4a8ff
    • Kubernetes Submit Queue's avatar
      Merge pull request #46489 from xilabao/de-duplication-of-verb · 61693bf6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)
      
      De-duplication of verb in policy.go
      
      **What this PR does / why we need it**:
      https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go#L224 contains `get` verb. 
      
      **Which issue this PR fixes**:
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      None
      ```
      61693bf6
    • Kubernetes Submit Queue's avatar
      Merge pull request #44159 from wanghaoran1988/fix_43845 · 657c01c6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Move hardPodAffinitySymmetricWeight to scheduler policy config
      
      **What this PR does / why we need it**:
      Move hardPodAffinitySymmetricWeight to scheduler policy config
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43845 
      
      **Special notes for your reviewer**:
      If you like this, will add test later
      **Release note**:
      ```
      Move hardPodAffinitySymmetricWeight from KubeSchedulerConfiguration to scheduler Policy config
      ```
      657c01c6
    • Kubernetes Submit Queue's avatar
      Merge pull request #46116 from ncdc/storageclass-etcd-upgrade · d621ebce
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Support storageclass storage updates to v1
      
      **What this PR does / why we need it**: enable cluster administrators to update storageclasses stored in etcd from storage.k8s.io/v1beta1 to storage.k8s.io/v1. 
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**: I had a hard time getting the test to work with how it was handling KUBE_API_VERSIONS and RUNTIME_CONFIG. I would appreciate some extra review attention there. Also, I had to hack in a `cluster-scoped` "namespace" to get the verification portions of the test script to work. I'm definitely open to ideas for how to improve that if needed.
      
      **Release note**:
      
      ```release-note
      Support updating storageclasses in etcd to storage.k8s.io/v1. You must do this prior to upgrading to 1.8.
      ```
      
      cc @kubernetes/sig-storage-pr-reviews @kubernetes/sig-api-machinery-pr-reviews @jsafrane @deads2k @saad-ali @enj
      d621ebce
    • Kubernetes Submit Queue's avatar
      Merge pull request #46459 from p0lyn0mial/move_admission_lifecycle_to_genericapi · cb201802
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459)
      
      Move admission lifecycle to genericapi
      
      **What this PR does / why we need it**:  ends the whole sequence of moving some admission plugins to generic api.
      
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      cb201802
    • Kubernetes Submit Queue's avatar
      Merge pull request #46605 from shyamjvs/fix-perfdata-subresource · 36548b07
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459)
      
      Make kubemark scripts fail fast
      
      Fixes https://github.com/kubernetes/kubernetes/issues/46601
      
      /cc @wojtek-t @gmarek
      36548b07
    • Kubernetes Submit Queue's avatar
      Merge pull request #46390 from enj/enj/i/require_delete_strategy · 82f24cee
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459)
      
      Require DeleteStrategy for all registry.Store
      
      **What this PR does / why we need it**:
      
      All `registry.Store` objects already set a non-nil `DeleteStrategy`.  This change ensures that all future objects do so as well.
      Signed-off-by: 's avatarMonis Khan <mkhan@redhat.com>
      
      xref: #24153 openshift/origin/issues/14198
      
      cc @deads2k @liggitt @caesarxuchao @lavalamp @smarterclayton @derekmahar 
      
      In regards to this, why is the `RESTDeleteStrategy` a useless interface (as far as deletion goes)?  We cast it to `GarbageCollectionDeleteStrategy` or `RESTGracefulDeleteStrategy` in an attempt to do operations related to deletion, but we have "default" behavior for both of those cases.  It should be possible to make `DeleteStrategy` optional by using the other strategies as the `runtime.ObjectTyper` and then defaulting a `nil` `DeleteStrategy` with the expected behavior.
      
      ```go
      // RESTDeleteStrategy defines deletion behavior on an object that follows Kubernetes
      // API conventions.
      type RESTDeleteStrategy interface {
      	runtime.ObjectTyper
      }
      
      type GarbageCollectionPolicy string
      
      const (
      	DeleteDependents GarbageCollectionPolicy = "DeleteDependents"
      	OrphanDependents GarbageCollectionPolicy = "OrphanDependents"
      )
      
      // GarbageCollectionDeleteStrategy must be implemented by the registry that wants to
      // orphan dependents by default.
      type GarbageCollectionDeleteStrategy interface {
      	// DefaultGarbageCollectionPolicy returns the default garbage collection behavior.
      	DefaultGarbageCollectionPolicy() GarbageCollectionPolicy
      }
      
      // RESTGracefulDeleteStrategy must be implemented by the registry that supports
      // graceful deletion.
      type RESTGracefulDeleteStrategy interface {
      	// CheckGracefulDelete should return true if the object can be gracefully deleted and set
      	// any default values on the DeleteOptions.
      	CheckGracefulDelete(ctx genericapirequest.Context, obj runtime.Object, options *metav1.DeleteOptions) bool
      }
      ```
      
      **Release note**:
      
      ```
      NONE
      ```
      82f24cee
    • Kubernetes Submit Queue's avatar
      Merge pull request #46608 from fabianofranz/fixes_kubectl_cache_on_windows · a07298ce
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459)
      
      Fixes kubectl cached discovery on Windows
      
      Fixes https://github.com/kubernetes/kubectl/issues/18
      
      The `kubectl` cached discovery makes use of `func (f *File) Chmod(mode FileMode) error` which is not supported and errors out on Windows, making `kubectl get` and potentially a number of other commands to fail miserably on that platform. `os.Chmod` by file name, on the other hand, does not error out and should be used instead.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      @deads2k @brendandburns @kubernetes/sig-cli-pr-reviews
      a07298ce
    • Kubernetes Submit Queue's avatar
      Merge pull request #46552 from bowei/gcloud-beta · 30a2d7c4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      gcloud command syntax changed between alpha and beta versions
      
      syntax for secondary-ranges changed from:
        name=NAME,range=RANGE
      to
        NAME=RANGE
      30a2d7c4
    • Kubernetes Submit Queue's avatar
      Merge pull request #46525 from deads2k/crd-06-beta · 017e61c7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525)
      
      move CustomResourceDefinitions from alpha to beta
      
      CRDs are built upon the known ThirdPartyResource API with the lessons learned guiding the new shape.  Short comings of the old TPR API even have specific tests to ensure that CRDs do not face the same issues.  Given that, this API qualifies for beta.
      
      These are straight mechanical changes.
      
      @kubernetes/sig-api-machinery-misc 
      @ericchiang  You asked about this in the original pull.
      017e61c7
    • Kubernetes Submit Queue's avatar
      Merge pull request #46488 from ailusazh/FixTypoInTaintContainer · 93704942
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525)
      
      fix typo in taint_controller
      
      **What this PR does / why we need it**:
      fix typo in taint_controller
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      93704942
    • Kubernetes Submit Queue's avatar
      Merge pull request #46449 from crawford/master · 56e73d82
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525)
      
      Export ErrWatchClosed from watch.Until
      
      This is needed so that users of watch.Until may check for this
      particular error instead of attempting to match the error string.
      56e73d82
    • Kubernetes Submit Queue's avatar
      Merge pull request #45014 from CaoShuFeng/unit_for_freed_image_size · 9aa9fb0c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525)
      
      add unit for freed image size
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      9aa9fb0c
    • Kubernetes Submit Queue's avatar
      Merge pull request #43275 from lvjiangzhao/fix-typo-170317 · 28996ac6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525)
      
      Fix typo
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      28996ac6
    • Kubernetes Submit Queue's avatar
      Merge pull request #45421 from allencloud/change-to-use-make-slice-to-store-objects · 20ec8912
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      use make slice to store objects to improve efficiency
      Signed-off-by: 's avatarallencloud <allen.sun@daocloud.io>
      
      
      
      **What this PR does / why we need it**:
      
      we we know the slice length in advance, I think we had better use make to create the specified length of slice. This will improve some kind of performance. Since if we create a slice with []type{}, we did not know how much space runtime should reserve, since slice implementation should be continuous in memory. While when we make a slice with specified length, runtime would reserve a continuous memory space which will not result in slice movement in case of current space is not enough.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      NONE
      
      **Special notes for your reviewer**:
      NONE
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      20ec8912
    • Kubernetes Submit Queue's avatar
      Merge pull request #45872 from YuPengZTE/devServeHTTP · 78ced8e4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      delete unreachable code
      Signed-off-by: 's avataryupengzte <yu.peng36@zte.com.cn>
      
      
      
      **What this PR does / why we need it**:
      After panic, the code is unreachable,delete them.
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      78ced8e4
    • Kubernetes Submit Queue's avatar
      Merge pull request #46535 from yujuhong/rm-redundant-check · 2f498065
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubelet: remove a redundant check for mounting the hosts file
      
      HostNetwork is not part of the Pod.Spec.SecurityContext in the versioned
      pod. Remove the redundant check.
      
      See https://github.com/kubernetes/kubernetes/issues/43632#issuecomment-304370330 for the explanation.
      2f498065
    • deads2k's avatar
      move CRD from alpha to beta · ce681fe4
      deads2k authored
      ce681fe4
    • Kubernetes Submit Queue's avatar
      Merge pull request #46350 from wojtek-t/reduce_kube_proxy_allocations_2 · 0f95f13d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350)
      
      Speed up and reduce number of memory allocations in kube-proxy
      
      This is a second (and last PR) in this series - this solves all very-low-hanging fruits.
      
      This PR:
      - reduces cpu usage by ~25%
      - reduces memory allocations by ~3x (together with #46033 by 10-12x)
      
      Without this PR:
      ```
      (pprof) top
      8.59GB of 8.79GB total (97.75%)
      Dropped 238 nodes (cum <= 0.04GB)
      Showing top 10 nodes out of 64 (cum >= 0.11GB)
            flat  flat%   sum%        cum   cum%
          3.66GB 41.60% 41.60%     8.72GB 99.17%  k8s.io/kubernetes/pkg/proxy/iptables.(*Proxier).syncProxyRules
          3.07GB 34.96% 76.56%     3.07GB 34.96%  runtime.rawstringtmp
          0.62GB  7.09% 83.65%     0.62GB  7.09%  runtime.hashGrow
          0.34GB  3.82% 87.46%     0.34GB  3.82%  runtime.stringtoslicebyte
          0.29GB  3.24% 90.71%     0.58GB  6.61%  encoding/base32.(*Encoding).EncodeToString
          0.22GB  2.47% 93.18%     0.22GB  2.47%  strings.genSplit
          0.18GB  2.04% 95.22%     0.18GB  2.04%  runtime.convT2E
          0.11GB  1.22% 96.44%     0.73GB  8.36%  runtime.mapassign
          0.10GB  1.08% 97.52%     0.10GB  1.08%  syscall.ByteSliceFromString
          0.02GB  0.23% 97.75%     0.11GB  1.25%  syscall.SlicePtrFromStrings
      ```
      
      with this PR:
      ```
      (pprof) top
      2.98GB of 3.08GB total (96.78%)
      Dropped 246 nodes (cum <= 0.02GB)
      Showing top 10 nodes out of 70 (cum >= 0.10GB)
            flat  flat%   sum%        cum   cum%
          1.99GB 64.60% 64.60%     1.99GB 64.60%  runtime.rawstringtmp
          0.58GB 18.95% 83.55%     0.58GB 18.95%  runtime.hashGrow
          0.10GB  3.40% 86.95%     0.69GB 22.47%  runtime.mapassign
          0.09GB  2.86% 89.80%     0.09GB  2.86%  syscall.ByteSliceFromString
          0.08GB  2.63% 92.44%     0.08GB  2.63%  runtime.convT2E
          0.03GB  1.13% 93.56%     0.03GB  1.13%  syscall.Environ
          0.03GB  0.99% 94.56%     0.03GB  0.99%  bytes.makeSlice
          0.03GB  0.97% 95.52%     0.03GB  1.06%  os.Stat
          0.02GB  0.65% 96.18%     3.01GB 97.79%  k8s.io/kubernetes/pkg/proxy/iptables.(*Proxier).syncProxyRules
          0.02GB   0.6% 96.78%     0.10GB  3.35%  syscall.SlicePtrFromStrings
      ```
      0f95f13d
    • Kubernetes Submit Queue's avatar
      Merge pull request #46613 from FengyunPan/fix-e2e-service · 38b26db3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350)
      
      [e2e]Fix define redundant parameter
      
      When timeout to reach HTTP service, redundant parameter make the
      error is nil.
      38b26db3
    • Kubernetes Submit Queue's avatar
      Merge pull request #37212 from gmarek/ms · 6ff83d12
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350)
      
      Add unversioned.MicroTime type
      
      Ref. #36752
      
      cc @smarterclayton @wojtek-t @dchen1107 @timothysc @bgrant0607
      6ff83d12
    • Kubernetes Submit Queue's avatar
      Merge pull request #45534 from YuPengZTE/devPodStatus · cd2e3043
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350)
      
      check err
      Signed-off-by: 's avataryupengzte <yu.peng36@zte.com.cn>
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      cd2e3043
    • Kubernetes Submit Queue's avatar
      Merge pull request #46615 from gmarek/log-monitor · f1cf1f9c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615)
      
      Make log-monitor give up on trying to ssh to a dead node after some time
      
      Fix #38263
      f1cf1f9c
    • Kubernetes Submit Queue's avatar
      Merge pull request #46074 from zjj2wry/set-image · 4979ae4b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615)
      
      add test for set image validation
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      4979ae4b
    • Kubernetes Submit Queue's avatar
      Merge pull request #45909 from zhangxiaoyu-zidif/add-unittest-for-configmap · 8caffc30
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615)
      
      Add Unit Test:describe configmap
      
      **What this PR does / why we need it**:
      Add Unit Test:describe configmap
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8caffc30
    • Kubernetes Submit Queue's avatar
      Merge pull request #45335 from zhangxiaoyu-zidif/fix-goerrors-new · 49b0fe17
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615)
      
      fmt.Errorf replaces errors
      
      **What this PR does / why we need it**:
      
      fmt.Errorf replaces errors
      importing errors is redundant.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      49b0fe17
    • Kubernetes Submit Queue's avatar
      Merge pull request #45488 from bboreham/eviction-log-format · d1e22196
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615)
      
      Fix screwed-up log message format
      
      It had two %-verbs and three arguments
      
      **What this PR does / why we need it**:
      
      Fixes kubelet log lines like this:
      
          May 08 11:49:04 brya-1 kubelet[23248]: W0508 11:49:04.248123   23248 eviction_manager.go:128] Failed to admit pod kube-proxy-g3hjs_kube-system(55c1fbbb-33e4-11e7-b83c-42010a800002) - node has conditions: %v%!(EXTRA []v1.NodeConditionType=[MemoryPressure])
      
      to remove the `%v%!(EXTRA`
      
      **Release note**:
      ```release-note
      NONE
      ```
      d1e22196
    • Shyam Jeedigunta's avatar
      Make kubemark scripts fail fast · 02092312
      Shyam Jeedigunta authored
      02092312
    • Kubernetes Submit Queue's avatar
      Merge pull request #46566 from xychu/kube-apiserver · a4e73033
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46561, 46566)
      
      Fix golint errors in cmd/kube-apiserver
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      a4e73033
    • Kubernetes Submit Queue's avatar
      Merge pull request #46561 from zhangxiaoyu-zidif/return-nil-e2e · c8663558
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46561, 46566)
      
      Return nil when err is nil
      
      **What this PR does / why we need it**:
      Return nil directly when err is nil
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      c8663558
    • Kubernetes Submit Queue's avatar
      Merge pull request #46588 from wojtek-t/matches_single_without_selector · 481e0170
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588)
      
      Matches single without selector
      
      This is reducing cpu-usage of apiserver by ~5% in 5000-node clusters.
      481e0170
    • Kubernetes Submit Queue's avatar
      Merge pull request #46428 from lixiaobing10051267/masterManifest · e59fd18c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588)
      
      ommitting close file while testing manifest
      
      ommitting close file while testing manifest.
      e59fd18c
    • Kubernetes Submit Queue's avatar
      Merge pull request #46377 from noah8713/master · b6c00aeb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588)
      
      Fix comment typo in kube-apiserver and cachesize
      
      **What this PR does / why we need it**:
      Fix comment typo in files cmd/kube-apiserver/app/server.go and pkg/registry/cachesize/cachesize.go
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Not a major issue, just a minor improvement.
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b6c00aeb
    • Kubernetes Submit Queue's avatar
      Merge pull request #46217 from zjj2wry/validate · e9a2ddc8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588)
      
      fix some typo
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      e9a2ddc8
    • Wojciech Tyczynski's avatar