1. 11 Dec, 2016 1 commit
  2. 10 Dec, 2016 16 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #38520 from ixdy/clean-no-docker · 8ccecf93
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Don't require docker or other tools when running `make clean`
      
      **What this PR does / why we need it**: we don't require `docker` for a local build, so we shouldn't require it for `make clean` either.
      
      **Which issue this PR fixes**: fixes #37690
      
      cc @sebgoa
      8ccecf93
    • Kubernetes Submit Queue's avatar
      Merge pull request #31353 from juanvallejo/jvallejo_fix-duplicate-errors-kubectl-set-env · bda57b8f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix duplicate validation/field/errors
      
      **Release note**:
      
      ``` release-note
      release-note-none
      ```
      
      Related PR: https://github.com/kubernetes/kubernetes/pull/30313
      
      PR #30313 fixed duplicate errors for invalid aggregate errors in
      https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/util/helpers.go
      
      However, duplicate aggregate errors that went through
      https://github.com/kubernetes/kubernetes/blob/master/pkg/util/validation/field/errors.go
      were not affected by that patch.
      
      This patch adds duplicate aggregate error checking to
      `pkg/util/validation/field/errors.go`
      ##### Before
      
      `$ kubectl set env rc/idling-echo-1 test-abc=1234`
      
      ```
      error: ReplicationController "idling-echo-1" is invalid:
      [spec.template.spec.containers[0].env[0].name: Invalid value:
      "test-abc": must be a C identifier (matching regex
      [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
      spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
      must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
      "my_name" or "MyName", spec.template.spec.containers[0].env[0].name:
      Invalid value: "test-abc": must be a C identifier (matching regex
      [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
      spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
      must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
      "my_name" or "MyName"]
      ```
      
      `$ kubectl set env rc/node-1 test-abc=1234`
      
      ```
      error: ReplicationController "idling-echo-1" is invalid:
      [spec.template.spec.containers[0].env[0].name: Invalid value:
      "test-abc": must be a C identifier (matching regex
      [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
      spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
      must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
      "my_name" or "MyName"]
      ```
      ##### After
      
      `$ kubectl set env rc/idling-echo-1 test-abc=1234`
      
      ```
      error: ReplicationController "idling-echo-1" is invalid:
      [spec.template.spec.containers[0].env[0].name: Invalid value:
      "test-abc": must be a C identifier (matching regex
      [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
      spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
      must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
      "my_name" or "MyName"]
      ```
      
      `$ kubectl set env rc/node-1 test-abc=1234`
      
      ```
      error: ReplicationController "node-1" is invalid:
      spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc":
      must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
      "my_name" or "MyName"
      ```
      bda57b8f
    • Kubernetes Submit Queue's avatar
      Merge pull request #38406 from liggitt/remove-internal-json-annotations · e732ee70
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove json serialization annotations from internal types
      
      fixes #3933
      
      Internal types should never be serialized, and including json serialization tags on them makes it possible to accidentally do that without realizing it.
      
      fixes in this PR:
      
      * types
        * [x] remove json tags from internal types
        * [x] fix references from serialized types to internal ObjectMeta
      * generation
        * [x] remove generated json codecs for internal types (they should never be used)
      * kubectl
        * [x] fix `apply` to operate on versioned object
        * [x] fix sorting by field to operate on versioned object
        * [x] fix `--record` to build annotation patch using versioned object
      * hpa
        * [x] fix unmarshaling to internal CustomMetricTargetList in validation
      * thirdpartyresources
        * [x] fix encoding API responses using internal ObjectMeta
      * tests
        * [x] fix tests to use versioned objects when checking encoded content
        * [x] fix tests passing internal objects to generic printers
      
      follow ups (will open tracking issues or additional PRs):
      - [ ] remove json tags from internal kubeconfig types (`kubectl config set` pathfinding needs to work against external type)
      - [ ] HPA should version CustomMetricTargetList serialization in annotations
      - [ ] revisit how TPR resthandlers encoding objects
      - [ ] audit and add tests for printer use (human-readable printer requires internal versions, generic printers require external versions)
      - [ ] add static analysis tests preventing new internal types from adding tags
      - [ ] add static analysis tests requiring json tags on external types (and enforcing lower-case first letter)
      - [ ] add more tests for `kubectl get` exercising known and unknown types with all output options
      e732ee70
    • Kubernetes Submit Queue's avatar
      Merge pull request #31678 from anguslees/instances-list-die-die-die · 818f6193
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      providers: Remove long-deprecated Instances.List()
      818f6193
    • Marek Grabowski's avatar
      Merge pull request #38565 from luxas/fix_crossbuild3 · 9716d54a
      Marek Grabowski authored
      Fix the cross-build
      9716d54a
    • Lucas Käldström's avatar
      Fix the cross-build · afefb19a
      Lucas Käldström authored
      afefb19a
    • Angus Lees's avatar
      providers: Remove long-deprecated Instances.List() · 8a7e1031
      Angus Lees authored
      This method has been unused by k8s for some time, and yet is the last
      piece of the cloud provider API that encourages provider names to be
      human-friendly strings (this method applies a regex to instance names).
      
      Actually removing this deprecated method is part of a long effort to
      migrate from instance names to instance IDs in at least the OpenStack
      provider plugin.
      8a7e1031
    • Kubernetes Submit Queue's avatar
      Merge pull request #37783 from brendandburns/acr · 025c57e6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add support for Azure Container Registry, update Azure dependencies
      
      @colemickens
      025c57e6
    • Jess Frazelle's avatar
      Update CHANGELOG.md for v1.4.7. · 1286601c
      Jess Frazelle authored
      1286601c
    • Kubernetes Submit Queue's avatar
      Merge pull request #38423 from vmware/panicAttackvmwarerelease-master · 591a0b1e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 34002, 38535, 37330, 38522, 38423)
      
      Fix panic in vSphere cloud provider
      
      Currently vSphere Cloud Provider triggers panic in controller-manager pod kubernetes. This is because it queries for the cluster name from the VC. We have eliminated that code from the vSphere cloud provider. 
      
      Fixes #36295
      591a0b1e
    • Kubernetes Submit Queue's avatar
      Merge pull request #38522 from Random-Liu/add-default-node-e2e-filter · 4e7dc587
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 34002, 38535, 37330, 38522, 38423)
      
      Node E2E: `make test-e2e-node` runs the same test with pr builder by default.
      
      This PR makes `make test-e2e-node` run non-serial, non-flaky, non-slow test by default.
      This will make it easier to use.
      
      /cc @timstclair
      4e7dc587
    • Kubernetes Submit Queue's avatar
      Merge pull request #37330 from janetkuo/stateful-e2e-rename-pet · f26fc760
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 34002, 38535, 37330, 38522, 38423)
      
      Rename pet to stateful pods in statefulset e2e tests logs
      
      Follow up https://github.com/kubernetes/kubernetes/pull/37243#discussion_r89193790
      
      Note that only mentions of pet in logs are renamed, but not variable name, or file name / import path 
      
      @foxish 
      
      ```release-note
      NONE
      ```
      f26fc760
    • Kubernetes Submit Queue's avatar
      Merge pull request #38535 from caesarxuchao/precommit · 161c01a7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove hack/verify-munge-docs.sh from pre-commit hooks
      
      Follow up of #38309
      161c01a7
    • Kubernetes Submit Queue's avatar
      Merge pull request #34002 from xiaoping378/fix-broken-cluster/centos4 · c2aaac91
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix broken cluster/centos and enhance the style
      
      replace the PR #33818
      c2aaac91
    • Random-Liu's avatar
    • Janet Kuo's avatar
      0e2b0a6f
  3. 09 Dec, 2016 23 commits