1. 18 Apr, 2017 25 commits
    • George Kraft's avatar
      Fix ceph-secret type to kubernetes.io/rbd · 96f944d9
      George Kraft authored
      96f944d9
    • Kubernetes Submit Queue's avatar
      Merge pull request #44267 from zjj2wry/005-f · fab2f5e3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43000, 44500, 44457, 44553, 44267)
      
      add kubectl config view test code
      
      **What this PR does / why we need it**:
      kubectl config view test code
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      think you very much :)
      
      **Release note**:
      
      ```release-note
      ```
      fab2f5e3
    • Kubernetes Submit Queue's avatar
      Merge pull request #44553 from zhangxiaoyu-zidif/warningMsg · 6d18afaf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43000, 44500, 44457, 44553, 44267)
      
      EventTypeWarning replaces EventTypeNormal when failed
      
      **What this PR does / why we need it**:
      
      
      it is similar to #44083 and #44378
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      6d18afaf
    • Kubernetes Submit Queue's avatar
      Merge pull request #44457 from dnardo/e2e_node_cni · 4f50a8d7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43000, 44500, 44457, 44553, 44267)
      
      Updates e2e_node test to allow both kubenet and cni to be specified f…
      
      …or the network plugin.
      
      This adds a simple CNI configuration which is added to the node during test setup.
      This also modifies the default flags in services/kubelet.go to specify the "cni-bin-dir"
      and the "cni-conf-dir" and removes the "network-plugin-dir" flag.  This leaves the default
      network plugin to kubenet.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      4f50a8d7
    • Kubernetes Submit Queue's avatar
      Merge pull request #44500 from Cynerva/gkk/cdk-1.6-support · 09e3fdba
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43000, 44500, 44457, 44553, 44267)
      
      Add Kubernetes 1.6 support to Juju charms
      
      **What this PR does / why we need it**:
      
      This adds Kubernetes 1.6 support to Juju charms.
      
      This includes some large architectural changes in order to support multiple versions of Kubernetes with a single release of the charms. There are a few bug fixes in here as well, for issues that we discovered during testing.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      Thanks to @marcoceppi, @ktsakalozos, @jacekn, @mbruzek, @tvansteenburgh for their work in this feature branch as well!
      
      **Release note**:
      
      ```release-note
      Add Kubernetes 1.6 support to Juju charms
      Add metric collection to charms for autoscaling
      Update kubernetes-e2e charm to fail when test suite fails
      Update Juju charms to use snaps
      Add registry action to the kubernetes-worker charm
      Add support for kube-proxy cluster-cidr option to kubernetes-worker charm
      Fix kubernetes-master charm starting services before TLS certs are saved
      Fix kubernetes-worker charm failures in LXD
      Fix stop hook failure on kubernetes-worker charm
      Fix handling of juju kubernetes-worker.restart-needed state
      Fix nagios checks in charms
      ```
      09e3fdba
    • Kubernetes Submit Queue's avatar
      Merge pull request #43000 from ncdc/protobuf-really-skip-non-output-packages · cec62c80
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      go-to-protobuf: actually skip - packages
      
      If a package is prefixed with -, we are not supposed to be generating
      protobuf for it. Make that actually happen :-)
      
      cc @smarterclayton @sttts @deads2k @liggitt @kubernetes/sig-api-machinery-pr-reviews
      cec62c80
    • Andy Goldstein's avatar
      go-to-protobuf: actually skip - packages · 54b6edc4
      Andy Goldstein authored
      If a package is prefixed with -, we are not supposed to be generating
      protobuf for it. Make that actually happen :-)
      54b6edc4
    • Kubernetes Submit Queue's avatar
      Merge pull request #42246 from jamiehannaford/add-etcd-flags-kubeadm · 4e172303
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Allow configurable etcd options
      
      **What this PR does / why we need it**:
      
      Allows users to set the `--listen-client-urls` and `--advertise-client-urls` flags on etcd binaries for clusters set up with kubeadm.
      
      **Which issue this PR fixes**:
      
      As far as I can tell right now, other nodes in a cluster set up with kubeadm cannot communicate with the etcd static pod running on the master. This is needed in order to set up calico/canal SDN which needs access to a publicly addressable IPv4 _before_ the overlay network and inter-cluster subnet is created.
      
      Addresses https://github.com/kubernetes/features/issues/138 and https://github.com/kubernetes/features/issues/11.
      
      **Release note**:
      ```release-note
      Users can now specify listen and advertise URLs for etcd in a kubeadm cluster 
      ```
      4e172303
    • Kubernetes Submit Queue's avatar
      Merge pull request #44088 from xingzhou/kube-44069 · 1ee8f2f5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fixed `kubectl cluster-info dump` to support multi-container pod.
      
      Fixed `kubectl cluster-info dump` to support multi-container pod.
      
      **Release note**:
      ```
      Improve `kubectl cluster-info dump` to support multi-container pod information dump.
      ```
      
      Fixed #44069
      1ee8f2f5
    • Kubernetes Submit Queue's avatar
      Merge pull request #42711 from xilabao/small-fix-in-audit-log · eccba3b6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      clean auditStringSlice in audit
      eccba3b6
    • Kubernetes Submit Queue's avatar
      Merge pull request #42033 from NickrenREN/dswp-findAndAddActivePods · e91bd12b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 41849, 42033)
      
      fix TODO: find and add active pods for dswp
      
      loops through the list of active pods and ensures that each one exists in the desired state of the world cache
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      e91bd12b
    • Kubernetes Submit Queue's avatar
      Merge pull request #41849 from perotinus/kubefedlogs · 76885940
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [Federation] Print out status updates while `kubefed init` is running
      
      This is not an ideal final state–it does not address the appearance of hanging during long-running commands, for example–but it provides some level of information when the operations are successful.
      
      See #41725.
      
      **Release note**:
      
      ```release-note
      Prints out status updates when running `kubefed init`
      ```
      76885940
    • Kubernetes Submit Queue's avatar
      Merge pull request #43282 from xilabao/use-healthz-api · 877dc568
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      use healthz api in WaitForAPI
      
      finish TODO
      877dc568
    • Kubernetes Submit Queue's avatar
      Merge pull request #42939 from k82cn/k8s_42701 · c20e63bf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Used ObjectReference for events.
      
      fixes #42701 
      
      ```release-note
      None
      ```
      c20e63bf
    • Kubernetes Submit Queue's avatar
      Merge pull request #44578 from MrHohn/ESIPP-GA-1.7 · d11bd34a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Refine NeedsHealthCheck logic for ESIPP
      
      This PR is separated from #41162 (will continue breaking it into small PRs). Fixes #42888.
      
      It moves healthcheck util functions to the right place and refines NeedsHealthCheck logic.
      
      /assign @thockin @freehan 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      d11bd34a
    • NickrenREN's avatar
      find and add active pods for dswp · 5cafb904
      NickrenREN authored
      loops through the list of active pods and ensures that each one exists in the desired state of the world cache
      5cafb904
    • Kubernetes Submit Queue's avatar
      Merge pull request #44526 from FengyunPan/fix-UpdateClusterStatus-panic · aa43023f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44469, 44566, 44467, 44526)
      
      [Federation]Fix panic: index out of range
      
      When the number of clusterStatusNew's Conditions is different from
      the number of clusterStatusOld's Conditions, clustercontroller
      will panic. We should check it before comparing.
      aa43023f
    • Kubernetes Submit Queue's avatar
      Merge pull request #44467 from JulienBalestra/fix-rkt-host-path-volume · 2c774753
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44469, 44566, 44467, 44526)
      
      Kubelet:rkt Fix the hostPath Volume creation
      
      **What this PR does / why we need it**:
      
      This PR fix the `hostPath` volume when the path exist and it's not a directory.
      At the moment, the creation of a `hostPath` volume for an existing file leads to this error:
      
      > kubelet[1984]: E0413 07:53:16.480922    1984 pod_workers.go:184] Error syncing pod 38359a57-1fb1-11e7-a484-76870fe7db83, skipping: failed to SyncPod: mkdir /usr/share/coreos/lsb-release: not a directory
      
      **Special notes for your reviewer**:
      
      You can have a look to the difference with this [gist](https://gist.github.com/JulienBalestra/28ae15efc8a1393d350300880c07ff4f)
      2c774753
    • Kubernetes Submit Queue's avatar
      Merge pull request #44566 from wongma7/adc-wait · 08ea5387
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44469, 44566, 44467, 44526)
      
      WaitForCacheSync before running attachdetach controller
      
      @gnufied you wrote the test and @ncdc the TODO comment. Let's just run the pv and pvc informers, we do not care about them in this test. But we want to be able to stop the pod Informer at will, hence not just using informers.Start, is my understanding.
      ```release-note
      NONE
      ```
      08ea5387
    • Kubernetes Submit Queue's avatar
      Merge pull request #44469 from siggy/siggy/custom-metrics-comment · 88412427
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      comment spelling correction in custommetrics
      
      **What this PR does / why we need it**: fix spelling in a comment
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      88412427
    • Klaus Ma's avatar
      Registered node before other initialization. · 6d29cfc0
      Klaus Ma authored
      6d29cfc0
    • Kubernetes Submit Queue's avatar
      Merge pull request #42830 from apprenda/update_known_flags · c285328a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      noticed typo in known-flags.txt
      
      **What this PR does / why we need it**: looks like this was a typo that wasn't cleaned up
      
      **Release note**:
      ```release-note
      NONE
      ```
      c285328a
    • Kubernetes Submit Queue's avatar
      Merge pull request #41464 from StudyNick/zte170214 · 227e9744
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      'synchoronizing' word error
      227e9744
    • Kubernetes Submit Queue's avatar
      Merge pull request #39944 from NickrenREN/controller-service-test · 32ee9549
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add test for service controller sync and remove unused function
      32ee9549
    • xilabao's avatar
      7f613f09
  2. 17 Apr, 2017 15 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #43956 from jeffvance/e2e-helpers · 2e677a5f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 40055, 42085, 44509, 44568, 43956)
      
      improve error handling in e2e helpers
      
      **What this PR does / why we need it**:
      Changes most of the volume related helper funcs to return error rather than calling `Expect`. This is a better programming practice, is consistent with Go and Kubernetes, and allows helper funcs that create multiple resources to perform cleanup.
      
      ```release-note
      NONE
      ```
      2e677a5f
    • Kubernetes Submit Queue's avatar
      Merge pull request #44568 from mikedanese/fix-staging · f40fafe7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 40055, 42085, 44509, 44568, 43956)
      
      revert BUILD changes at the end of DRY_RUN=n copy.sh
      
      Fixes https://github.com/kubernetes/kubernetes/issues/44567
      
      cc @caesarxuchao @ixdy @spxtr
      f40fafe7
    • Kubernetes Submit Queue's avatar
      Merge pull request #44509 from bowei/cluster-ip · 4c8c2aaa
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 40055, 42085, 44509, 44568, 43956)
      
      Change the default CLUSTER_IP_RANGE used by e2e
      
      The existing choice intersects with the range reserved for auto
      subnets and cannot be used with some GCP features.
      
      ```release-note
      NONE
      ```
      4c8c2aaa
    • Kubernetes Submit Queue's avatar
      Merge pull request #42085 from cblecker/gofmt-fix · a1684fea
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 40055, 42085, 44509, 44568, 43956)
      
      Fix gofmt errors
      
      **What this PR does / why we need it**:
      There were some gofmt errors on master. Ran the following to fix:
      ```
      hack/verify-gofmt.sh | grep ^diff | awk '{ print $2 }' | xargs gofmt -w -s
      ```
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: none
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a1684fea
    • Kubernetes Submit Queue's avatar
      Merge pull request #40055 from StudyNick/zte-20170118 · 44127c58
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      error word
      
      dummyController Struct comment "disonnected " is error word
      WaitForCacheSync method comment "contoller" is error word
      44127c58
    • Jonathan MacMillan's avatar
    • Zihong Zheng's avatar
      Refine NeedsHealthCheck logic · ae93b0da
      Zihong Zheng authored
      ae93b0da
    • Kubernetes Submit Queue's avatar
      Merge pull request #44398 from caesarxuchao/move-v1/refs-and-v1/resource · 73fb9781
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44569, 44398)
      
      Move v1/refs and v1/resource
      
      This PR moves pkg/api/v1/ref.go and pkg/api/v1/resource_helper.go to their own sub packages, it's very similar to 44299 and 44302.
      
      The PR is mostly mechanical, except that 
      * i moved some utility function from resource.go to pkg/api/v1/pod and pkg/api/v1/node, as they are more appropriate
      * i updated the staging/copy.sh to copy the new subpackages, so that helper functions are copied. We can get rid of this copy after client-go stops copying API types.
      73fb9781
    • Kubernetes Submit Queue's avatar
      Merge pull request #44569 from yujuhong/fix-rkt · d3d69505
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Don't check runtime condition for rktnetes
      
      rktnetes is not a CRI implementation, and does not provide runtime
      conditions. This change fixes the issue where rkt will never be
      considered running from kubelet's point of view.
      d3d69505
    • Zihong Zheng's avatar
      Move healthcheck util functions to util.go · cb53dbbf
      Zihong Zheng authored
      cb53dbbf
    • Kubernetes Submit Queue's avatar
      Merge pull request #44513 from mml/windows · 4372b437
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44519, 43194, 44513)
      
      Use regexp instead of substring to do search and replace.
      
      enisoc pointed out how ToLower can change (lengthen even!) the length of
      a string given arbitrary input.
      
      Follow-up to #44421 for #44419
      4372b437
    • Kubernetes Submit Queue's avatar
      Merge pull request #43194 from marun/fed-refactor-secret-e2e · 99b2ab07
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44519, 43194, 44513)
      
      [Federation] Add type-agnostic e2e crud test
      
      This PR proposes an e2e test that reuses the type-agnostic crudtester already used for integration testing to validate crud against a deployed cluster. It is intended to to eventually replace the existing e2e tests for simple types like secrets, but for now will run in addition to the existing testing to gain confidence in the coverage it provides.
      
      The deletion corner cases - when orphanDependents is nil or true - do not involve operations in the member clusters and are already well-tested in integration testing and so are not reimplemented here.
      
      Where it can be applied, this approach of abstracting a test from its execution environment - making the test 'retargetable' - can reduce the cost of test development since the bulk of the work can be iterated on as an integration test.  It can also serve as a check on assumptions made in the integration test about how a deployed environment will behave.
      
      cc: @kubernetes/sig-federation-pr-reviews @kubernetes/sig-testing-misc @smarterclayton @derekwaynecarr
      99b2ab07
    • Kubernetes Submit Queue's avatar
      Merge pull request #44519 from thockin/remove-deprecated-public-ips · ca8f1bcf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove deprecatedPublicIPs field
      ca8f1bcf
    • Chao Xu's avatar
      move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some… · 4f9591b1
      Chao Xu authored
      move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod
      4f9591b1
    • Yu-Ju Hong's avatar
      Don't check runtime condition for rktnetes · 1d3d12df
      Yu-Ju Hong authored
      rktnetes is not a CRI implementation, and does not provide runtime
      conditions. This change fixes the issue where rkt will never be
      considered running from kubelet's point of view.
      1d3d12df