- 21 Aug, 2018 22 commits
-
-
Davanum Srinivas authored
Will reduce the burden of manually adding labels. Information pulled from: https://github.com/kubernetes/community/blob/master/sigs.yaml Change-Id: I17e661e37719f0bccf63e41347b628269cef7c8b
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65788, 67648, 67660). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase inotify max_user_instance limit from 200 to 1000 Fixes:https://github.com/kubernetes/kubernetes/issues/64614 Related:https://github.com/kubernetes/kubernetes/issues/41713 Tested on local GCP cluster with 1000, it works. **Release note**: ```release-note None ``` /cc @kubernetes/sig-scalability-misc @wojtek-t @gmarek @Random-Liu @shyamjvs @jiayingz @saad-ali @RenaudWasTaken @figo
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65788, 67648, 67660). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [kubeadm] fix panic when node annotation is nil **What this PR does / why we need it**: kubeadm will panic, when the node annotation is nil. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /assign @neolit123 **Release note**: ```release-note kubeadm: Fix panic when node annotation is nil ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cleanup apiserver errors - delete unused methods (is this safe, or might they be used in another project outside kubernetes/kubernetes?) - use the standard library `http.Error` function (functional change adds a newline) ```release-note NONE ``` /sig api-machinery /kind cleanup
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiextensions: add optional comment tags Adds `// +optional` comment tags to fields which are optional/omitempty for CRD types. These tags are used for openapi generation: https://github.com/kubernetes/kube-openapi/blob/0cf8f7e6ed1d2e3d47d02e3b6e559369af24d803/pkg/generators/openapi.go#L361-L362 https://github.com/kubernetes/kube-openapi/blob/0cf8f7e6ed1d2e3d47d02e3b6e559369af24d803/pkg/generators/openapi.go#L81-L89 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Prevent resourceVersion updates for custom resources on no-op writes Fixes partly https://github.com/kubernetes/kubernetes/issues/67541 For ObjectMeta pruning, we round trip by marshalling and unmarshalling. If the ObjectMeta contained any strings with `""` (or other fields with empty values) _and_ the respective fields are `omitempty`, those fields will be lost in the round trip process. This makes ObjectMeta after the no-op write different from the one before the write. Resource version is incremented every time data is written to etcd. Writes to etcd short-circuit if the bytes being written are identical to the bytes already present. So this ends up incrementing the `resourceVersion` even on no-op writes. This PR updates the `BeforeUpdate` function such that omitempty fields have values set only if they are non-zero so that they produce an unstructured object that matches ObjectMeta omitempty semantics. /sig api-machinery /kind bug /area custom-resources /assign sttts liggitt **Release note**: ```release-note Prevent `resourceVersion` updates for custom resources on no-op writes. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67332, 66737, 67281, 67173). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use v1 version of advanced audit policy in kubemark audit api version has been updated to v1 #65891 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67332, 66737, 67281, 67173). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. storage e2e test: remove race when setting up loopback device CI has shown occasional failures stemming from an -EBUSY when test/e2e/storage/persistent_volumes-local.go aka "PersistentVolumes-local" attempts to do losetup. Looking at the code, it has a clear race between querying the current free loopback device and later explicitly attempting to loopback setup a file at the queried device node. Losetup nowadays includes the logic to handle this for the user, if the '-f' option is used instead of naming the desired target loopback device explicitly. It is safe to presume a suitable losetup is present as the '-f' option is used elsewhere in the test, and it is safe to not record the allocated device, as it is already queried on the fly elsewhere in the test ahead of other commands which need to know an already created loopback device's node name. This patch should result in less flakes for this test case. Signed-off-by:
Tim Pepper <tpepper@vmware.com> **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67332, 66737, 67281, 67173). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use aws.StringSlice replace of deprecated func stringPointerArray **What this PR does / why we need it**: use aws.StringSlice replace of deprecated func stringPointerArray ``` // stringPointerArray creates a slice of string pointers from a slice of strings // Deprecated: consider using aws.StringSlice - but note the slightly different behaviour with a nil input func stringPointerArray(orig []string) []*string { if orig == nil { return nil } return aws.StringSlice(orig) } ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67332, 66737, 67281, 67173). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Support mount options for cephfs with ceph-fuse mount **What this PR does / why we need it**: When cephfs uses ceph-fuse for the mount command, mount option and readOnly options are disregarded. This patch adds to ceph-fuse as well. **Special notes for your reviewer**: N/A **Release note**: ```release-note NONE ```
-
vikaschoudhary16 authored
-
Nikhita Raghunath authored
For ObjectMeta pruning, we round trip through marshalling and unmarshalling. If the ObjectMeta contained any strings with "" (or other fields with empty values) _and_ the respective fields are omitempty, those fields will be lost in the round trip process. This makes ObjectMeta after the no-op write different from the one before the write. Resource version is incremented every time data is written to etcd. Writes to etcd short-circuit if the bytes being written are identical to the bytes already present. So this ends up incrementing the resourceVersion even on no-op writes. The zero values are set in BeforeCreate and BeforeUpdate. This commit updates BeforeUpdate such that zero values are only set when the object does not have a zero value for the respective field.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Error in return value should be tested and fix Description Info in e2e test **What this PR does / why we need it**: 1. Error in return value should be tested 2. fix Description Info **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fail container start if its requested device plugin resource is unknown. With the change, Kubelet device manager now checks whether it has cached option state for the requested device plugin resource to make sure the resource is in ready state when we start the container. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubernetes/issues/67107 **Special notes for your reviewer**: **Release note**: ```release-note Fail container start if its requested device plugin resource hasn't registered after Kubelet restart. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66862, 67618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix bazel **What this PR does / why we need it**: `bazel test //cmd/kubeadm/...` has been broken for a while. This is incredibly annoying to me, because I use it constantly during my workflow. This should fix it. **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66862, 67618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use sync.map to scale equiv class cache better **What this PR does / why we need it**: Change the current lock in first level ecache into `sync.Map`, which is known for scaling better than `sync. Mutex ` on machines with >8 CPUs ref: https://golang.org/pkg/sync/#Map And the code is much cleaner in this way. 5k Nodes, 10k Pods benchmark with ecache enabled in 64 cores VM: ```bash // before BenchmarkScheduling/5000Nodes/0Pods-64 10000 17550089 ns/op // after BenchmarkScheduling/5000Nodes/0Pods-64 10000 16975098 ns/op ``` Comparing to current implementation, the improvement after this change is noticeable, and the test is stable in 8, 16, 64 cores VM. **Special notes for your reviewer**: **Release note**: ```release-note Use sync.map to scale ecache better ```
-
Xianglin Gao authored
Signed-off-by:Xianglin Gao <xianglin.gxl@alibaba-inc.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67493, 67617, 67582, 67337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix bug:DaemonSet didn't create pod after node have enough resource **What this PR does / why we need it**: Fix bug:DaemonSet didn't create pod after node have enough resource **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #67225 **Special notes for your reviewer**: NONE **Release note**: ```release-note DaemonSet: Fix bug- daemonset didn't create pod after node have enough resource ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67493, 67617, 67582, 67337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. updates kibana to 6.3.2 **What this PR does / why we need it**: * updates kibana to 6.3.2 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: needed as es was updated to 6.3.2 too in https://github.com/kubernetes/kubernetes/pull/67484 **Release note**: ```release-note updates kibana to 6.3.2 ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67493, 67617, 67582, 67337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. limit forbidden error to details of what was forbidden cleans up output from https://github.com/kubernetes/kubernetes/pull/65906#discussion_r210048853 /assign @smarterclayton ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67493, 67617, 67582, 67337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Tolerate nil input in GetValueFromIntOrPercent **What this PR does / why we need it**: `GetValueFromIntOrPercent` accepts pointer argument but does not validate it. This PR fixes that problem preventing from panics. /assign @deads2k @sttts **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Change rbd base image back to fedora 26 Due to the compatiblility issue for ceph server, it needs to change back to fedora 26 from fedora 28, as a workaround. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #67269 **Special notes for your reviewer**: /sig storage @dims @rootfs **Release note**: ```release-note NONE ```
-
- 20 Aug, 2018 18 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67596, 67520, 67605). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cert list 2 **What this PR does / why we need it**: Continuation of #67208. Uses the newly created declarative list of certificates kubeadm requires for the certs phase and upgrade steps. **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67596, 67520, 67605). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Wait for Available in PV protection test **What this PR does / why we need it**: Just after creating a PV, its phase is "Pending" and its finalizers doesn't contain "kubernetes.io/pv-protection". If the e2e test performs so faster than the target k8s cluster, the test fails because the PV is not ready. This adds WaitForPersistentVolumePhase() for waiting the phase "Available" to avoid such situation. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #67519 **Release note**: NONE
-
liz authored
kubeadm tests no longer change the default directory, they simply use the correct absolute path
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add sig/api-machinery label to apimachinery OWNERS files Inspired by https://github.com/kubernetes/kubernetes/pull/67548. List of OWNERS files taken from https://github.com/kubernetes/community/blob/master/sig-api-machinery/README.md#subprojects. **Release note**: ```release-note NONE ```
-
Jordan Liggitt authored
-
liz authored
`phase certs` and upgrade commands now all use certslist infra
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67593, 67544). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fixes json logging in fluentd-elasticsearch image **What this PR does / why we need it**: * fixes json logging in fluentd-elasticsearch image by downgrading fluent-plugin-kubernetes_metadata_filter plugin to version 2.0.0 * adds missing pos files to fluentd config * adds mapping type name **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # * https://github.com/helm/charts/issues/7168 **Special notes for your reviewer**: * https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/145 * https://github.com/uken/fluent-plugin-elasticsearch/issues/442 **Release note**: ```release-note fixes json logging in fluentd-elasticsearch image by downgrading fluent-plugin-kubernetes_metadata_filter plugin to version 2.0.0 ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 67593, 67544). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Typo fix in returned message: ClusteRole->ClusterRole There is a typo in returned message: Line 143: ClusteRole->ClusterRole
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55600, 67386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. update Annotations description about audit.Event ref: https://github.com/kubernetes/kubernetes/pull/58679#discussion_r209375632 **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /assign @liggitt **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55600, 67386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove deplicate code for PodRequestsAndLimits remove deplicate code for PodRequestsAndLimits add unit test for PodRequestsAndLimits **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Nikhita Raghunath authored
-
Maciej Szulik authored
-
Maciej Szulik authored
-
Anago GCB authored
-
AdamDang authored
ClusteRole->ClusterRole
-
André Bauer authored
-
André Bauer authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66592, 66639). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. refactor some hard code in pkg/util/ipset/ipset.go **What this PR does / why we need it**: refactor some hard code in pkg/util/ipset/ipset.go **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-