- 24 Sep, 2017 9 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51902, 52718, 52687, 52137, 52697). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Refactoring and improvements for iSCSI and FC storage plugins **What this PR does / why we need it**: This PR makes following changes. - Simplify volume tearDown path for iSCSI and FC using util.UnmountPath(). - Log lastErr during iscsi connection If iscsid fails to connect second portal, currently the error is ignored silently. The lastErr should be logged to find the root cause of problem. - Remove iscsi plugin directory after iscsi connection is successfully closed. **Which issue this PR fixes** : No related issues. **Special notes for your reviewer**: /cc @rootfs @jsafrane **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51902, 52718, 52687, 52137, 52697). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. stop the Timer **What this PR does / why we need it**: Ticker stop twice, and does not stop Timer.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Refactor cronjob test case with sets.String **What this PR does / why we need it**: Refactor cronjob test case with sets.String **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubernetes/issues/51396 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52485, 52443, 52597, 52450, 51971). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. add --list option to label cmd **Release note**: ```release-note added --list option to the `kubectl label` command ``` Adds a `--list` option to `kubectl label ...` with similar behavior to `kubectl env ... --list` **Before** ``` $ kubectl label pod/mypod --list Error: unknown flag: --list Usage: ... ``` **After** ``` $ kubectl label pod/mypod --list labelkey1=existinglabel1 labelkey2=existinglabel2 $ kubectl label pod/mypod --list label1=newlabel1 labelkey1=existinglabel1 labelkey2=existinglabel2 label1=newlabel1 ``` Related downstream bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1268877 cc @fabianofranz @kubernetes/sig-cli-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52485, 52443, 52597, 52450, 51971). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Error message / exit code fixes **Release note**: ```release-note NONE ``` Miscellaneous error message tweaks. Makes the error message displayed in `kubectl get` more visible. Returns exit code 1 if a patch fails. Addresses the following downstream bugzillas: - https://bugzilla.redhat.com/show_bug.cgi?id=1311786 - https://bugzilla.redhat.com/show_bug.cgi?id=1414227 cc @fabianofranz @kubernetes/sig-cli-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52485, 52443, 52597, 52450, 51971). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Some kubelet flags do not accept their default values Correct the flags and add a round trip test that ensure these do not break again in the future. @deads2k as observed when we tried to turn flags into args.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52485, 52443, 52597, 52450, 51971). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Enable go race detection for bazel tests. Testing if setting `features = ["-race"]` fixes the breaks in #50792. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52485, 52443, 52597, 52450, 51971). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Removing PrometheusPushGateway --prom-push-gateway flag from e2e tests. **What this PR does / why we need it**: Removing obsolete PrometheusPushGateway --prom-push-gateway flag from e2e tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45947 **Special notes for your reviewer**: **Release note**: ```release-note Removing `--prom-push-gateway` flag from e2e tests ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. fix issue(11233)enhance kubectl config command **What this PR does / why we need it**: Fixes #11233 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
- 23 Sep, 2017 31 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50890, 52484, 52542, 52567, 50672). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fix return 0 error in DefaultSubCommandRun Fixes https://github.com/kubernetes/kubernetes/issues/50644 @mengqiy most of our command didn't return 1 when error, is because it invoke `DefaultSubCommandRun` which created in this pr https://github.com/kubernetes/kubernetes/pull/35206, I'm not sure if it's ok to directly add an `os.Exit` in that function, so also cc @juanvallejo @fabianofranz for review. also @apelisse @mengqiy I think we don't have any test for check return value now ? cmiiw, I will add some test in test-cmd since it's easy to write scripts check return value, wdyt ?
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50890, 52484, 52542, 52567, 50672). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Do not set message when terminationMessagePath not found If terminationMessagePath is set to a file that does not exist, we should not log an error message and instead try falling back to logs (based on the user's request). This also slightly simplifies the terminationMessagePath processing. Seen in #50499 ```release-note If a container does not create a file at the `terminationMessagePath`, no message should be output about being unable to find the file. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50890, 52484, 52542, 52567, 50672). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. kubeadm: Switching to apps/v1beta2
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50890, 52484, 52542, 52567, 50672). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. fix kubectl get cronjob lose age info **What this PR does / why we need it**: relate with #20941 befere output: ``` NAME SCHEDULE SUSPEND ACTIVE LAST SCHEDULE AGE pi 0/5 * * * ? False 1 Thu, 14 Sep 2017 20:10:00 +0800 ``` now output: ``` admindeMacBook-Pro-2:kubectl admin$ ./kubectl get cronjob NAME SCHEDULE SUSPEND ACTIVE LAST SCHEDULE AGE pi 0/5 * * * ? False 1 3m 4m ``` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: thanks **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. remove todo(#42787)Add fallback for cronjobs, and move some useful funct… …ion to cmdutil **What this PR does / why we need it**: remove todo relation with #42787 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Azure - Use cloud environment to instantiate storage client **What this PR does / why we need it**: Since 1.7 and managed disk for azure, blob storage on Azure cloud other than the default public one is broken, because kubernetes expect blob ressources URI to end with `.blob.core.windows.net ` (ignoring storageEndpointSuffix). This include the chinese Cloud, for which storageEndpointSuffix is `blob.core.chinacloudapi.cn` for example. See : https://github.com/Azure/azure-storage-go/blob/master/client.go#L194 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Clear TODO: Adding UT for loading ipvs config **What this PR does / why we need it**: Clear TODO: Adding UT for loading ipvs config **Which issue this PR fixes**: **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Drop --experimental-bootstrap-token-auth flag. **What this PR does / why we need it**: Drops support for the `--experimental-bootstrap-token-auth` flag for the API server. This flag was replaced by `--enable-bootstrap-token-auth` in 1.8 (https://github.com/kubernetes/kubernetes/pull/51198) but the old flag was accepted with a deprecation warning. In 1.9 we want to totally drop it. **Which issue this PR fixes**: fixes #50613 **Special notes for your reviewer**: There are other places in kubeadm where we need to drop support for this flag (at init and at postupgrade). We can tackle those in a separate PR. **Release note**: I think this change is already document well enough in the changelog for 1.8. ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-auth-pr-reviews /kind cleanup
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Add s390x to juju kubernetes **What this PR does / why we need it**: With this PR we add support for s390x to juju kubernetes worker **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```Kubernetes deployments to s390x via Juju ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. E2E test to make sure controller does not crash because of nil volume spec Fixes #49521 Tests fix of issue referenced in #49418
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52445, 52380, 52516, 52531, 52538). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Remove warning about changes in default token TTLs **What this PR does / why we need it**: It was planned for 1.9 cleanup to remove that warning, as change was done few release cycles ago and users should be already aware of it. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/kubeadm#346 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52445, 52380, 52516, 52531, 52538). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. optimize then function in kind visitor Signed-off-by:
yuexiao-wang <wang.yuexiao@zte.com.cn> **What this PR does / why we need it**: optimize then function Accept in kind visitor and use switch instead of many if cases. Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #52700 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52445, 52380, 52516, 52531, 52538). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Follow go style guide and fix versioning doc link Signed-off-by:
sakeven <jc5930@sina.cn> **What this PR does / why we need it**: 1. Follow go style guide * should drop = "" from declaration of var gitMajor; it is the zero value * should omit type string from declaration of var gitVersion; it will be inferred from the right-hand side 2. Fix versioning doc link. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52445, 52380, 52516, 52531, 52538). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. remove repeated import'k8s.io/client-go/kubernetes' in controllermana… **What this PR does / why we need it**: There are duplicate importing "k8s.io/client-go/kubernetes", we just need 'clientset'. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fix kubernetes charms not restarting services properly after host reboot on LXD **What this PR does / why we need it**: This fixes an issue when running the Kubernetes charms on LXD where the services don't restart properly after a reboot of the host machine. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/357 **Special notes for your reviewer**: See https://github.com/juju-solutions/layer-cdk-service-kicker **Release note**: ```release-note Fix kubernetes charms not restarting services properly after host reboot on LXD ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52168, 48939, 51889, 52051, 50396). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Add Windows Server Containers Stats and Metrics to Kubelet **What this PR does / why we need it**: This PR implements stats for Windows Server Containers. This adds the ability to monitor Windows Server containers via the existing stats/summary endpoint inside the kubelet. Windows metrics can now be ingested into heapster and monitored using existing tools (like Grafana). Previously, the /stats/summary api would consistently crash the kubelet on Windows server containers. This PR implements a new package "winstats" which reads windows server metrics from a combination of windows specific perf counters as well as docker stats. The "winstats" package exports functions that return CAdvisor data structures, which the existing summary api can read. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49398 This PR addresses my plan to implement windows server container stats https://github.com/kubernetes/kubernetes/issues/49398 . **Release note**: ```release-note Add monitoring of Windows Server containers metrics in the kubelet via the stats/summary endpoint. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52168, 48939, 51889, 52051, 50396). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. acknowledge --show-all=false with --watch **Release note**: ```release-note NONE ``` Allow the `--show-all=false` option to work when invoking `kubectl get ...` with the `--watch` option enabled. Related downstream issue: https://github.com/openshift/origin/issues/14975 cc @fabianofranz @kubernetes/sig-cli-misc @kargakis
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52168, 48939, 51889, 52051, 50396). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Add specific errors for pod affinity predicates **What this PR does / why we need it**: Add specific error for pod affinity predicates **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # fix https://github.com/kubernetes/kubernetes/issues/51655 **Special notes for your reviewer**: none **Release note**: none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52168, 48939, 51889, 52051, 50396). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fix typo in kubelet kuberuntime container test Changes "Expetected" to "Expected" **What this PR does / why we need it**: Fixes a typo in a test **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Merge pull request #52168 from mattjmcnaughton/mattjmcnaughton/49256-clear-status-message-when-zero-desired-pods Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fix incorrect status msg in podautoscaler **Which issue this PR fixes** Fix #49256 **What this PR does / why we need it**: When `ScalingLimited = true` for the `hpa`, there is an accompanying status message, describing why scaling is limited. Previously if the desired replica count was 0, and spec.minReplicas > 0, the status message indicated "the desired replica count was less than the min replica count". This was particularly confusing when `spec.MinReplicas = 1`. If there was no `spec.minReplicas`, then the status message indicated "the desired replica count was zero" which is more informative. Update the calculation of status message so that if the desired replica count is 0, we always display the clearer "the desired replica count was zero" status message, even if spec.minReplicas > 0. Signed-off-by:
mattjmcnaughton <mattjmcnaughton@gmail.com> ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Preserve leading and trailing slashes on proxy subpaths subresource parsing was not populating path parameters correctly (leading and trailing slashes were being stripped) this caused bad locations to be sent to the proxy, causing https://github.com/kubernetes/kubernetes/issues/52022. the first attempt to fix that (#52065) unconditionally prefixed '/', which broke the redirect case (#52813 #52729) fixes #52813, fixes #52729 needs to be picked to 1.7 and 1.8 ```release-note Restores redirect behavior for proxy subresources ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50294, 50422, 51757, 52379, 52014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. rsync ipvs proxier to HEAD of iptables **What this PR does / why we need it**: rsync ipvs proxier to HEAD of iptables. **Which issue this PR fixes**: xref #51679 **Special notes for your reviewer**: Obviously, @Lion-Wei has done part of this work, ref: #51922. It's fine that let #51922 get in first. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50294, 50422, 51757, 52379, 52014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. print HostPathType for kubectl describe **What this PR does / why we need it**: Since #46597 has already added `HostPathType` for `HostPath`, we should print it when we describe it. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: @thockin PTAL /assign @smarterclayton @liggitt @pwittrock **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50294, 50422, 51757, 52379, 52014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Azure cloud provider: expose services on non-default subnets **What this PR does / why we need it**: The Azure cloud provider allows users to specify that a service should be exposed on an internal load balancer instead of the default external load balancer. However, in a VNet environment, such services are currently always exposed on the master subnet. Where there are multiple subnets in the VNet, it's desirable to be able to expose an internal service on any subnet. This PR allows this via a new annotation, `service.beta.kubernetes.io/azure-load-balancer-internal-subnet`. **Which issue this PR fixes**: fixes https://github.com/Azure/acs-engine/issues/1296 (no corresponding issue has been raised in the k8s core repo) **Special notes for your reviewer**: None **Release note**: ```release-note A new service annotation has been added for services of type LoadBalancer on Azure, to specify the subnet on which the service's front end IP should be provisioned. The annotation is service.beta.kubernetes.io/azure-load-balancer-internal-subnet and its value is the subnet name (not the subnet ARM ID). If omitted, the default is the master subnet. It is ignored if the service is not on Azure, if the type is not LoadBalancer, or if the load balancer is not internal. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50294, 50422, 51757, 52379, 52014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fix AnnotationProvidedIPAddr annotation for externalCloudProvider **What this PR does / why we need it**: In #44258, it introduced `AnnotationProvidedIPAddr`. When kubelet has 'node-ip' parameter set, and cloud provider not set, this annotation would be populated, and then will be validated by cloud-controller-manager: https://github.com/kubernetes/kubernetes/pull/44258/files#diff-6b0808bd1afb15f9f77986f4459601c2R465 Later with #47152, externalCloudProvider is checked and func returns before that annotation got set. In this case, that annotation will not get populated. This fix is to bring that annotation assignment to a proper location. Please correct me if I have any misunderstanding. @wlan0 @ublubu **Which issue this PR fixes** **Special notes for your reviewer**: **Release note**:
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fixed a small comment typo **Release note**: ``` None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52109, 52235, 51809, 52161, 50080). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Add UT for pkg/kubectl/clusterrolebinding_test.go **What this PR does / why we need it**: I find there is no UT case for pkg/kubectl/clusterrolebinding.go. This PR Adds some UTs for pkg/kubectl/clusterrolebinding_test.go **Which issue this PR fixes**: **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig cli
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52109, 52235, 51809, 52161, 50080). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Allow kubectl cp large amounts of files from container When we try to copy out a dir with large amounts of files from container, we hit such error: ```bash kubectl cp mypod:/ ./a/ tar: Removing leading `/' from member names tar: Removing leading `/' from hard link targets error: open a/usr/share/zoneinfo/Asia/Rangoon: too many open files ``` This is because kubectl opens too many files at the same. We should close them after Write() function. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52109, 52235, 51809, 52161, 50080). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Updated pd.go tests to use GCE API instead of GCloud Commands Fixes #49796
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52109, 52235, 51809, 52161, 50080). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Remove backward compatibility of hostportChainName **What this PR does / why we need it**: fix TODO. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: /assign @freehan **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Add more test coverage for kubeadm uploadconfig especially with idemp… **What this PR does / why we need it**: This PR adds more test case for Kubeadm uploadconfig, particularly to address some feedback in #51482 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # fixes #kubernetes/kubeadm#379 **Special notes for your reviewer**: ```release-note NONE ```
-