- 02 Aug, 2018 21 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66850, 66902, 66779, 66864, 66912). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. update polymorphichelpers for external types and updates expose to externals as proof @kubernetes/sig-cli-maintainers /assign @soltysh @juanvallejo ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66850, 66902, 66779, 66864, 66912). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. update etcdstorage test to use discovery 1. update etcdstorage test to use discovery 2. switches to use the dynamic client 3. fixes the bug where the server wasn't a complete kube-apiserver ```release-note NONE ``` /assign @enj @sttts @kubernetes/sig-api-machinery-pr-reviews @apelisse a discovery based example. @yue9944882 you've expressed an interest. The wiring for the server is really hard to use here. I've also noticed that this doesn't build an equivalent kube-apiserver, but that is proving troublesome. Will follow up with with.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66850, 66902, 66779, 66864, 66912). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add methods to apimachinery to easy unit testing When unit testing, you often want a selective scheme and codec factory. Rather than writing the vars and the init function and the error handling, you can simply do `scheme, codecs := testing.SchemeForInstallOrDie(install.Install)` @kubernetes/sig-api-machinery-misc @sttts ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66850, 66902, 66779, 66864, 66912). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Run autoscaling tests with expendable pods on GKE Enable tests using expendable pods on GKE. ```release-note NONE ``` /cc @MaciekPytel /sig autoscaling
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66850, 66902, 66779, 66864, 66912). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix unit test failure: TestNsenterExistsFile **What this PR does / why we need it**: Fix unit test failure: TestNsenterExistsFile **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #66809 **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
David Eads authored
-
David Eads authored
-
David Eads authored
-
David Eads authored
-
David Eads authored
-
David Eads authored
-
Aleksandra Malinowska authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66877, 66066, 66851). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add namespace info for pod in log **What this PR does / why we need it**: add namespace info for pod in log **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66877, 66066, 66851). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cleanup the Admission Webhook E2E code **What this PR does / why we need it**: The current documentation for Admission Webhooks points to the e2e tests as an example. The code appears to have some legacy configuration left behind. The variables are confusingly named and it lacked comments developers could follow. This is an attempt to clean up some code and make the code more readable to make webhook development easier. **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Generate crictl config for preload as well. Generate `/etc/crictl.yaml` also when crictl is preloaded. Signed-off-by:
Lantao Liu <lantaol@google.com> **Release note**: ```release-note Fix a bug on GCE that /etc/crictl.yaml is not generated when crictl is preloaded. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix some type of CHANGELOG-1.11.md **What this PR does / why we need it**: Fix some type of CHANGELOG-1.11.md **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 66846, 60552). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adding details to Conformance Tests using RFC 2119 standards. This PR is part of the conformance documentation. This is to provide more formal specification using RFC 2119 keywords to describe the test so that who ever is running conformance tests do not have to go through the code to understand why and what is tested. The documentation information added here into each of the tests eventually result into a document which is currently checked in at location https://github.com/cncf/k8s-conformance/blob/master/docs/KubeConformance-1.9.md I would like to have this PR reviewed for v1.10 as I consider it important to strengthen the conformance documents.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix typo: scale dowm-> scale down **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Anago GCB authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64645, 66832). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Detect if GCE PD udev link is wrong and try to correct it **What this PR does / why we need it**: udev can miss scsi events and not update device links properly when disks are detached and reattached to the same node in a different order. This PR workarounds the issue by comparing the udev link name, which is the PD disk name, with the scsi disk serial number returned from scsi_id, and prevents mounting of the disk if the link is wrong. It will also run `udevadm trigger` on the disk to try to correct the bad link. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note This fix prevents a GCE PD volume from being mounted if the udev device link is stale and tries to correct the link. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 64645, 66832). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add e2e tests for resource quota's priority class scope. This pr is built on top of https://github.com/kubernetes/kubernetes/pull/57963. @vikaschoudhary16 @sjenning @derekwaynecarr @bsalamat @kubernetes/sig-scheduling-pr-reviews ```release-note None ```
-
- 01 Aug, 2018 19 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65730, 66615, 66684, 66519, 66510). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubelet: add image-gc low/high validation check Currently, there is no protection against setting the high watermark <= the low watermark for image GC This PR adds a validation rule for that. @smarterclayton
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65730, 66615, 66684, 66519, 66510). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. update attach to use external objs **Release note**: ```release-note NONE ``` Updates attach command to use external versions. cc @deads2k @soltysh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65730, 66615, 66684, 66519, 66510). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. aggregate admin from edit and view to ensure coverage ClusterRole aggregate has worked quite well. This updates the edit role to be aggregated from a separate edit and view and updates the admin role to aggregated from admin, edit, and view. This ensures coverage (we previously had unit tests, but that didn't work as people aggregated more powers in) and it makes each role smaller since it only has a diff to consider. @kubernetes/sig-auth-pr-reviews ```release-note admin RBAC role now aggregates edit and view. edit RBAC role now aggregates view. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65730, 66615, 66684, 66519, 66510). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Speed up HPA reaction to metric changes by removing scale up forbidden window **What this PR does / why we need it**: Speed up HPA reaction to metric changes by removing scale up forbidden window. Scale up forbidden window was protecting HPA against making decision to scale up based on metrics gathered during pod initialisation (which may be invalid, for example pod may be using a lot of CPU despite not doing any "actual" work). To avoid that negative effect only use per pod metrics from pods that are: - ready (so metrics about them should be valid), or - unready but creation and last readiness change timestamps are apart more than 10s (pods that have formerly been ready and so metrics are in at least some cases (pod becoming unready because of overload) very useful). This PR only deals with scale up window. I'll send another PR dealing with scale down window soon. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```release-note Speed up HPA reaction to metric changes by removing scale up forbidden window. Scale up forbidden window was protecting HPA against making decision to scale up based on metrics gathered during pod initialisation (which may be invalid, for example pod may be using a lot of CPU despite not doing any "actual" work). To avoid that negative effect only use per pod metrics from pods that are: - ready (so metrics about them should be valid), or - unready but creation and last readiness change timestamps are apart more than 10s (pods that have formerly been ready and so metrics are in at least some cases (pod becoming unready because of overload) very useful). ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 65730, 66615, 66684, 66519, 66510). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add DynamicProvisioningScheduling support for EBS **What this PR does / why we need it**: This PR adds support for the DynamicProvisioningScheduling feature in EBS. With this in place, if VolumeBindingMode: WaitForFirstConsumer is specified in a EBS storageclass and DynamicProvisioningScheduling is enabled, EBS provisioner will use the selected node's LabelZoneFailureDomain as the zone to provision the EBS volume in. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: Related to #63232 Sample `describe pv` output with NodeAffinity populated: ``` ~$ kubectl describe pv pvc-f9d2138b-7e3e-11e8-a4ea-064124617820 Name: pvc-f9d2138b-7e3e-11e8-a4ea-064124617820 Labels: failure-domain.beta.kubernetes.io/region=us-west-2 failure-domain.beta.kubernetes.io/zone=us-west-2a Annotations: kubernetes.io/createdby=aws-ebs-dynamic-provisioner pv.kubernetes.io/bound-by-controller=yes pv.kubernetes.io/provisioned-by=kubernetes.io/aws-ebs Finalizers: [kubernetes.io/pv-protection] StorageClass: slow3 Status: Bound Claim: default/pvc3 Reclaim Policy: Delete Access Modes: RWO Capacity: 6Gi Node Affinity: Required Terms: Term 0: failure-domain.beta.kubernetes.io/zone in [us-west-2a] failure-domain.beta.kubernetes.io/region in [us-west-2] Message: Source: Type: AWSElasticBlockStore (a Persistent Disk resource in AWS) VolumeID: aws://us-west-2a/vol-0fc1cdae7d10860f6 FSType: ext4 Partition: 0 ReadOnly: false Events: <none> ``` **Release note**: ```release-note none ``` /sig storage /assign @msau42 @jsafrane
-
Lantao Liu authored
Signed-off-by:Lantao Liu <lantaol@google.com>
-
Jason Smith authored
added comments and renamed some variables to make the code easier to understand migrated to new image_util build system improved tests updated copyright headers to 2018 updated webhook version
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. volumemanager: remove unneccesary closure ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Full blown kubectl create job **What this PR does / why we need it**: This is a followup to https://github.com/kubernetes/kubernetes/pull/60084 which adds full blown `create job` command /assign @deads2k @juanvallejo **Release note**: ```release-note Add kubectl create job command ```
-
David Eads authored
-
David Eads authored
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. move feature gate checks inside IsCriticalPod Currently `IsCriticalPod()` calls throughout the code are protected by `utilfeature.DefaultFeatureGate.Enabled(features.ExperimentalCriticalPodAnnotation)`. However, with Pod Priority, this gate could be disabled which skips the priority check inside IsCriticalPod(). This PR moves the feature gate checking inside `IsCriticalPod()` and handles both situations properly. @aveshagarwal @ravisantoshgudimetla @derekwaynecarr /sig node /sig scheduling /king bug
-
Srini Brahmaroutu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Part 1: Allowing volumes to choose when to use securityContext This PR is the result of [splitting this PR]( https://github.com/kubernetes/kubernetes/pull/65793) into 2 sections: 1) This part, addressing the refactor so eligible-test-for-conformance can use get rid of privileged security context. 2) a second part that will address the promotion of the testcases to be in conformance suite. Changes: a) demoted privileged mode for these tests (not needed) b) regular tests (the other ones existing in the file) will still be using privileged security context. b) adding privilegedSecurityContext field to VolInfo, so each volume-flavor can let the test know if the security context has to be privileged or not. This allows granular changes and updates per volume).
-
Michelle Au authored
-
linyouchong authored
-
Deep Debroy authored
Signed-off-by:Deep Debroy <ddebroy@docker.com>
-
Joachim Bartosik authored
-