- 08 Dec, 2016 1 commit
-
-
juanvallejo authored
Related PR: https://github.com/kubernetes/kubernetes/pull/30313 PR #30313 fixed duplicate errors for invalid aggregate errors in https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/util/helpers.go However, duplicate aggregate errors that went through https://github.com/kubernetes/kubernetes/blob/master/pkg/util/validation/field/errors.go were not affected by that patch. This patch adds duplicate aggregate error checking to `pkg/util/validation/field/errors.go` \##### Before `$ kubectl set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ kubectl set env rc/node-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` \##### After `$ kubectl set env rc/idling-echo-1 test-abc=1234` ``` error: ReplicationController "idling-echo-1" is invalid: [spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"] ``` `$ kubectl set env rc/node-1 test-abc=1234` ``` error: ReplicationController "node-1" is invalid: spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc": must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName" ```
-
- 05 Dec, 2016 37 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37370, 37003, 36909) Add verbs to APIResourceInfo for discovery Verbs will be used by generic controllers (gc, namespace) to avoid unnecessary API calls, reducing load on the apiserver. E.g. not all objects can be deleted. Example: ```json { "kind": "APIResourceList", "apiVersion": "v1", "groupVersion": "batch/v1", "resources": [ { "name": "jobs", "namespaced": true, "kind": "Job", "verbs": [ "create", "delete", "deletecollection", "get", "list", "update", "watch" ] }, { "name": "jobs/status", "namespaced": true, "kind": "Job", "verbs": [ "create", "get" ] } ] } ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37370, 37003, 36909) add auth proxy roundtripper Adds a round tripper which adds auth proxy fields based on user.Info you can pull from a context. It clears existing headers first to be sure that these aren't accidentally set ahead of time. @nikhiljindal per our conversation. This is what I'm using downstream.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Make NodeController test utils usable from outside Required to fix tests for #37365 and useful in general.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37307, 29606, 37986) Allow glusterfs dp volume creation for empty clusterid parameter in sc. Why this patch is needed? The `strings.split()` (https://github.com/kubernetes/kubernetes/pull/37986/files#diff-e97253dd603331ffca81131a4b67264fR700) returns a slice of `single element("empty") ` when the split is attempted on a string. This is expected according to `https://golang.org/pkg/strings/#Split` and `https://github.com/golang/go/issues/13075`. This make the provisioner to fail, if `clusterid` is not defined in the SCs. This patch make sure the split is attempted only when clusterid is mentioned in the sc parameter. Signed-off-by:
Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37307, 29606, 37986) scheduler remove init method Fix #29255 , @davidopp ptal.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Enable update tests for federated secret controller Enable update tests in secret controller + add option to execute multiple iterations in the same run. cc: @nikhiljindal @madhusudancs
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37208, 37446, 37420) Kubelet log modification Keep in line with the other error logs in the function. After return, the caller records the error log.Delete redundant logs
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37208, 37446, 37420) Move "-short" to KUBE_TEST_ARGS fixes #37445 **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note NONE ``` "-short" is a argument of "go test", it should be moved to "KUBE_TEST_ARGS".
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37208, 37446, 37420) Change 'controller.go' filenames to more meaningfull ones Controller logic should sit in uniquely named file, not `controller.go`, as the latter makes it very hard to understand controller-manager logs. @deads2k @bgrant0607 @soltysh @gtank
-
Marcin authored
-
Marcin Wielgus authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
AdoHe authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Increase max mutating inflight requests in large clusters
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Create GetOptions to allow passing "ResourceVersion" to GET requests. Ref #37473 @kubernetes/sig-api-machinery @smarterclayton
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Enable updates in federated ingress controller tests And make channel in test helper non-blocking. cc: @nikhiljindal @madhusudancs
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix resync goroutine leak in ListAndWatch <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: This PR fixes resync goroutine leak in ListAndWatch function **Which issue this PR fixes** _(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes # fixes #35015 **Special notes for your reviewer**: **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ``` release-note ``` Previously, we had no way to stop resync goroutine when ListAndWatch returned. goroutine leaked every time ListAndWatch returned, for example, with error. This commit adds another channel to signal that resync goroutine should exit when ListAndWatch returns.
-
gmarek authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Split inflight requests into read-only and mutating groups cc @smarterclayton @lavalamp @caesarxuchao ```release-note API server have two separate limits for read-only and mutating inflight requests. ```
-
Jerzy Szczepkowski authored
Fix error handling in cluster autoscaler e2e test
-
gmarek authored
-
Wojciech Tyczynski authored
-
gmarek authored
-
Humble Chirammal authored
Signed-off-by:Humble Chirammal <hchiramm@redhat.com>
-
Wojciech Tyczynski authored
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 37066, 37793) correct a few spelling mistakes
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue update label filter prompt I have to look up the meaning of selector in docs/user-guide/labels.md. I think we could print more info when run "--help".
-
xilabao authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Code optimization Accept function, the same sentence information repeated three times, under the optimization, recorded in the call function
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue check the value of min and max in kubectl check the value of min and max in kubectl.
-
- 04 Dec, 2016 2 commits
-
-
Marcin Wielgus authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Implement GID security for the GlusterFS dynamic provisioner. <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: This PR implements GID security for the glusterfs dynamic provisioner. It is a reworked version of PR #37549 . <!-- **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: --> **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note The glusterfs dynamic volume provisioner will now choose a unique GID for new persistent volumes from a range that can be configured in the storage class with the "gidMin" and "gidMax" parameters. The default range is 2000 - 4294967295 (max uint32). ```
-