1. 22 Mar, 2017 3 commits
  2. 21 Mar, 2017 23 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #38937 from nak3/reserved-example · 2b6e318e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Use realistic value for the memory example of kube-reserved and system-reserved
      
      Use realistic value for the memory example of kube-reserved and system-reserved
      
      Currently, kublet help shows the memory example of
      kube-reserved and system-reserved as 150G. This 150G is not realistic
      value and it leads misconfiguration or confusion. This patch changes
      to example value as 500Mi.
      
      Before(same with system-reserved):
      ```
            --kube-reserved value                                A set of ResourceName=ResourceQuantity (e.g. cpu=200m,memory=150G) pairs that describe resources reserved for kubernetes system components. Currently only cpu and memory are supported. See http://releases.k8s.io/HEAD/docs/user-guide/compute-resources.md for more detail. [default=none]
      ```
      
      After(same with system-reserved):
      ```
            --kube-reserved value                                A set of ResourceName=ResourceQuantity (e.g. cpu=200m,memory=500Mi) pairs that describe resources reserved for kubernetes system components. Currently only cpu and memory are supported. See http://releases.k8s.io/HEAD/docs/user-guide/compute-resources.md for more detail. [default=none]
      ```
      2b6e318e
    • Kubernetes Submit Queue's avatar
      Merge pull request #42715 from DirectXMan12/bug/infinite-hpa · eb771444
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Rate limit HPA controller to sync period
      
      Since the HPA controller pulls information from an external source that
      makes no guarantees about consistency, it's possible for the HPA
      to get into an infinite update loop -- if the metrics change with
      every query, the HPA controller will run it's normal reconcilation,
      post a status update, see that status update itself, fetch new metrics,
      and if those metrics are different, post another status update, and
      repeat.  This can lead to continuously updating a single HPA.
          
      By rate-limiting each HPA to once per sync interval, we prevent this
      from happening.
      
      **Release note**:
      ```release-note
      NONE
      ```
      eb771444
    • Kubernetes Submit Queue's avatar
      Merge pull request #43462 from csbell/federation-up-timeout · 827591cc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [Federation][e2e] Ensure kubefed times out in federation-up.sh
      
      Although this should eventually be moved into kubefed itself, monitor kubefed from federation-up.sh and force it to timeout after being unable to initialize. The motivating factor here is to ensure that CI can timeout after a reasonable attempt at trying to initialize the FCP.
      827591cc
    • Piotr Szczesniak's avatar
      Renamed fluentd-ds-ready annotation · 8968ac5c
      Piotr Szczesniak authored
      8968ac5c
    • Kubernetes Submit Queue's avatar
      Merge pull request #43458 from mwielgus/ca-0.5.0 · 63d8e244
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43422, 43458)
      
      Bump Cluster Autoscaler version to 0.5.0
      
      **What this PR does / why we need it**:
      
      This PR bumps Cluster Autoscaler version to 0.5.0. The version is the same as 0.5.0-beta2 (from the code perspective). We are just removing the -beta2 tag from the image. 
      
      **Release note**:
      None.
      
      cc: @MaciekPytel @fgrzadkowski @wojtek-t
      63d8e244
    • Kubernetes Submit Queue's avatar
      Merge pull request #43422 from liggitt/convert-null-list · 51beb16e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Ensure slices are serialized as zero-length, not null
      
      Fixes https://github.com/kubernetes/kubernetes/issues/43203 null serialization of slices to prevent NPE errors in clients that store and expect to receive non-null JSON values in these fields.
      
      Ensures when we are converting to an external slice field that will be serialized even if empty (has `json` tag that does not include `omitempty`), we populate it with `[]`, not `nil`
      
      Other places I considered putting this logic instead:
      
      * When unmarshaling
        * Would have to be done for both protobuf and ugorji
        * Would still have to be done here (or on marshal) to handle cases where we construct objects to return
      * When marshaling
        * Would have to switch to use custom json marshaler (currently we use stdlib)
      * When defaulting
        * Defaulting isn't run on some fields, notably, pod template in rc/deployment spec
        * Would still have to be done here (or on marshal) to handle cases where we construct objects to return
      
      ```release-note
      API fields that previously serialized null arrays as `null` and empty arrays as `[]` no longer distinguish between those values and always output `[]` when serializing to JSON.
      ```
      51beb16e
    • Kubernetes Submit Queue's avatar
      Merge pull request #43427 from liggitt/default-toleration · edbc9f9c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Keep ResourceQuota admission at the end of the chain
      
      Fixes #43426 
      
      Moves DefaultTolerationSeconds admission prior to ResourceQuota to keep it at the end of the chain
      edbc9f9c
    • Kubernetes Submit Queue's avatar
      Merge pull request #43441 from crassirostris/bump-fluentd-gcp-memory-limit · 3d3062c1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Increase memory limit for fluentd-gcp
      
      This PR increases fluentd memory limit in fluentd-gcp addon to avoid OOMs. Request is left intact
      3d3062c1
    • Christian Bell's avatar
      [Federation][e2e] Ensure kubefed times out in federation-up.sh · 699c3ad2
      Christian Bell authored
      Although this should eventually be moved into kubefed itself, monitor kubefed from federation-up.sh and force it to timeout after being unable to initialize.
      699c3ad2
    • Marcin Wielgus's avatar
      Bump cluster autoscaler version to 0.5.0 · a3b268d6
      Marcin Wielgus authored
      a3b268d6
    • Kubernetes Submit Queue's avatar
      Merge pull request #43446 from wojtek-t/fix_restore_from_backup_script · 0a6d82d8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix restore-from-backup.sh script
      0a6d82d8
    • Kubernetes Submit Queue's avatar
      Merge pull request #43309 from MaciekPytel/ca_drain_e2e · 681ba3a6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      e2e test for cluster-autoscaler draining node
      
      **What this PR does / why we need it**:
      Adds an e2e test for Cluster-Autoscaler removing a node with a pod running (by rescheduling the pod).
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      @mwielgus can you take a look?
      
      **Release note**:
      
      ```release-note
      ```
      681ba3a6
    • Wojciech Tyczynski's avatar
      Fix restore-from-backup.sh script · 41b3db0f
      Wojciech Tyczynski authored
      41b3db0f
    • Mik Vyatskov's avatar
      Increate memory limit for fluentd-gcp · 48e750f5
      Mik Vyatskov authored
      48e750f5
    • Kubernetes Submit Queue's avatar
      Merge pull request #43415 from thockin/fix-nodeport-close-wait · 1e5fa8fe
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Install a REJECT rule for nodeport with no backend
      
      Rather than actually accepting the connection, REJECT.  This will avoid
      CLOSE_WAIT.
      
      Fixes #43212
      
      
      @justinsb @felipejfc @spiddy
      1e5fa8fe
    • Jordan Liggitt's avatar
      bc539151
    • Tim Hockin's avatar
      Install a REJECT rule for nodeport with no backend · 2ec87999
      Tim Hockin authored
      Rather than actually accepting the connection, REJECT.  This will avoid
      CLOSE_WAIT.
      2ec87999
    • Jordan Liggitt's avatar
      Update client-go · 7ceeee86
      Jordan Liggitt authored
      7ceeee86
    • Jordan Liggitt's avatar
      generated files · 939ca532
      Jordan Liggitt authored
      939ca532
    • Jordan Liggitt's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #43411 from csbell/test-timeouts-cleanup · e3f6f14b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Unify test timeouts under a common name.
      
      Some timeouts were too aggressive and since we've slowly been moving every controller to 5 minutes, consolidate everyone under ``federatedDefaultTestTimeout``. To aid in debugging some service-related issues, if a service cannot be deleted, we issue a kubectl describe on it prior to failing.
      e3f6f14b
    • Kubernetes Submit Queue's avatar
      Merge pull request #43414 from Random-Liu/use-uid-in-config · e09fda63
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Use uid in config.go instead of pod full name.
      
      For https://github.com/kubernetes/kubernetes/issues/43397.
      
      In config.go, use pod uid in pod cache.
      
      Previously, if we update the static pod, even though a new UID is generated in file.go, config.go will only reference the pod with pod full name, and never update the pod UID in the internal cache. This causes:
      1) If we change container spec, kubelet will restart the corresponding container because the container hash is changed.
      2) If we change pod spec, kubelet will do nothing.
      
      With this fix, kubelet will always restart pod whenever pod spec (including container spec) is changed.
      
      @yujuhong @bowei @dchen1107 
      /cc @kubernetes/sig-node-bugs
      e09fda63
    • Kubernetes Submit Queue's avatar
      Merge pull request #43337 from janetkuo/ds-template-semantic-deepequal · 4974a058
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Use Semantic.DeepEqual to compare DaemonSet template on updates
      
      Switch to `Semantic.DeepEqual` when comparing templates on DaemonSet updates, since we can't distinguish between `null` and `[]` in protobuf. This avoids unnecessary DaemonSet pods restarts. 
      
      I didn't touch `reflect.DeepEqual` used in controller because it's close to release date, and the DeepEqual in the controller doesn't cause serious issues (except for maybe causing more enqueues than needed). 
      
      Fixes #43218 
      
      @liggitt @kargakis @lukaszo @kubernetes/sig-apps-pr-reviews
      4974a058
  3. 20 Mar, 2017 14 commits
    • Random-Liu's avatar
      fbc320af
    • Kubernetes Submit Queue's avatar
      Merge pull request #43399 from derekwaynecarr/fix_node_e2e · e4536e85
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42452, 43399)
      
      Fix faulty assumptions in summary API testing
      
      **What this PR does / why we need it**:
      1. on systemd, launch kubelet in dedicated part of cgroup hierarchy
      1. bump allowable memory usage for busy box containers as my own local testing often showed values > 1mb which were valid per the memory limit settings we impose
      1. there is a logic flaw today in how we report node.memory.stats that needs to be fixed in follow-on.
      
      for the last issue, we look at `/sys/fs/cgroup/memory.stat[rss]` value which if you have global accounting enabled on systemd machines (as expected) will report 0 because nothing runs local to the root cgroup.  we really want to be showing the total_rss value for non-leaf cgroups so we get the full hierarchy of usage.
      e4536e85
    • Kubernetes Submit Queue's avatar
      Merge pull request #42452 from jingxu97/Mar/nodeNamePrefix · a2d74cda
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42452, 43399)
      
      Modify getInstanceByName to avoid calling getInstancesByNames
      
      This PR modify getInstanceByname to loop through all management zones
      directly instead of calling getInstancesByNames. Currently
      getInstancesByNames use a node name prefix as a filter to list the
      instances. If the prefix does not match, it will return all instances
      which is very wasteful since getInstanceByName only query one instance
      with a specific name.
      
      Partially fix issue #42445
      a2d74cda
    • Christian Bell's avatar
      Unify test timeouts under a common name. · 273eb6b9
      Christian Bell authored
      273eb6b9
    • Janet Kuo's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #43368 from feiskyer/dns-policy · 948e3754
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43398, 43368)
      
      CRI: add support for dns cluster first policy
      
      **What this PR does / why we need it**:
      
      PR #29378 introduces ClusterFirstWithHostNet policy but only dockertools was updated to support the feature. 
      
      This PR updates kuberuntime to support it for all runtimes.
      
      
      **Which issue this PR fixes** 
      
      fixes #43352
      
      **Special notes for your reviewer**:
      
      Candidate for v1.6.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      cc @thockin @luxas @vefimova @Random-Liu
      948e3754
    • Kubernetes Submit Queue's avatar
      Merge pull request #43398 from enisoc/deletion-race-flake · bc82d87f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Deflake TestSyncDeploymentDeletionRace
      
      **What this PR does / why we need it**:
      
      The cache was sometimes catching up while we were testing the case
      where the cache is not yet caught up.
      
      Before this fix, I could reproduce the failure with the following
      command. After the fix, it passes.
      
      ```
      go test -count 100000 -run TestSyncDeploymentDeletionRace
      ```
      
      I checked the other controllers, and they all were already not starting informers for the deletion race test. I also checked that the deletion race tests for other controllers all pass with `-count 100000`.
      
      **Which issue this PR fixes**:
      
      Fixes #43390
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      bc82d87f
    • Kubernetes Submit Queue's avatar
      Merge pull request #43370 from feiskyer/port-mapping · e668ee11
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42659, 43370)
      
      dockershim: process protocol correctly for port mapping
      
      **What this PR does / why we need it**:
      
      dockershim: process protocol correctly for port mapping.
      
      **Which issue this PR fixes** 
      
      Fixes #43365.
      
      **Special notes for your reviewer**:
      
      Should be included in v1.6.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      cc/ @Random-Liu @justinsb @kubernetes/sig-node-pr-reviews
      e668ee11
    • Kubernetes Submit Queue's avatar
      Merge pull request #42659 from enisoc/controller-ref-rc-rs · e1b4d034
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42659, 43370)
      
      RC/RS: Fixes for ControllerRef.
      
      **What this PR does / why we need it**:
      
      This fixes some issues with RC/RS ControllerRef handling that were brought up in reviews for other controller types, after #41984 was merged. See the individual commit messages for details.
      
      **Which issue this PR fixes**:
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      ```
      e1b4d034
    • Derek Carr's avatar
      Fix faulty assumptions in summary API testing · 5c8b9577
      Derek Carr authored
      5c8b9577
    • Anthony Yeh's avatar
      Deflake TestSyncDeploymentDeletionRace · 0b923364
      Anthony Yeh authored
      The cache was sometimes catching up while we were testing the case
      where the cache is not yet caught up.
      
      Before this fix, I could reproduce the failure with the following
      command. After the fix, it passes.
      
      ```
      go test -count 100000 -run TestSyncDeploymentDeletionRace
      ```
      0b923364
    • Anthony Yeh's avatar
      c74aab64
    • Anthony Yeh's avatar
      RC/RS: Check that ControllerRef UID matches found controller. · f4ee44eb
      Anthony Yeh authored
      Otherwise, we may confuse a former controller by that name with a new
      one that has the same name.
      f4ee44eb
    • Maciej Pytel's avatar
      7f9b3b63