1. 04 Jan, 2017 40 commits
    • Jordan Liggitt's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #38844 from nikhiljindal/fednewkubectlTests · 6b702115
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Adding test-federation-cmd.sh to test kubectl with federation apiserver
      
      There are 2 parts to the PR:
      * Adding ability to run kubectl tests for a subset of resources.
      * Adding test-federation-cmd.sh that runs kubectl tests for resources that are supported by federation-apiserver.
      
      cc @kubernetes/sig-federation @kubernetes/sig-api-machinery 
      
      ```release-note
      Adding kubectl tests for federation
      ```
      6b702115
    • Kubernetes Submit Queue's avatar
      Merge pull request #39384 from deads2k/generic-01-start-staging · 5ee52e8b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Start moving genericapiserver to staging
      
      This moves `pkg/auth/user` to `staging/k8s.io/genericapiserver/pkg/authentication/user`.  I'll open a separate pull into the upstream gengo to support using `import-boss` on vendored folders to support staging.
      
      After we agree this is the correct approach and see everything build, I'll start moving other packages over which don't have k8s.io/kubernetes deps.
      
      @kubernetes/sig-api-machinery-misc @lavalamp 
      @sttts @caesarxuchao ptal
      5ee52e8b
    • nikhiljindal's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #39330 from foolusion/fix-labels-Parse-go-doc · d12d012a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      pkg/labels: fix the godoc for Parse()
      
      previously the formatting was broken for labels.Parse() function. I
      fixed the spacing so it will format correctly for the generated go docs.
      There was also a dangling "]" at the end of the first line so i deleted
      it.
      
      
      
      **What this PR does / why we need it**:
      
      This fixes a formatting issue with the generated go documentation.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*:
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      d12d012a
    • Kubernetes Submit Queue's avatar
      Merge pull request #39399 from zhouhaibing089/namespace-controller · ee47db8c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      make discovery static when extensions/thirdpartyresources is not enabled
      
      this should be a bug fix, if `extensions/thirdpartyresources` is enabled, the result of `Discovery().ServerPreferredNamespacedResources` will be dynamic then, so we are making the `discoverResourcesFn` static only when the `extensions/thirdpartyresources` is not enabled.
      ee47db8c
    • Kubernetes Submit Queue's avatar
      Merge pull request #39359 from tianshapjq/add-top-specification · 17f8d82f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add some specifications on the top command
      
      **What this PR does / why we need it**:
      the top command is available when heapster works fine on the server, but the specifications doesn't mention about this. So I added some specifications here.
      17f8d82f
    • Kubernetes Submit Queue's avatar
      Merge pull request #39400 from xilabao/fix-wrong-help-message-for-taint · ee03b9b2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39409, 39400)
      
      fix wrong help message for taint
      
      fix #39381
      ee03b9b2
    • Kubernetes Submit Queue's avatar
      Merge pull request #39409 from NickrenREN/apiserver-drop-err · 7d31bf46
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39409, 39400)
      
      remove newAPIGroupVersion() and getAPIGroupVersion() second return value
      7d31bf46
    • deads2k's avatar
      mechanical changes for move · ca58ec02
      deads2k authored
      ca58ec02
    • deads2k's avatar
      move pkg/auth/user to staging · 442d2c14
      deads2k authored
      442d2c14
    • Kubernetes Submit Queue's avatar
      Merge pull request #39306 from hex108/oom_score_adj · 2cc9650e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38084, 39306)
      
      Small improve for GetContainerOOMScoreAdjust
      
      In `GetContainerOOMScoreAdjust`, make logic more clear for the case `oomScoreAdjust >= besteffortOOMScoreAdj`. If `besteffortOOMScoreAdj`  is defined to another value(e.g. 996), suppose `oomScoreAdjust` is 999, the function will return 998(which equals 999 - 1) instead of 995(996 -1).
      2cc9650e
    • Kubernetes Submit Queue's avatar
      Merge pull request #38084 from tanshanshan/fix-little1 · bd100b3b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix comment and optimize code
      
      **What this PR does / why we need it**:
      
      Fix comment and optimize code.
      
      Thanks.
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      bd100b3b
    • Kubernetes Submit Queue's avatar
      Merge pull request #39355 from kargakis/update-rc-manager · 38d57e5a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Share rc cache from the rc manager
      
      @kubernetes/sig-apps-misc @hodovska
      38d57e5a
    • Kubernetes Submit Queue's avatar
      Merge pull request #39204 from peay/cronjob-active-forever · f143ce01
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove jobs that do not exist from active list of CronJob
      
      **What this PR does / why we need it**: This PR modifies the controller for CronJob to remove from the active job list any job that does not exist anymore, to avoid staying blocked in active state forever. See #37957.
      
      **Which issue this PR fixes**: fixes #37957 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      ```
      f143ce01
    • Kubernetes Submit Queue's avatar
      Merge pull request #39371 from php-coder/fix_local_up_cluster_msg · e3c3b2ad
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39405, 39371)
      
      hack/local-up-cluster.sh: fix typo in error message
      
      This commit fixes typo in error message and also removes stale comment from `hack/local-up-cluster.sh`.
      e3c3b2ad
    • Kubernetes Submit Queue's avatar
      Merge pull request #39405 from gnufied/fix-kubefed-cluster-ip-bug · 7d8f29b6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 36087, 39405)
      
      federation-apiserver doesn't needs cluster-ip range
      
      This option has been removed from genericserver options
      and it is not being used by federation-apiserver anyways.
      
      Fixes - #39388
      7d8f29b6
    • tanshanshan's avatar
      fix comment and so on · d1fd1d35
      tanshanshan authored
      d1fd1d35
    • Kubernetes Submit Queue's avatar
      Merge pull request #36087 from ericchiang/plugin-auth-oidc-verify-email · 016133cf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      oidc auth-n plugin: enforce email_verified claim
      
      This change causes the OpenID Connect authenticator to start
      enforcing the 'email_verified' claim.
      
      https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
      
      If the OIDC authenticator uses the 'email' claim as a user's username
      and the 'email_verified' is not set to `true`, reject that authentication attempt.
      
      cc @erictune @kubernetes/sig-auth @mlbiam
      
      ```release-note
      When using OIDC authentication and specifying --oidc-username-claim=email, an `"email_verified":true` claim must be returned from the identity provider.
      ```
      016133cf
    • Kubernetes Submit Queue's avatar
      Merge pull request #39219 from liggitt/swagger-discovery · 2bad7e6b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Include swaggerapi urls in system:discovery role
      
      Used by client side API validation and for client schema generation
      2bad7e6b
    • Kubernetes Submit Queue's avatar
      Merge pull request #38687 from ivan4th/remove-dockerlegacyservice-comment-from-kubelet · 9b726d6b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove DockerLegacyService comment from kubelet
      9b726d6b
    • Kubernetes Submit Queue's avatar
      Merge pull request #36245 from fraenkel/env_configmap · 819535b9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38433, 36245)
      
      Allow pods to define multiple environment variables from a whole ConfigMap
      
      Allow environment variables to be populated from ConfigMaps
      
      - ConfigMaps represent an entire set of EnvVars
      - EnvVars can override ConfigMaps
      
      
      fixes #26299
      819535b9
    • Kubernetes Submit Queue's avatar
      Merge pull request #38433 from yuanying/remove-needless-config · b202ebb7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38433, 36245)
      
      Remove needless env var in OpenStack provider
      
      **What this PR does / why we need it**:
      
      If we use openstack provider to set up k8s cluster using kube-up script,
      `TENANT_ID` environment variable is needed.
      But to configure `TENANT_ID` is very annoying because this value is not static by each env.
      This patch uses `TENANT_NAME` instead of `TENANT_ID`
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      
      Since `TENANT_NAME` is unique if we use keystone v2 api,
      so `TENANT_ID` is not needed if `TENANT_NAME` is provided
      to configure OpenStack provider.
      And also to set `TENANT_ID` is annoying to develop, because
      `TENANT_ID` is not static by each environment.
      This patch remove dependency of `TENANT_ID` and simply use
      `TENANT_NAME`.
      b202ebb7
    • NickrenREN's avatar
      remove newAPIGroupVersion() and getAPIGroupVersion() second return value · a3def910
      NickrenREN authored
      Since newAPIGroupVersion() and getAPIGroupVersion() will never return err,we do not need that
      a3def910
    • Kubernetes Submit Queue's avatar
      Merge pull request #39193 from xilabao/add-rules-failed-message · dedec2d1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      add rules not allow message when authorize failed
      
      old result:
      ```
      # ./cluster/kubectl.sh --token=/test get po
      Error from server (Forbidden): User "" cannot list pods in the namespace "default".: "<nil>" (get pods)
      ```
      new result:
      ```
      # ./cluster/kubectl.sh --token=/test get po
      Error from server (Forbidden): User "" cannot list pods in the namespace "default".: "rules not allow" (get pods)
      ```
      
      test.yaml
      ```
      kind: Role
      apiVersion: rbac.authorization.k8s.io/v1alpha1
      metadata:
        name: test
      rules:
      - apiGroups: ["*"]
        verbs: ["create"]
        resources: ["*"]
      ---
      kind: RoleBinding
      apiVersion: rbac.authorization.k8s.io/v1alpha1
      metadata:
        name: admin-resource-binding
      subjects:
        - kind: Group
          name: test
      roleRef:
        kind: Role
        name: test
      ```
      dedec2d1
    • Hemant Kumar's avatar
      federation-apiserver doesn't needs cluster-ip range · b09c740f
      Hemant Kumar authored
      This option has been removed from genericserver options
      and it is not being used by federation-apiserver anyways.
      
      Fixes - #39388
      b09c740f
    • xilabao's avatar
      9b38eaf9
    • Kubernetes Submit Queue's avatar
      Merge pull request #39367 from jsafrane/sudo · f95362f9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39284, 39367)
      
      e2e: Use sudo to start/stop kubelet service
      
      It seems that user 'jenkins' does not have permissions to manage services. sudo is already used to e.g. check iptables in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/service.go#L402
      
      Fixes #37956
      f95362f9
    • Kubernetes Submit Queue's avatar
      Merge pull request #39284 from bowei/remove-host-record · 064132d8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39284, 39367)
      
      Remove HostRecord annotation (beta feature)
      
      The annotation has made it to GA so this code should be deleted.
      
      **Release note**:
      ```release-note
      The 'endpoints.beta.kubernetes.io/hostnames-map' annotation is no longer supported.  Users can use the 'Endpoints.subsets[].addresses[].hostname' field instead.
      ```
      064132d8
    • xilabao's avatar
      fix wrong help message for taint · a8b15492
      xilabao authored
      a8b15492
    • zhouhaibing089's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #39313 from MrHohn/e2e-service-util · 3a260582
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39280, 37350, 39389, 39390, 39313)
      
      Moves e2e service util functions into service_util.go and cleans up
      
      Basically moves codes into a central place for service util functions.
      
      Some other codes are touched mostly only due to this migration. Also put a bunch of network reachability utils functions into network_utils.go. They seem somehow redundant, may consider combine they later.
      
      @bowei @freehan
      3a260582
    • Kubernetes Submit Queue's avatar
      Merge pull request #39390 from zmerlynn/fix-aws-certs · 834dda03
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39280, 37350, 39389, 39390, 39313)
      
      Fix AWS break injected by #39020
      
      Shuffle the `download-cfssl` to `cluster/common.sh` (broken in #39020)
      834dda03
    • Kubernetes Submit Queue's avatar
      Merge pull request #39389 from mikedanese/kubeadm-fix · d0e16055
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39280, 37350, 39389, 39390, 39313)
      
      kubeadm: readd --api-port, accidentally removed during refactor.
      
      this broke stuff
      d0e16055
    • Kubernetes Submit Queue's avatar
      Merge pull request #37350 from chentao1596/delete-meaningless-judgments · fe391d7b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39280, 37350, 39389, 39390, 39313)
      
      delete meaningless judgments
      
      What this PR does / why we need it:
            Whether "err" is nil or not, "err" can be return, so the judgment "err !=nil " is unnecessary
      fe391d7b
    • Kubernetes Submit Queue's avatar
      Merge pull request #39280 from luxas/kubeadm_api_proto · 27850a79
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39280, 37350, 39389, 39390, 39313)
      
      Refactor the certificate and kubeconfig code in the kubeadm binary into two phases
      
      **What this PR does / why we need it**:
      
      First stab at refactoring kubeadm code into logically independent phases.
      This defines two phases in the kubeadm init process:
       - certs: Takes some API values as input (the API will be refactored in a later PR), and generates certificates in the pki directory
       - kubeconfig: Takes the pki directory and the endpoint where the master is located and produces two kubeconfig files: admin.conf and kubelet.conf
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*:
      Required long-term for graduating our API
      
      **Special notes for your reviewer**:
      
      ### Old sample output
      The earlier kubeconfig code had a bug in it; see this example:
      _admin.conf:_
      ```yaml
      apiVersion: v1
      clusters:
      - cluster:
          certificate-authority-data: <data>
          server: https://192.168.200.x:6443
        name: kubernetes
      contexts:
      - context:
          cluster: kubernetes
          user: admin
        name: admin@kubernetes
      - context:
          cluster: kubernetes
          user: kubelet
        name: kubelet@kubernetes
      current-context: admin@kubernetes
      kind: Config
      preferences: {}
      users:
      - name: admin
        user:
          client-certificate-data: <data>
          client-key-data: <data>
      - name: kubelet
        user:
          client-certificate-data: <data>
          client-key-data: <data>
      ```
      kubelet.conf:
      ```yaml
      apiVersion: v1
      clusters:
      - cluster:
          certificate-authority-data: <data>
          server: https://192.168.200.x:6443
        name: kubernetes
      contexts:
      - context:
          cluster: kubernetes
          user: admin
        name: admin@kubernetes
      - context:
          cluster: kubernetes
          user: kubelet
        name: kubelet@kubernetes
      current-context: admin@kubernetes
      kind: Config
      preferences: {}
      users:
      - name: admin
        user:
          client-certificate-data: <data>
          client-key-data: <data>
      - name: kubelet
        user:
          client-certificate-data: <data>
          client-key-data: <data>
      ```
      ```console
      $ shasum /etc/kubernetes/*.conf
      2b22b25cc4c97e5619ece6c43badf42b87c4970a  /etc/kubernetes/admin.conf
      2b22b25cc4c97e5619ece6c43badf42b87c4970a  /etc/kubernetes/kubelet.conf
      ```
      
      #### New output
      admin.conf
      ```yaml
      apiVersion: v1
      clusters:
      - cluster:
          certificate-authority-data: <data>
          server: https://192.168.200.x:6443
        name: kubernetes
      contexts:
      - context:
          cluster: kubernetes
          user: admin
        name: admin@kubernetes
      current-context: admin@kubernetes
      kind: Config
      preferences: {}
      users:
      - name: admin
        user:
          client-certificate-data: <data>
          client-key-data: <data>
      ```
      kubelet.conf
      ```yaml
      apiVersion: v1
      clusters:
      - cluster:
          certificate-authority-data: <data>
          server: https://192.168.200.x:6443
        name: kubernetes
      contexts:
      - context:
          cluster: kubernetes
          user: kubelet
        name: kubelet@kubernetes
      current-context: kubelet@kubernetes
      kind: Config
      preferences: {}
      users:
      - name: kubelet
        user:
          client-certificate-data: <data>
          client-key-data: <data>
      ```
      
      **Release note**:
      
      ```release-note
      Refactor the certificate and kubeconfig code in the kubeadm binary into two phases
      ```
      
      PTAL @dgoodwin @jbeda @mikedanese @errordeveloper @pipejakob @lukemarsden
      27850a79
    • Kubernetes Submit Queue's avatar
      Merge pull request #39273 from NickrenREN/kubelet-node-status · 9eaf1aa3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39001, 39104, 35978, 39361, 39273)
      
      delete SetNodeStatus() function and fix some function notes words
      9eaf1aa3
    • Kubernetes Submit Queue's avatar
      Merge pull request #39361 from zdj6373/util-log · 85545992
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39001, 39104, 35978, 39361, 39273)
      
      Log error modification
      
      controller_utils.go:  Log content is wrong, modify
      85545992
    • Kubernetes Submit Queue's avatar
      Merge pull request #35978 from fabianofranz/cors_with_patch_method · a70ad9f4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39001, 39104, 35978, 39361, 39273)
      
      Allow PATCH in an API CORS setup
      
      Allows the PATCH method to be used in a REST API CORS setup.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a70ad9f4
    • Kubernetes Submit Queue's avatar
      Merge pull request #39104 from deads2k/api-57-admission-all-initializers · 94d4ba7c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 39001, 39104, 35978, 39361, 39273)
      
      refactored admission to avoid internal client references
      
      Refactored admission to avoid internal client references.  This required switching to plugin initializers for them.  And that required some rewiring of the plugin initializers. 
      
      Technically I can decouple from the other two commits, but I'm optimistic that those will go through easy. This is slightly move invasive, but I'd like to shoot for pre-christmas to avoid new admission plugins coming through and breaking bits.
      
      @sttts @derekwaynecarr
      94d4ba7c