1. 01 Oct, 2017 1 commit
  2. 25 Sep, 2017 3 commits
  3. 24 Sep, 2017 36 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #52835 from FengyunPan/Versionless-Endpoint · 4f2d7b93
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Update gophercloud to Handle New Identity Endpoints
      
      Currently openstack cloud provider just support keystone v2.0 and v3
      The latest Identity Service is publishing an ID of v3.8, we should
      update gophercloud to recognize v3.8 as a valid version id.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52830
      
      **Release note**:
      ```release-note
      NONE
      ```
      4f2d7b93
    • Kubernetes Submit Queue's avatar
      Merge pull request #52886 from surajnarwade/remove-unused · 5f8726e4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Cleaning up unused functions in /pkg/controller/deployment/util
      5f8726e4
    • Kubernetes Submit Queue's avatar
      Merge pull request #52609 from FengyunPan/register-internal-ip · 0ce1cc99
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52751, 52898, 52633, 52611, 52609). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Only register floatingIP for external loadbalancer service
      
      If the user has provided the floating-ip options, then it's safe
      to assume they want (only) the floating-ip to be the ingress IP;
      if they have not provided floating-ip options, then the LB IP is
      the only relevant value.
      
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Fix #52566
      
      **Release note**:
      ```release-note
      Only register floatingIP into Loadbalancer ingress field for external loadbalancer service
      ```
      0ce1cc99
    • Kubernetes Submit Queue's avatar
      Merge pull request #52611 from FengyunPan/missing-floatingip · 1e364804
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52751, 52898, 52633, 52611, 52609). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Fix missing floatingip when calling GetLoadBalancer()
      
      If user specify floating-network-id, a floatingip and a vip will
      be assigned to LoadBalancer service, So its status contains a
      floatingip and a vip, but GetLoadBalancer() only return vip.
      
      **Release note**:
      ```release-note
      GetLoadBalancer() only return floatingip when user specify floating-network-id, or return LB vip.
      ```
      1e364804
    • Kubernetes Submit Queue's avatar
      Merge pull request #52633 from karataliu/ccm_defaultrrp · 19af5de8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52751, 52898, 52633, 52611, 52609). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Add default value for RouteReconciliationPeriod in cloud controller manager
      
      **What this PR does / why we need it**:
      Add default sync period value config for RouteReconciliationPeriod. For now the default value is 0, which means zero cooldown time.
      
      The value is taken from kube-controller-manager:
      https://github.com/kubernetes/kubernetes/blob/b2b079b95a867b560fd327cba56e7d3878f43dc3/cmd/kube-controller-manager/app/options/options.go#L73
      
      **Which issue this PR fixes**
      
      **Special notes for your reviewer**:
      
      **Release note**:
      19af5de8
    • Kubernetes Submit Queue's avatar
      Merge pull request #52898 from jianglingxia/jlx-92216 · b7c36dc7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52751, 52898, 52633, 52611, 52609). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      fix error of func TestValidateStatefulSet that updateStrategy
      
      **What this PR does / why we need it**:
      spec.updateStrategy.rollingUpdate.partition,but spec.updateStrategy.rollingUpate need "d"
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b7c36dc7
    • Kubernetes Submit Queue's avatar
      Merge pull request #52751 from MrHohn/e2e-service-cleanup-fix · 8c29b654
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Fix GCE LB resource cleanup for service e2e tests.
      
      **What this PR does / why we need it**: Fix GCE LB resource cleanup logic.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52347
      
      **Special notes for your reviewer**:
      /assign @shyamjvs @nicksardo 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8c29b654
    • FengyunPan's avatar
      Update gophercloud to Handle New Identity Endpoints · f98326b7
      FengyunPan authored
      Currently openstack cloud provider just support keystone v2.0 and v3
      The latest Identity Service is publishing an ID of v3.8, we should
      update gophercloud to recognize v3.8 as a valid version id.
      f98326b7
    • Kubernetes Submit Queue's avatar
      Merge pull request #52864 from dcbw/dockershim-fix-net-teardown · fc8a647f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      dockershim: fine-tune network-ready handling on sandbox teardown and removal
      
      If sandbox teardown results in an error, GC will periodically attempt
      to again remove the sandbox.  Until the sandbox is removed, pod
      sandbox status calls will attempt to enter the pod's namespace and
      retrieve the pod IP, but the first teardown attempt may have already
      removed the network namespace, resulting in a pointless log error
      message that the network namespace doesn't exist, or that nsenter
      can't find eth0.
      
      The network-ready mechanism originally attempted to suppress those
      messages by ensuring that pod sandbox status skipped network checks
      when networking was already torn down, but unfortunately the ready
      value was cleared too early.
      
      Also, don't tear down the pod network multiple times if the first
      time we tore it down, it succeeded.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      fc8a647f
    • Kubernetes Submit Queue's avatar
      Merge pull request #52929 from krousey/gciupgrades · 0dc096a9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Add cos as an alias for gci in the upgrade script
      
      This was causing some issues when upgrading from a GCI image. This is the same conversion happening in config-defaults.sh.
      
      https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-stable2-stable1-upgrade-cluster-new/205
      
      The node image was being left at COS, and when we  went to build the kube-env, we only check against "gci". This caused us to not fully construct the environment for nodes and then they couldn't fully come up after an upgrade.
      
      I've already fixed the CI test suites to explicitly specify "gci", but this auto-detection logic should be fixed too.
      
      Fixes: #52930
      0dc096a9
    • Kubernetes Submit Queue's avatar
      Merge pull request #52885 from xiangpengzhao/dns-remove-useless · 70af5efb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Don't need to check useAnnotation in dns e2e test
      
      **What this PR does / why we need it**:
      hostname/subdomain annotations were removed in #44137. This PR removes the check.
      Also, `var dnsServiceLabelSelector` is not used anymore.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      ref: https://github.com/kubernetes/kubernetes/pull/44137
      
      **Special notes for your reviewer**:
      /cc @bowei @MrHohn 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      70af5efb
    • Kubernetes Submit Queue's avatar
      Merge pull request #52761 from yuexiao-wang/validate-message · 63c1ed12
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Adjust the validating messages
      Signed-off-by: 's avataryuexiao-wang <wang.yuexiao@zte.com.cn>
      
      **What this PR does / why we need it**:
      1.  Adjust the validating messages for user understanding 
      2.  Add error messages for easliy testing.
      3.  Optimize the  code for switch case.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      63c1ed12
    • Kubernetes Submit Queue's avatar
      Merge pull request #52855 from NickrenREN/remove-rackspace · 8e7f5d8c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52880, 52855, 52761, 52885, 52929). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Remove cloud provider rackspace
      
      **What this PR does / why we need it**:
      For now, we have to implement functions in both `rackspace` and `openstack` packages if we want to add function for cinder, for example [resize for cinder](https://github.com/kubernetes/kubernetes/pull/51498).  Since openstack has implemented all the functions rackspace has,  and rackspace is considered deprecated for a long time, [rackspace deprecated](https://github.com/rackspace/gophercloud/issues/592) ,
      after talking with @mikedanese  and @jamiehannaford offline ,  i sent this PR to remove `rackspace` in favor of `openstack`
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52854
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      The Rackspace cloud provider has been removed after a long deprecation period. It was deprecated because it duplicates a lot of the OpenStack logic and can no longer be maintained. Please use the OpenStack cloud provider instead.
      ```
      8e7f5d8c
    • Kubernetes Submit Queue's avatar
      Merge pull request #52880 from xiangpengzhao/dns-e2e-aws · 72a83c33
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Allow dns e2e test case for ExternalName to run on aws
      
      **What this PR does / why we need it**:
      #52840 uses allocated clusterIP instead of hard-coded one. So we don't need to care about the clusterIP range of the CI job config. Let it run on pull-kubernetes-e2e-kops-aws
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47224
      
      **Special notes for your reviewer**:
      ref: https://github.com/kubernetes/test-infra/pull/4462
      
      /cc @bowei @MrHohn @justinsb 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      72a83c33
    • Kubernetes Submit Queue's avatar
      Merge pull request #52873 from ixdy/bazel-cleanup · 7c9e614c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      bazel: build/test almost everything
      
      **What this PR does / why we need it**: Miscellaneous cleanups and bug fixes. The main motivating idea here was to make `bazel build //...` and `bazel test //...` mostly work. (There's a few reasons these still don't work, but we're a lot closer.)
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /assign @BenTheElder @mikedanese @spxtr
      7c9e614c
    • Kubernetes Submit Queue's avatar
      Merge pull request #52558 from jennybuckley/master · f67e127a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52831, 52764, 52763, 52673, 52558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Allow updating objects with empty pending initializers list
      
      **What this PR does / why we need it**: When updating an object, an empty pending list should be treated as a nil initializer. This PR fixes a bug which prevented this functionality and also adds a test which will ensure this functionality is preserved.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52202
      
      **Special notes for your reviewer**:
      
      /cc @caesarxuchao
      
      **Release note**:
      
      ```release-note
      Fixes an initializer bug where update requests which had an empty pending initializers list were erroneously rejected.
      ```
      f67e127a
    • Kubernetes Submit Queue's avatar
      Merge pull request #52673 from p0lyn0mial/webhook_default_service_resolver · 7f3f9864
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52831, 52764, 52763, 52673, 52558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      default service resolver for webhook admission
      
      **What this PR does / why we need it**:
      provides a default service resolver for webhook plugin. The rationale behind is that webhook plugins names can be resolved by a dns server working inside a cluster.
      
      
      **Release note**:
      
      ```
      NONE
      ```
      7f3f9864
    • Kubernetes Submit Queue's avatar
      Merge pull request #52763 from NickrenREN/gluster-minor · 5dcd4d31
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52831, 52764, 52763, 52673, 52558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Minor fix: make sure that glusterfsPlugin implements interface ExpandableVolumePlugin
      
      Attempting an assignment to make sure that `glusterfsPlugin`  implements interface `ExpandableVolumePlugin`, just as we did for `DeletableVolumePlugin`, `PersistentVolumePlugin`
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /assign @gnufied
      5dcd4d31
    • Kubernetes Submit Queue's avatar
      Merge pull request #52764 from fate-grand-order/fix-typo · 3cab0c9f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52831, 52764, 52763, 52673, 52558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      fix typo
      3cab0c9f
    • Kubernetes Submit Queue's avatar
      Merge pull request #52831 from caiyixiang/mis_spell · d4237ec4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52831, 52764, 52763, 52673, 52558). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      correct a small spelling mistake
      d4237ec4
    • Kubernetes Submit Queue's avatar
      Merge pull request #52829 from gaocegege/fix-link · 616ce0f4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52469, 52574, 52330, 52689, 52829). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      generic_scheduler.go: Fix link in comment
      
      **What this PR does / why we need it**:
      
      Fix a link in generic_scheduler.go which is outdated
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      Signed-off-by: 's avatarCe Gao <ce.gao@outlook.com>
      616ce0f4
    • Kubernetes Submit Queue's avatar
      Merge pull request #52689 from stewart-yu/issue#07 · a5552e8d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52469, 52574, 52330, 52689, 52829). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Add test file
      
      **What this PR does / why we need it**:
      No test file for testutil.go
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a5552e8d
    • Kubernetes Submit Queue's avatar
      Merge pull request #52330 from m1093782566/ipvs-service-equal · 53640908
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52469, 52574, 52330, 52689, 52829). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Fix IPVS service Flags
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes**: 
      
      fixes #52393
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      53640908
    • Kubernetes Submit Queue's avatar
      Merge pull request #52574 from vmware/fix-kubelet-restart-tests · c2a78142
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52469, 52574, 52330, 52689, 52829). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Fixing E2E Test - After restarting kubelet test expects node's status to be NotReady
      
      **What this PR does / why we need it**:
      This PR is fixing the e2e tests involves restarting the kubelets. After the kubelet is restarted, test expect the desired state to be NotReady.
      
      After restarting the kubelet we should wait for some time and then check nodes status to be Ready.
      Node should not be checked for NotReady state, after restarting kubelet.
      
      **Which issue this PR fixes**
      fixes # https://github.com/vmware/kubernetes/issues/285
      
      **Special notes for your reviewer**:
      
      @BaluDontu @rohitjogvmw @tusharnt
      
      Test logs before fix
      -----
      STEP: Restarting kubelet
      Sep 15 11:26:32.768: INFO: Attempting sudo systemctl restart kubelet
      Sep 15 11:26:33.001: INFO: ssh root@10.162.22.205:22: command: sudo systemctl restart kubelet
      Sep 15 11:26:33.001: INFO: ssh root@10.162.22.205:22: stdout: ""
      Sep 15 11:26:33.001: INFO: ssh root@10.162.22.205:22: stderr: ""
      Sep 15 11:26:33.001: INFO: ssh root@10.162.22.205:22: exit code: 0
      Sep 15 11:26:33.002: INFO: Waiting up to 1m0s for node kubernetes-node2 condition Ready to be false
      Sep 15 11:26:33.012: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:35.023: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:37.032: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:39.041: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:41.051: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:43.061: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:45.070: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:47.080: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:49.093: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:51.105: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:53.117: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:55.128: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:57.140: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:26:59.151: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:01.158: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:03.167: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:05.180: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:07.188: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:09.210: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:11.221: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:13.231: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:15.240: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:17.249: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:19.263: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:21.272: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:23.283: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:25.309: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:27.317: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:29.327: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:31.342: INFO: Condition Ready of node kubernetes-node2 is true instead of false. Reason: KubeletReady, message: kubelet is posting ready status
      Sep 15 11:27:33.343: INFO: Node kubernetes-node2 didn't reach desired Ready condition status (false) within 1m0s
      Sep 15 11:27:33.343: INFO: Node kubernetes-node2 failed to enter NotReady state
      [AfterEach] [sig-storage] PersistentVolumes:vsphere
      
      
      Test logs after fix
      -----
      STEP: Restarting kubelet
      Sep 18 15:40:49.066: INFO: Checking if sudo command is present
      Sep 18 15:40:49.342: INFO: Checking if systemctl command is present
      Sep 18 15:40:49.573: INFO: Attempting `sudo systemctl status kubelet | grep 'Main PID'`
      Sep 18 15:40:49.733: INFO: ssh root@10.162.16.97:22: command:   sudo systemctl status kubelet | grep 'Main PID'
      Sep 18 15:40:49.733: INFO: ssh root@10.162.16.97:22: stdout:    " Main PID: 19715 (docker)\n"
      Sep 18 15:40:49.733: INFO: ssh root@10.162.16.97:22: stderr:    ""
      Sep 18 15:40:49.733: INFO: ssh root@10.162.16.97:22: exit code: 0
      Sep 18 15:40:49.733: INFO: Attempting `sudo systemctl restart kubelet`
      Sep 18 15:40:49.986: INFO: ssh root@10.162.16.97:22: command:   sudo systemctl restart kubelet
      Sep 18 15:40:49.986: INFO: ssh root@10.162.16.97:22: stdout:    ""
      Sep 18 15:40:49.986: INFO: ssh root@10.162.16.97:22: stderr:    ""
      Sep 18 15:40:49.986: INFO: ssh root@10.162.16.97:22: exit code: 0
      Sep 18 15:40:49.988: INFO: Attempting `sudo systemctl status kubelet | grep 'Main PID'`
      Sep 18 15:40:50.158: INFO: ssh root@10.162.16.97:22: command:   sudo systemctl status kubelet | grep 'Main PID'
      Sep 18 15:40:50.158: INFO: ssh root@10.162.16.97:22: stdout:    " Main PID: 25021 (docker)\n"
      Sep 18 15:40:50.158: INFO: ssh root@10.162.16.97:22: stderr:    ""
      Sep 18 15:40:50.158: INFO: ssh root@10.162.16.97:22: exit code: 0
      Sep 18 15:40:50.158: INFO: Noticed that kubelet PID is changed. Waiting for 30 Seconds for Kubelet to come back
      Sep 18 15:41:20.159: INFO: Waiting up to 1m0s for node kubernetes-node4 condition Ready to be true
      STEP: Testing that written file is accessible.
      Sep 18 15:41:20.191: INFO: Running '/Users/divyenp/github/vmware/kubernetes/_output/dockerized/bin/darwin/amd64/kubectl --server=https://10.162.0.45 --kubeconfig=/Users/divyenp/.kube/config exec --namespace=e2e-tests-pv-9j8j0 pvc-tester-3t9ds -- /bin/sh -c cat /mnt/_SUCCESS'
      Sep 18 15:41:20.855: INFO: stderr: ""
      Sep 18 15:41:20.855: INFO: 
      Sep 18 15:41:20.855: INFO: Volume mount detected on pod pvc-tester-3t9ds and written file /mnt/_SUCCESS is readable post-restart.
      
      
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      c2a78142
    • Kubernetes Submit Queue's avatar
      Merge pull request #52469 from andyzhangx/azurefile-mount-windows · 17ba22aa
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52469, 52574, 52330, 52689, 52829). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      add feature: azurefile mount on windows node
      
      **What this PR does / why we need it**:
      feature: azurefile mount on windows node. I created this new PR, close the original one(https://github.com/kubernetes/kubernetes/pull/50233) as there is a big rebase change.
      Currently only SMB(a nfs protocol) is supported for windows container in the new Windows 2016 RS3 image, and windows container in RS3 could only use New-SmbGlobalMapping cmdlet for volume mapping, "net use" command does not work for windows container.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      As there is a known blocking issue in Windows 2016 server when mounting a SMB(a NFS protocol in Windows) share on a container host and then bind that share to a container ( Azure file on Windows is using SMB protocol), this PR still could not mount an azure file on current windows 2016 server node, it depends on 2016 RS3 release, and it will still succeed (as a workaround) if customer want to mount an azure file on current windows node.
      
      
      Main code logic is similar to what it does in Linux node:
      
      1. create target directory in Windows host
      2. Use New-SmbGlobalMapping powershell cmdlet to mount SMB azure file to a drive in Windows host
      3. Use mklink command to link target directory to the mounted drive
      
      K8s would bind target directory to the container directory
      source in mount function would be like:
      `\\[accountname].file.core.windows.net\test`
      
      target in mount function would be like:
      `c:\var\lib\kubelet\pods\5f679f75-7ce3-11e7-b718-000d3a31dac4\volumes\kubernetes.io~azure-file`
      
      sample azure file config file:
      ```
      apiVersion: v1
      kind: Pod
      metadata:
       name: iis
      spec:
       containers:
        - image: microsoft/iis
          name: iis
          volumeMounts:
            - name: azure
              mountPath: "d:"
       nodeSelector:
         beta.kubernetes.io/os: windows
       volumes:
            - name: azure
              azureFile:
                secretName: azure-secret
                shareName: k8stest
                readOnly: false
      ```
      
      **Release note**:
      
      ```release-note
      ```
      17ba22aa
    • Kubernetes Submit Queue's avatar
      Merge pull request #52131 from vmware/BulkVerifyVolumesImplVsphere · 63cc42a8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50068, 52406, 52394, 48551, 52131). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Implement bulk polling of volumes for vSphere
      
      This PR implements bulk polling of volumes - BulkVerifyVolumes() API for vSphere. 
      
      With the existing implementation, vSphere makes multiple calls to VC to check if the volume is attached to a node. If there are "N" volumes attached on "M" nodes, vSphere makes "N" VCenter calls to check if the volumes are attached to VC for all "N" volumes. Also, by default Kubernetes queries if the volumes are attached to nodes every 1 minute. This will substantially increase the number of calls made by vSphere cloud provider to vCenter.
      
      Inorder to prevent this, vSphere cloud provider implements the BulkVerifyVolumes() API in which only a single call is made to vCenter to check if all the volumes are attached to the respective nodes. Irrespective of the number of volumes attached to nodes, the number of vCenter calls will always be 1 on a query to BulkVerifyVolumes() API by kubernetes.
      
      @rohitjogvmw @divyenpatel @luomiao
      
      ```release-note
      BulkVerifyVolumes() implementation for vSphere
      ```
      63cc42a8
    • Kubernetes Submit Queue's avatar
      Merge pull request #48551 from leblancd/v6_new_proxier · 414a3bdd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50068, 52406, 52394, 48551, 52131). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Add IPv6 support to iptables proxier
      
      Add IPv6 support to iptables proxier
      
      The following changes are proposed for the iptables proxier:
      
      - There are three places where a string specifying IP:port is parsed
        using something like this:
            if index := strings.Index(e.endpoint, ":"); index != -1 {
        This will fail for IPv6 since V6 addresses contain colons. Also,
        the V6 address is expected to be surrounded by square brackets
        (i.e. [<ipv6-addr>]:<port>). Fix this by replacing call to Index with
        call to LastIndex() and stripping out square brackets.
      - The String() method for the localPort struct should put square brackets
        around IPv6 addresses.
      - The logging in the merge() method for proxyServiceMap should put brackets
        around IPv6 addresses.
      - There are several places where filterRules destination is hardcoded to
        <clusterIP>/32. This should be a /128 for IPv6 case.
      - Add IPv6 unit test cases
      
      Note: I've left out most of the UT test cases that I had included in my original version of this
      PR because the number of lines of code change were much too large for a single review.
      I'm including a minimum of UT with this current version of the PR.
      
      fixes #48550
      
      
      
      **What this PR does / why we need it**:
      This PR addresses several issues in the iptables proxier for handling IPv6 addresses
      that were found via visual code inspection, including:
      - There are three places where a string specifying IP:port using something like the following:
             if index := strings.Index(e.endpoint, ":"); index != -1 {
        This will fail for IPv6 since V6 addresses contains many colons, and the V6 address is expected
        to be enclosed in square brackets when followed by :<port>.
      - The String() method for the localPort struct should put square brackets around IPv6 addresses.
      - The logging in the merge() method for proxyServiceMap should put brackets around IPv6
        addresses.
      - There are several places where filterRules destination is hardcoded to /32.
        Should be a /128 for IPv6 case.
      - More IPv6 unit test cases are needed.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48550
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      414a3bdd
    • Kubernetes Submit Queue's avatar
      Merge pull request #52394 from Lion-Wei/ipvs-nodeport · c7f72a63
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50068, 52406, 52394, 48551, 52131). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      add FlagPersistent flag in nodePort and other situation
      
      **What this PR does / why we need it**:
      For AffinityClientIP service, origin code in ipvs didn't add Persistent flag, which is a bug, so I added it.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52626
      
      **Special notes for your reviewer**:
      add FlagPersistent flag in nodePort and other situation
      
      **Release note**:
      ```release-note
      NONE
      ```
      c7f72a63
    • Kubernetes Submit Queue's avatar
      Merge pull request #52406 from wackxu/rminithea · cb0ee6f2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50068, 52406, 52394, 48551, 52131). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      remove unless healthz.DefaultHealthz() in controller-manager
      
      **What this PR does / why we need it**:
      
      remove unless healthz.DefaultHealthz() in controller-manager
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52405
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      cb0ee6f2
    • Kubernetes Submit Queue's avatar
      Merge pull request #50068 from m1093782566/kubectl-fix-2 · 56543076
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Add UT for pkg/kubectl/autoscale_test.go
      
      **What this PR does / why we need it**:
      
      I find there is no UT for testing pkg/kubectl `HorizontalPodAutoscalerV1.generate(params)`. This PR add some UTs in pkg/kubectl/autoscale_test.go
      
      **Which issue this PR fixes** : fixes #50810
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /sig cli
      56543076
    • Kubernetes Submit Queue's avatar
      Merge pull request #52697 from mkumatag/nonewprivs · a85b94ec
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51902, 52718, 52687, 52137, 52697). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Multi-arch allowPrivilegeEscalation tests
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52698 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```NONE
      ```
      a85b94ec
    • Kubernetes Submit Queue's avatar
      Merge pull request #52137 from aveshagarwal/master-scheduler-resources-consolidation · 6e9012c9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51902, 52718, 52687, 52137, 52697). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Consolidate extended resources and hugepages in Scheduler
      
      Fixes https://github.com/kubernetes/kubernetes/issues/51732
      
      @bsalamat @derekwaynecarr @sjenning @kubernetes/sig-scheduling-pr-reviews
      6e9012c9
    • Kubernetes Submit Queue's avatar
      Merge pull request #52687 from mtanino/teardown-refactor · a1a441f7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51902, 52718, 52687, 52137, 52697). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Refactoring and improvements for iSCSI and FC storage plugins
      
      **What this PR does / why we need it**:
      
      This PR makes following changes.
      
      - Simplify volume tearDown path for iSCSI and FC using
        util.UnmountPath().
      - Log lastErr during iscsi connection
        If iscsid fails to connect second portal, currently
        the error is ignored silently. The lastErr should be
        logged to find the root cause of problem.
      - Remove iscsi plugin directory after iscsi connection
        is successfully closed.
      
      **Which issue this PR fixes** : No related issues.
      
      **Special notes for your reviewer**:
      
      /cc @rootfs @jsafrane 
      
      **Release note**:
      
      ```
      NONE
      ```
      a1a441f7
    • Kubernetes Submit Queue's avatar
      Merge pull request #52718 from foxyriver/ingress · ac91b19c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 51902, 52718, 52687, 52137, 52697). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      stop the Timer
      
      **What this PR does / why we need it**:
      
      Ticker stop twice, and does not stop Timer.
      ac91b19c
    • Kubernetes Submit Queue's avatar
      Merge pull request #51902 from zhangxiaoyu-zidif/fix-typo-cronjob-utils · 2b24df34
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      Refactor cronjob test case with sets.String
      
      **What this PR does / why we need it**:
      Refactor cronjob test case with sets.String
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubernetes/issues/51396
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      2b24df34
    • Kubernetes Submit Queue's avatar
      Merge pull request #51971 from juanvallejo/jvallejo/add-list-option-to-kubectl-label · d7fc98f5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 52485, 52443, 52597, 52450, 51971). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..
      
      add --list option to label cmd
      
      **Release note**:
      ```release-note
      added --list option to the `kubectl label` command
      ```
      
      Adds a `--list` option to `kubectl label ...` with similar behavior to `kubectl env ... --list`
      
      **Before**
      ```
      $ kubectl label pod/mypod --list
      Error: unknown flag: --list
      
      Usage:
      ...
      ```
      
      **After**
      ```
      $ kubectl label pod/mypod --list
      labelkey1=existinglabel1
      labelkey2=existinglabel2
      
      $ kubectl label pod/mypod --list label1=newlabel1
      labelkey1=existinglabel1
      labelkey2=existinglabel2
      label1=newlabel1
      ```
      
      Related downstream bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1268877
      
      cc @fabianofranz @kubernetes/sig-cli-misc
      d7fc98f5