1. 19 Jul, 2017 29 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #49130 from deads2k/server-30-admission · defbe453
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130)
      
      expose RegisterAllAdmissionPlugins so that admission chains can be reused
      
      Exposes the admission plugin registration functions so that sets of plugins can be re-used.
      
      @sttts @p0lyn0mial
      defbe453
    • Kubernetes Submit Queue's avatar
      Merge pull request #36238 from resouer/eclass-2-dev · 2faf7ff2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130)
      
      Implement equivalence cache by caching and re-using predicate result
      
      The last part of #30844, I opened a new PR instead of overwrite the old one because we changed some basic assumption by allowing invalidating equivalence cache item by individual predicate.
      
      The idea of this PR is based on discussion in https://github.com/kubernetes/kubernetes/issues/32024
      
      - [x]  Pods belong to same controllerRef considered to be equivalent
      - [x] ` podFitsOnNode` will use cached predicate result if it's available
      - [x] Equivalence cache will be updated when if a fresh new predicate is done
      - [x] `factory.go` will invalid specific predicate cache(s) based on the object change
      - [x] Since `schedule` and `bind` are async, we need to optimistically invalid affected cache(s) before `bind`
      - [x] Fully unit test of affected files
      - [x] e2e test to verify cache update/invalid workflow
      - [x] performance test results
      
      - [x] Some nits fixes related but expected to result in `needs-rebase` so they are split to: #36060 #35968 #37512
      
      cc @wojtek-t @davidopp
      2faf7ff2
    • Kubernetes Submit Queue's avatar
      Merge pull request #49139 from deads2k/cli-15-proxy-defaults · 495f5b26
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130)
      
      expose method to allow externally setting defaults on an external type
      
      The options are an exposed type.  This allows you to set the defaults on them.
      
      @derekwaynecarr who normally owns this bit?
      495f5b26
    • Kubernetes Submit Queue's avatar
      Merge pull request #48200 from irfanurrehman/fed-sched-generic-args · cf9f00bb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130)
      
      [Federation] Make arguments to scheduling type adapter methods generic
      
      This is in the process of trying to rebase https://github.com/kubernetes/kubernetes/pull/45993 on latest.
      cc @marun @perotinus 
      @kubernetes/sig-federation-misc 
      Hoping I get some attention to this and later PRs soon.
      
      Associated issue https://github.com/kubernetes/kubernetes/issues/49181
      
      **Release note**:
      
      ```NONE
      ```
      cf9f00bb
    • Kubernetes Submit Queue's avatar
      Merge pull request #48043 from xiangpengzhao/validate-storage-backend · 8293a7d5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130)
      
      Validate --storage-backend type.
      
      **What this PR does / why we need it**:
      Validate --storage-backend type as early as possible.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47517
      This PR is as per https://github.com/kubernetes/kubernetes/pull/47517/files#r121975646
      
      **Special notes for your reviewer**:
      /cc @justinsb 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8293a7d5
    • Kubernetes Submit Queue's avatar
      Merge pull request #48950 from alexandercampbell/kubectl-deduplicate-deployment-generators · d74ac378
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950)
      
      kubectl: deduplicate deployment generators
      
      **What this PR does / why we need it**: See the description on https://github.com/kubernetes/kubectl/issues/44
      
      **Which issue this PR fixes**: fixes https://github.com/kubernetes/kubectl/issues/44
      
      **Special notes for your reviewer**: Yes, the lines added and removed are about the same. This is because I added 20+ lines of docstrings. Check the diff. You'll see I deleted a lot of duplicated logic :)
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      d74ac378
    • Kubernetes Submit Queue's avatar
      Merge pull request #49165 from mikedanese/cleanup2 · c3f4e7e5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950)
      
      gce: don't print every file in mounter to stdout
      
      This is printing ~3000 lines.
      c3f4e7e5
    • Kubernetes Submit Queue's avatar
      Merge pull request #49157 from mikedanese/cleanup1 · 5e50097c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950)
      
      gce: make some global variables local
      
      /approve no-issue
      5e50097c
    • Kubernetes Submit Queue's avatar
      Merge pull request #46755 from CaoShuFeng/cani-test-cmd · 164cae11
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950)
      
      add cmd test for kubectl auth can-i
      
      **Release note**:
      
      ```
      NONE
      ```
      164cae11
    • Kubernetes Submit Queue's avatar
      Merge pull request #49120 from jpeeler/podpreset-nonamespace · 1bb6b815
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950)
      
      Modify podpreset lister to use correct namespace
      
      Previously a pod with an empty namespace field submitted to a given namespace
      was incorrectly matching preset labels in a different namespace.
      
      Fixes https://github.com/kubernetes/kubernetes/issues/49141
      
      Release note:
      ```release-note
      Fix pod preset to ignore input pod namespace in favor of request namespace
      ```
      1bb6b815
    • Kubernetes Submit Queue's avatar
      Merge pull request #49110 from xiangpengzhao/remove-annotation-affinity · 2492477f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110)
      
      Remove affinity annotations leftover
      
      **What this PR does / why we need it**:
      This is a further cleanup for affinity annotations, following #47869.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      ref: #47869
      
      **Special notes for your reviewer**:
      - I remove the commented test cases and just leave TODOs instead. I think converting these untestable test cases for now is not necessary. We can add new test cases in future.
      - I remove the e2e test case `validates that embedding the JSON PodAffinity and PodAntiAffinity setting as a string in the annotation value work` because we have a test case `validates that InterPod Affinity and AntiAffinity is respected if matching` to test the same thing.
      
      /cc @aveshagarwal @bsalamat  @gyliu513 @k82cn @timothysc 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      2492477f
    • Kubernetes Submit Queue's avatar
      Merge pull request #49134 from deads2k/cli-14-tolerate-missing-template · 882f838a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110)
      
      make sure that the template param is the right type before using it
      
      The CLI should attempt to make sure that the flags it uses conform to expectations instead of unconditionally killing a process.  This allows for possible re-use of the printing stack.
      882f838a
    • Kubernetes Submit Queue's avatar
      Merge pull request #49132 from deads2k/cli-01-union-category · 8337bd02
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110)
      
      add a union category expander
      
      Adds a union category expander for use when we need to combined hardcoded and non-hardcoded options.
      8337bd02
    • Kubernetes Submit Queue's avatar
      Merge pull request #49128 from deads2k/server-29-mising-shortname · 45432de4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110)
      
      add svc and netpol to discovery
      
      Fixes https://github.com/kubernetes/kubernetes/issues/48962
      
      one shortname was missing entirely, the other was on a storage not actually used as storage.
      
      @ncdc
      45432de4
    • Kubernetes Submit Queue's avatar
      Merge pull request #49055 from mbohlool/bugfix2 · effcdda0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110)
      
      OpenAPI bug: Array/Map Ptr Elements' handing was incorrect
      
      If you have an array of map of pointers, OpenAPI spec generation would fail.
      
      fixes: #49074
      effcdda0
    • Kubernetes Submit Queue's avatar
      Merge pull request #48871 from wanghaoran1988/do_not_close_stdin · 32580b89
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871)
      
      do not close os.Stdin manually
      
      **What this PR does / why we need it**:
      We don't need close os.Stdin manually, it will block our read from stdin after finish the visit.
      **Special notes for your reviewer**:
      
      **Release note**:
      ```
      None
      ```
      32580b89
    • Kubernetes Submit Queue's avatar
      Merge pull request #48935 from CaoShuFeng/NamespaceLifecycle · 6c7eac2d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871)
      
      fix NamespaceLifecycle admission
      
      forceLiveLookupCache is designed to save recently deleted namespaces.
      But currently, cluster scoped resources are also put into it.
      For example, when we run:
      kubectl delete clusterrole edit
      The "edit" is put into forceLiveLookupCache as a deleted namespace.
      This change fix the invalid action.
      
      
      **Release note**:
      
      ```
      NONE
      ```
      6c7eac2d
    • Kubernetes Submit Queue's avatar
      Merge pull request #49099 from xiangpengzhao/fix-healthcheck-flake · b787acec
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871)
      
      Fix health check node port test flake
      
      **What this PR does / why we need it**:
      - Releases the allocated HealthCheck NodePort at the end of each associated test case.
      - Fixes the weird output `0` in `failed to allocate requested HealthCheck NodePort 0`
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49098
      
      **Special notes for your reviewer**:
      /cc @freehan 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b787acec
    • Kubernetes Submit Queue's avatar
      Merge pull request #48535 from mkumatag/debian_base · 94c3c571
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871)
      
      Adopt debian-base as baseimage
      
      **What this PR does / why we need it**:
      Based on discussion from - https://github.com/kubernetes/kubernetes/pull/44910/files#r125150263
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49169
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```NONE
      ```
      94c3c571
    • Kubernetes Submit Queue's avatar
      Merge pull request #48914 from MrHohn/gke-kube-down-log · 384c1d28
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871)
      
      Log error when fail to execute command in with-retry()
      
      **What this PR does / why we need it**: Enhance gke/util.sh logging.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48913
      
      **Special notes for your reviewer**:
      /cc @krzyzacy 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      384c1d28
    • Kubernetes Submit Queue's avatar
      Merge pull request #48232 from caesarxuchao/move-admission-v1alph1 · ccaaf5ca
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232)
      
      Move admission/v1alpha1 to k8s.io/api
      
      Fix https://github.com/kubernetes/kubernetes/issues/47972
      ccaaf5ca
    • Kubernetes Submit Queue's avatar
      Merge pull request #48974 from supereagle/cleanup-objectreference-conversion · c1c5f8e6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232)
      
      Cleanup the conversion of ObjectReference
      
      **What this PR does / why we need it**:
      No need to convert ObjectReference as `k8s.io/kubernetes/pkg/api/v1` and `k8s.io/client-go/pkg/api/v1` has been consistent in `k8s.io/api/core/v1`.
      
      **Which issue this PR fixes**: fixes #48747
      
      **Special notes for your reviewer**:
      /assign @caesarxuchao
      
      **Release note**:
      ```release-note
      NONE
      ```
      c1c5f8e6
    • Kubernetes Submit Queue's avatar
      Merge pull request #48740 from mikedanese/aggr · a8bb13d4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232)
      
      aggr: don't write empty CA files
      
      write now if the metadata is not supplied, we write an empty file for
      these certs. we should just fail.
      
      Notice the removal of the ":-"s
      a8bb13d4
    • Kubernetes Submit Queue's avatar
      Merge pull request #48965 from mindprince/fixit-week · fe7c2926
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232)
      
      Move GPU e2e tests under owning SIG.
      
      Supercedes #48723
      
      **Release note**:
      ```release-note
      NONE
      ```
      /sig scheduling
      /assign @vishh @fejta @grodrigues3
      fe7c2926
    • Kubernetes Submit Queue's avatar
      Merge pull request #48702 from FengyunPan/cloudprovider-rackspace · a0e7114a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232)
      
      Rackspace for cloud-controller-manager
      
      This implements the NodeAddressesByProviderID and InstanceTypeByProviderID
      methods used by the cloud-controller-manager to the RackSpace provider.
      The instance type returned is the flavor name, for consistency
      InstanceType has been implemented too returning the same value.
      
      This is part of #47257 cc @wlan0
      
      **Release note**:
      ```release-note
      NONE
      ```
      a0e7114a
    • Kubernetes Submit Queue's avatar
      Merge pull request #49109 from MaciekPytel/update_hpa_owners · 0dff56b4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add approvers to owners file for hpa
      
      Currently none of hpa developers or people in sig-autoscaling has the right to approve PRs to hpa, meaning it needs to be approved at pkg/controller level by people not working on autoscaling.
      0dff56b4
    • Kubernetes Submit Queue's avatar
      Merge pull request #48256 from xiangpengzhao/move-pkg-util · fc1d2b3b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48481, 48256)
      
      Refactor: pkg/util into sub-pkgs
      
      **What this PR does / why we need it**:
      - move code in pkg/util into sub-pkgs
      - delete some unused funcs
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #15634
      
      **Special notes for your reviewer**:
      This is the final work of #15634. It will close that issue.
      /cc @thockin 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      fc1d2b3b
    • Kubernetes Submit Queue's avatar
      Merge pull request #48481 from fabianofranz/apply_protect_against_nil_panic · 7bd44a21
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48481, 48256)
      
      Protect against nil panic in apply
      
      **What this PR does / why we need it**: `kubectl apply` has a potential panic (actually verified in OpenShift in https://github.com/openshift/origin/issues/15017) where a `patcher` calls the `runDelete` function with a nil `resource.RESTClient`, but under some conditions the client is required by that function.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      @pwittrock @kubernetes/sig-cli-bugs
      7bd44a21
    • Mike Danese's avatar
      7a6917f5
  2. 18 Jul, 2017 11 commits